From: Michal Simek <michal.simek@amd.com>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: xilinx: Drop "label" property on dlg,slg7xl45106
Date: Thu, 18 Dec 2025 15:15:26 +0100 [thread overview]
Message-ID: <29b45cc2-e0df-4411-bfb9-cfe51ec4ec67@amd.com> (raw)
In-Reply-To: <CAL_JsqKdrN5UpUWQVQXpJjbTy1gN9_FhhwOoX6zVpG+zZVAptA@mail.gmail.com>
On 12/17/25 21:41, Rob Herring wrote:
> On Wed, Dec 17, 2025 at 6:39 AM Michal Simek <michal.simek@amd.com> wrote:
>> On 12/16/25 18:59, Rob Herring (Arm) wrote:
>>> The "label" property is not documented for the dlg,slg7xl45106. Nor is
>>> it common to use for GPIO controllers. So drop it.
>>>
>>
>> Correct it is not documented but it is at least used in Linux also by
>> drivers/gpio/gpio-mmio.c:810: err = device_property_read_string(dev, "label",
>> &label);
>>
>> which is also not documented in DT binding.
>
> It really should be for all GPIO providers or none of them. IMO, it
> should be none of them as we already have "gpio-line-names" which is
> essentially per line labels. I can't see why anyone should care about
> a label for the controller.
>
>> I don't have a problem with it because I can't see it used anywhere.
>>
>> But there are other devices where label is the part of binding. And IMHO this
>> should be more generic property.
>
> "label" is the generic property. Not sure what you are suggesting here.
That schema should allow to define label in every node or some class of devices.
Thanks,
Michal
next prev parent reply other threads:[~2025-12-18 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 17:59 [PATCH] arm64: dts: xilinx: Drop "label" property on dlg,slg7xl45106 Rob Herring (Arm)
2025-12-17 12:38 ` Michal Simek
2025-12-17 12:42 ` Krzysztof Kozlowski
2025-12-17 12:44 ` Krzysztof Kozlowski
2025-12-17 20:41 ` Rob Herring
2025-12-18 14:15 ` Michal Simek [this message]
2025-12-19 14:48 ` Rob Herring
2026-01-06 11:33 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29b45cc2-e0df-4411-bfb9-cfe51ec4ec67@amd.com \
--to=michal.simek@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).