Re: [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 24/07/2023 09:58, Alexander Stein wrote:
> Hi,
> 
> Am Montag, 24. Juli 2023, 09:23:09 CEST schrieb Krzysztof Kozlowski:
>> On 24/07/2023 08:35, Alexander Stein wrote:
>>> This is a gpio-controller, so gpio-line-names should be allowed as well.
>>> stmpe2403 supports up to 24 GPIOs.
>>>
>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> ---
>>> Changes in v2:
>>> * Add min/maxItems
>>>
>>>  Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
>>> b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml index
>>> 22c0cae73425..4555f1644a4d 100644
>>> --- a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
>>> +++ b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
>>>
>>> @@ -28,6 +28,10 @@ properties:
>>>    gpio-controller: true
>>>
>>> +  gpio-line-names:
>>> +    minItems: 1
>>> +    maxItems: 24
>>> +
>>
>> I am sure there is no variant with one GPIO.
> 
> That's true. But if only one GPIO is actually connected there is no use 
> enforcing to add empty entries.
> AFAIK it is also allowed to provide an incomplete array.

Did you test it? Linux prints warning. Warning means "not allowed".

The expectation is that the rest are named "NC".

Best regards,
Krzysztof