From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5276C04A94 for ; Mon, 24 Jul 2023 10:14:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233247AbjGXKOu (ORCPT ); Mon, 24 Jul 2023 06:14:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231439AbjGXKNu (ORCPT ); Mon, 24 Jul 2023 06:13:50 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E9461BC9 for ; Mon, 24 Jul 2023 03:06:51 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-31438512cafso3702923f8f.2 for ; Mon, 24 Jul 2023 03:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690193210; x=1690798010; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=94dQO8LxQMdHUG+2c49m7yEu0QyNmeaEeNnaDcdEi50=; b=zyHUdJSJPuVoVRhjX/yJrSNl6g+BvStzMeYhopNSSLd6lURlIX5vT17KNsxjAEcX15 RmZZ0Ln9y9jm6wryAMOXeEP9XPFijj5ifyNa/3Qe4+P2PcYlw48TwyF40pFO7q8CAl8E A0mZfKvI3urMhpeKIwBsbzP7IQrhpla5AFWsnYU8eGG5688MxkDSw5sNiiem8iJY3GGt QfRkcw10o4a+RfmrJWIIVmD+DImaXbM0kkSKv5qjQI8jn7RoQNUi4hl7w2wNQ5zXs2nv ZvSf+Y7cH6bpVmM3ldyhrkKEoyfnxog3DYtJ/cjUoRonVoMiDcKlOfHBXeXraUtM+/fy 9y9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690193210; x=1690798010; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=94dQO8LxQMdHUG+2c49m7yEu0QyNmeaEeNnaDcdEi50=; b=gsyVrhCO69/pMa5wL+3F9m6RZ5DYewLMvkCFPf9w833flU+dPsxyRu2Jd32RqUsmnY pu3C2+zbT+JsfwD33z13V1Qt5rgZGzx/+UsSxsuz2OJ0lZtqsEgEvVvx1fxrsn/+CVqk Mooq4M5mudGyN4dWsWJZywIvm6Aw7+vi6L2e+W9e7vk/wZYNfoTzl+G5kq6kdB5R7B2g t8DOrIAbE6aLodbtO2OSbYskpypvQUoD69r6a9q64naGiRESKnP1ScXEGrrqExiorGFO 6JjLxkEMgoU3E4JKUfnapKrBY9wBBPrcu5IeJFu0HK5xrsD38yle9F9tjVMiS3z0lY2B wrBg== X-Gm-Message-State: ABy/qLaGjmguXM64KHoOiJa9rIkmjwXomujuthTrCiVuSMLNZUvUihAS dibrcxaUfwzq8WK2EGjzWh0jEANMokyfHLd6CnxCYw== X-Google-Smtp-Source: APBJJlFaYyJc7x+0ExqkM6W4yVmevNoyHsVyru+pCZlw6jseQKGHeO49Y942+w5FqL1ss44s207a2g== X-Received: by 2002:a17:906:778f:b0:982:45ca:ac06 with SMTP id s15-20020a170906778f00b0098245caac06mr8953749ejm.60.1690192455496; Mon, 24 Jul 2023 02:54:15 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id e13-20020a170906248d00b0099307a5c564sm6473655ejb.55.2023.07.24.02.54.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 02:54:15 -0700 (PDT) Message-ID: <29b62cc6-bc54-9a43-211b-b2d7579218b7@linaro.org> Date: Mon, 24 Jul 2023 11:54:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO Content-Language: en-US To: Alexander Stein , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Pavel Machek , Lee Jones Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20230724063520.182888-1-alexander.stein@ew.tq-group.com> <0f016242-2380-274e-c6a4-118a5872412e@linaro.org> <21957396.EfDdHjke4D@steina-w> From: Krzysztof Kozlowski In-Reply-To: <21957396.EfDdHjke4D@steina-w> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/07/2023 09:58, Alexander Stein wrote: > Hi, > > Am Montag, 24. Juli 2023, 09:23:09 CEST schrieb Krzysztof Kozlowski: >> On 24/07/2023 08:35, Alexander Stein wrote: >>> This is a gpio-controller, so gpio-line-names should be allowed as well. >>> stmpe2403 supports up to 24 GPIOs. >>> >>> Signed-off-by: Alexander Stein >>> --- >>> Changes in v2: >>> * Add min/maxItems >>> >>> Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml >>> b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml index >>> 22c0cae73425..4555f1644a4d 100644 >>> --- a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml >>> +++ b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml >>> >>> @@ -28,6 +28,10 @@ properties: >>> gpio-controller: true >>> >>> + gpio-line-names: >>> + minItems: 1 >>> + maxItems: 24 >>> + >> >> I am sure there is no variant with one GPIO. > > That's true. But if only one GPIO is actually connected there is no use > enforcing to add empty entries. > AFAIK it is also allowed to provide an incomplete array. Did you test it? Linux prints warning. Warning means "not allowed". The expectation is that the rest are named "NC". Best regards, Krzysztof