From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B7C0C4321E for ; Thu, 1 Dec 2022 11:38:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230221AbiLALig (ORCPT ); Thu, 1 Dec 2022 06:38:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbiLALie (ORCPT ); Thu, 1 Dec 2022 06:38:34 -0500 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC7B429368 for ; Thu, 1 Dec 2022 03:38:32 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id x6so1545839lji.10 for ; Thu, 01 Dec 2022 03:38:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kUvP+fbh+LbeoMcKSslf8ydYhHl1l7ffmnzPtMfNWuA=; b=k4Dgpb/F7Unab4wrYFJA4Mb9EFuFoR0MUsSAcPi1em3TWiua69YsdPUnTpx/NnnqCC xzMTJLNux1isYDHJE7SaOErPXJnzA4H9jMhO1Ng/EK664fBBqnh9QYOwik6Nqa2n3LQl E3or9rR6zABHxl6HQQ6kJNBcUKpjuuNaEKlYyzqUHwuYKlTt42ck3GE0KYPgcR0nh5Z5 1RTbvtfr7ariRZlKZuumbBQl9OucsKanujX/giV/5ZtsMHFd5jxBxAaFIK6fr/6dz+JF c7eFF4RIF6sxpClJF2MMxAWQ+k+nrczHhjIE8x7HwD2FRNMGQC961c950af7jVRtJjNb fuQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kUvP+fbh+LbeoMcKSslf8ydYhHl1l7ffmnzPtMfNWuA=; b=Y3SFlwb/1H2hSW3gwXmcTH7peg8hH/Mo10S8sUFmMHwLs9QWI1ZXP829NkmHSS8aSY D1ouUIkkBo4cE+ruOLZ7v0tYfLAMTofPQpqLVdbyxsw1aR1ROW+zRAikkbKdcL9rqm1E GYoLG83D9Cf74yFme1XbduGvpTwPpxhYAXHNOFk5w9SXy+Tk+vUvKJv6/lovqO5utyfK bqtpaKyqo4clG+Xb7g3X5nmdzkg+muFOx2xQWZDDYRjkN7HxG5o9hMEF8SXc6V4bfWv7 FDhsb1ja6DBTUmjkLGC/05ycbd1PBq+MuWvMI25/epkSZbZ45jtDeozlrnHbLOFLIvKl 4nPw== X-Gm-Message-State: ANoB5pmq0/xqdlsfILKPktlTnxMHGOIIcGF4+UaOlbNVE/iXBXMaU4F0 h0qiHC4U1Yju58hx45aSuTnlLQ== X-Google-Smtp-Source: AA0mqf5pE5MPhUJ2CBEp6Gwji5cxkigvq5nFV5Vi6RkNBr4c2bCV+qB4f+m3vMpPNjU40MnrQO3H0Q== X-Received: by 2002:a2e:984d:0:b0:279:8e68:203d with SMTP id e13-20020a2e984d000000b002798e68203dmr9495820ljj.96.1669894710995; Thu, 01 Dec 2022 03:38:30 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a15-20020a19f80f000000b004949f7cbb6esm616990lff.79.2022.12.01.03.38.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Dec 2022 03:38:29 -0800 (PST) Message-ID: <29de4d2b-3e32-809e-6ccd-5e7a4fe548fc@linaro.org> Date: Thu, 1 Dec 2022 12:38:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 2/4] dt-bindings: hwmon/pmbus: Add mps,mpq7932 power-management IC Content-Language: en-US To: Saravanan Sekar Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, marten.lindahl@axis.com, jdelvare@suse.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20221201044643.1150870-1-saravanan@linumiz.com> <20221201044643.1150870-3-saravanan@linumiz.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/12/2022 12:29, Saravanan Sekar wrote: > On 01/12/22 11:26, Krzysztof Kozlowski wrote: >> On 01/12/2022 05:46, Saravanan Sekar wrote: >>> Document mpq7932 power-management IC >>> >>> Signed-off-by: Saravanan Sekar >>> --- >> >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my >> feedback got lost between the quotes, maybe you just forgot to apply it. >> Please go back to the previous discussion and either implement all >> requested changes or keep discussing them. >> > Hi Krzysztof, > > Thanks for your time to review and feedback. > > Here are the summary of comments on V1, I have fixed all according to my > understanding. > > > 1. Use subject prefixes matching the subsystem (git log --oneline -- ...). > > git log --oneline -- Documentation/devicetree/bindings/hwmon/pmbus/ > 1ccca53618c4 dt-bindings: hwmon/pmbus: Add mps,mpq7932 power-management IC > 373c0a77934c dt-bindings: hwmon/pmbus: Add ti,lm25066 power-management IC > 7f464532b05d dt-bindings: Add missing 'additionalProperties: false' > 8a36e38d8b0f dt-bindings: hwmon/pmbus: Add ti,ucd90320 power sequencer > > I have used the same format of 373c0a77934c. > > 2. Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > > I did run dt_binding_check on V1 but failed to notice warnings. Fixed > warning on V2 and didn't observed any warnings. > > 3. Why requiring nodename? Device schemas usually don't do that. > dropped "pattern: "pmic@[0-9a-f]{1,2}"" > > 4. regulators node is a regulator with one more regulator? Drop. > dropped "$ref: regulator.yaml# " The comment was - drop entire regulators node. Plus additional comment for the driver (and related to bindings) was that this is not hwmon but a regulator driver. Why putting regulator driver in hwmon? Best regards, Krzysztof