From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>, <nm@ti.com>,
<vigneshr@ti.com>, <kristo@kernel.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>
Subject: Re: [PATCH 07/13] arm64: dts: ti: iot2050-common: Remove redundant "mcu_cpsw" node status
Date: Fri, 30 May 2025 10:24:16 +0530 [thread overview]
Message-ID: <29efc4c0-e206-4f1c-a52f-27e5bbcda64b@ti.com> (raw)
In-Reply-To: <c0fdeecf-4a76-473d-9b66-e547d8fe9d1f@kernel.org>
On Thu, May 29, 2025 at 03:38:51PM +0200, Krzysztof Kozlowski wrote:
> On 29/05/2025 15:34, Siddharth Vadapalli wrote:
> > Now that the SoC file "k3-am65-mcu.dtsi" disables the "mcu_cpsw" node by
> > default, following the existing convention of disabling nodes in the SoC
> > file, remove the redundant section for disabling the "mcu_cpsw" node.
>
> It became redundant when you disabled it, so this must be part of that
> commit. Do not create redundant code with some artificial split of one
> logical work.
Sure, I will squash the commits. I tend to split the commits since it is
easier for maintainers to squash commits (if required) than to split them.
Thank you for reviewing the patch.
Regards,
Siddharth.
next prev parent reply other threads:[~2025-05-30 4:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 13:34 [PATCH 00/13] TI-K3-DTS: Cleanup CPSW DT Nodes Siddharth Vadapalli
2025-05-29 13:34 ` [PATCH 01/13] arm64: dts: ti: k3-am625-beagleplay: Enable "cpsw3g" in the board file Siddharth Vadapalli
2025-05-29 13:37 ` Krzysztof Kozlowski
2025-05-30 4:52 ` Siddharth Vadapalli
2025-05-29 13:34 ` [PATCH 02/13] arm64: dts: ti: k3-am62-lp-sk: " Siddharth Vadapalli
2025-05-29 13:34 ` [PATCH 03/13] arm64: dts: ti: k3-am625-sk: " Siddharth Vadapalli
2025-05-29 13:34 ` [PATCH 04/13] arm64: dts: ti: k3-am62-main: Disable "cpsw3g" in the SoC file Siddharth Vadapalli
2025-05-29 13:34 ` [PATCH 05/13] arm64: dts: ti: k3-am654-base-board: Enable "mcu_cpsw" in board file Siddharth Vadapalli
2025-05-29 13:34 ` [PATCH 06/13] arm64: dts: ti: k3-am65-mcu: Disable "mcu_cpsw" in the SoC file Siddharth Vadapalli
2025-05-29 13:34 ` [PATCH 07/13] arm64: dts: ti: iot2050-common: Remove redundant "mcu_cpsw" node status Siddharth Vadapalli
2025-05-29 13:38 ` Krzysztof Kozlowski
2025-05-30 4:54 ` Siddharth Vadapalli [this message]
2025-05-29 13:34 ` [PATCH 08/13] arm64: dts: ti: k3-j7200-common-proc-board: Enable "mcu_cpsw" in board file Siddharth Vadapalli
2025-05-29 13:34 ` [PATCH 09/13] arm64: dts: ti: k3-j7200-mcu-wakeup: Disable "mcu_cpsw" in the SoC file Siddharth Vadapalli
2025-05-29 13:34 ` [PATCH 10/13] arm64: dts: ti: k3-j721e-common-proc-board: Enable "mcu_cpsw" in board file Siddharth Vadapalli
2025-05-29 13:34 ` [PATCH 11/13] arm64: dts: ti: k3-j721e-mcu-wakeup: Disable "mcu_cpsw" in the SoC file Siddharth Vadapalli
2025-05-29 13:34 ` [PATCH 12/13] arm64: dts: ti: k3-j721s2-common-proc-board: Enable "mcu_cpsw" in board file Siddharth Vadapalli
2025-05-29 13:34 ` [PATCH 13/13] arm64: dts: ti: k3-j721s2-mcu-wakeup: Disable "mcu_cpsw" in the SoC file Siddharth Vadapalli
2025-05-29 13:38 ` Krzysztof Kozlowski
2025-05-30 4:56 ` Siddharth Vadapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29efc4c0-e206-4f1c-a52f-27e5bbcda64b@ti.com \
--to=s-vadapalli@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox