Devicetree
 help / color / mirror / Atom feed
From: Dan Hettena <danh-5j0BnJlmnLM@public.gmane.org>
To: David Gibson <dwg-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org>
Cc: devicetree-discuss
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	"parch-QRwYI7m9GJLYtjvyW6yDsg@public.gmane.org"
	<parch-QRwYI7m9GJLYtjvyW6yDsg@public.gmane.org>
Subject: RE: [Power.org:parch] cpu nodes and Power ISA categories
Date: Sun, 19 Sep 2010 23:35:40 -0700	[thread overview]
Message-ID: <2A9CCDDDAE41C446A006170FF0C786313BEEEB5479@express.ghs.com> (raw)
In-Reply-To: <20100920020105.GE5045@yookeroo>

> > In section 3.7.1 (General Properties of CPU nodes), add the following
> properties to the table in ePAPR 1.1:
> >
> > (1)
> >
> > Property Name: power-isa-impl-version
> > Usage: O
> > Value Type: <string>
> > Definition: Specifies the architecture version number (e.g., "2.06")
> with which this cpu is compliant.
> ...
> Rather than a separate property, I'd suggest here we define a
> convention for strings which can go into the compatible property of
> the cpu nodes.  So for example:
> 	cpu@0 {
> 		compatible = "ibm,POWER6", "powerpc,ISA-2.06";
> 		....
> 	};
> 
> (I'm not sure if that example is actually correct, but you get the idea).

That would be fine if powerpc were changed to power.

> > (2)
> >
> > Property Name: power-isa-impl-categories
> > Usage: O
> > Value Type: <stringlist>
> > Definition: Specifies all the implemented architectural categories,
> > in their abbreviated form, as specified in Book I of the selected
> > ISA version (e.g., "B","E","ECL","E.HV").
> 
> This sounds ok, but I'd suggest some minor changes to the naming.  It
> seems to me to make sense to treat "powerpc" as a quasi-vendor, and I
> think we want to avoid abbreviations in property name.  So perhaps:
> 	powerpc,implementation-categories = "E.HV";
> 
> I'm not really familiar with the Book I defined categories, so I can't
> comment on the content encoding at this point.

Again, change powerpc to power and I'm happy.

> > (3) For my amusement...
> >
> > Property Name: power-isa-impl-errata
> > Usage: O
> > Value Type: <stringlist>
> > Definition: Specifies a list of exceptions to the cpu's compliance
> > with the architecture. Each exception consists of a pair of strings
> > where the first string in the pair is the most general architectural
> > category impacted by the exception and the second string is a name
> > for the erratum. For example, a cpu node for an e500v1 core might
> > include "ECL","fsl-icbtls-isync-itlb-miss" to indicate that
> > undefined behavior can result if the execution of an icbtls
> > instruction is not separated from a subsequent ITLB miss by an isync
> > instruction. An OS may choose to avoid making use of a category if
> > it does not have workarounds for all listed errata.
> 
> Interesting idea, not sure if it's practical or not.  I think we'd
> need to pin down a bit more where the errata defintions would reside /
> who'd be responsible for the official list of defined errata and so
> forth.

I doubt it's practical. The biggest problem I see is that device trees ship (or at least always ought to ship) with hardware, and hardware tends to ship before all errata are known.

There is a general problem here though: Devices often fail to comply fully with the specifications implied by their "compatible" properties, so a generic driver for a device might not work unless there's some way to tell it what functionality of the device to avoid.

As to your question, the provider of the device (and thus the device tree node) would have to be responsible for specifying the errata, and I imagine there would be various pressures not to do that. Not everyone even makes their errata public.

I suspect the only real solution to this problem is the one we're used to: If the generic driver can't work with the device because the device is broken, then use a driver more specific to the device that knows how to get it to behave.

Dan

  reply	other threads:[~2010-09-20  6:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-24 14:50 resend-- RFC: representation of CPUs/threads in device trees Yoder Stuart-B08248
     [not found] ` <2A9CCDDDAE41C446A006170FF0C786313BEE192E14@express.ghs.com>
     [not found]   ` <2A9CCDDDAE41C446A006170FF0C786313BEE192E14-W7/FcDFGA5PmPQGcmWacsw@public.gmane.org>
2010-09-20  2:01     ` [Power.org:parch] cpu nodes and Power ISA categories David Gibson
2010-09-20  6:35       ` Dan Hettena [this message]
     [not found]         ` <2A9CCDDDAE41C446A006170FF0C786313BEEEB5479-W7/FcDFGA5PmPQGcmWacsw@public.gmane.org>
2010-09-21  2:57           ` David Gibson
2010-09-21 13:50             ` Jimi Xenidis
2010-09-21 14:34             ` Dan Hettena
     [not found]               ` <2A9CCDDDAE41C446A006170FF0C786313BEF25AB4A-W7/FcDFGA5PmPQGcmWacsw@public.gmane.org>
2010-09-21 22:21                 ` David Gibson
2010-09-22 13:47                   ` Steve Thurber
     [not found]                     ` <OF01353076.E8131683-ON862577A6.004B88CB-862577A6.004BBD2E-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-09-29  3:08                       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2A9CCDDDAE41C446A006170FF0C786313BEEEB5479@express.ghs.com \
    --to=danh-5j0bnjlmnlm@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=dwg-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org \
    --cc=parch-QRwYI7m9GJLYtjvyW6yDsg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox