From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B032118FDDE for ; Thu, 5 Dec 2024 06:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733379743; cv=none; b=J0htuAKTCMqBgQZVNLf0e7lj950M0C2KJxcoluA0f33JFScXRgX4JyymLWH7+ncQha9qmDxYGMQWDYWH8fKxxwq+Pix9hCrED6nv7ZzB89DBMIbz4aN1Q0QiUkEQeDBRb7Cee+2SIr9rUjBdh4/z8TTdJR6/Pn6hYk6jz6Rikm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733379743; c=relaxed/simple; bh=635HXEH9z9+euuYtdUWAXhck3oezPbylgKy1CXvtRrE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=h9qpxtijBw/HKXymGZLld3dNMSeS7e+1v08e/BEeSt4RjIH/ruyMSWRCqJ0YOaC4l+1TRZoHQ5QqvgbV93fSYA4GLtxDlro3VyrosDxkXAF/yW1ZoWCjYmASIpEcxPC8vTrTQ6cWZGzllBA0CrKoeW5dtcPLN4pKpnydC7YkMqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=F0Lxr09E; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F0Lxr09E" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-385e2880606so429694f8f.3 for ; Wed, 04 Dec 2024 22:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733379740; x=1733984540; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=635HXEH9z9+euuYtdUWAXhck3oezPbylgKy1CXvtRrE=; b=F0Lxr09Eak/GQOOtKyld0TH0mqp9lKCKMeFYoQy5C38t/jyhTIfeqOqlCPDyxW2idp cV5prbbduYU9eMw5+en+nvAC384BJX83WxO5uM+ycbQc7HOs1bthBHKKFiBzN54Ym+9a stqvPQ/mP+M4Aa1FDarvd9cOuLF8ncFDRcqi4nWcou9o3JYITTVRy4eQiV9pZcHl23dg hsaOBu01gHSTJ1fhokbY8n7WUcMnsQRMrO8+MUgL3szPivTnn0IbbwAxrG5h/u7hIn6j ZiRiEsKg74IfhxnJ1B0MBeK5HmvC/J3zOOKyITXdJaaDgrKYRRqN8NInvIkDqTJ8b3O0 r+2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733379740; x=1733984540; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=635HXEH9z9+euuYtdUWAXhck3oezPbylgKy1CXvtRrE=; b=lovdkwYbA2aXkFHzYfwL7vqwxWT0Wddmn+mJdVTxiDLTftINjFGU4NCA8RBw3Rz7P6 mva/QGBG7UKi2WnCGTEqwlUvLhHsTmBfxWS/bi5l7UQPtA4OsogBSHqMu9u60HoY3LZK S4KriqmQ0D91k2vZKZrk8obZIDOSdiqcEtkezF3LsYZno6K48aIoOu2WsgDjLlkxYa/Q zVkfyZEt5Bg8xsfvoIn2LMvA9P4Kc73G93AVlpJ8pmz2flju9bTHwrFXbMgN8nfDHi+s 7H1Ezq4bhqHI9x7XTDjmeCI2Yg93gyQ/kGppKtnliuWlkTpQbdkb7zH/dp6jWiqen/F8 TrcA== X-Forwarded-Encrypted: i=1; AJvYcCU0z/PZ28yFGyLYNngPp3/mG0noOU7hcI7D8qkvqSwNc3Fj6UNzDPI9BbVd1Te6Agzf8lfUqpsGDhoM@vger.kernel.org X-Gm-Message-State: AOJu0Yzv9IMHAi+RdzSwfYMERLz0b6JhO5spmMvsWmCKD1+szkg1z+Ve odX74fZeIx+0Czq5ykbW4T0NKghPhEcl3I+nxWSYZrt/c3ZRm1mkJAbCtcUoEQM= X-Gm-Gg: ASbGncsxfXSICviCZfO870/uaD674MtIz7LzGwofSy0L+eMrx0KYpHXhmcJWEVaXnII 1FH4wvgzqiJsQ0F/9EGITur4Ey7Eak7+n37D0RERXBYC+yQ5Y/QgsQbX4kuX5yHzxRWMhRW01ud KD9x7fgRCB8vYn+hjCWhbvrLUpoMsMfKxNZQBZKZ8aIT2l1aafuDZWORAylkaT/bwWm0zBsAzhy 9cXlT12vFeOvP+Ct24vDzPWXjnIJ2YlAf3yTGXx3k+pzN2nTZpoVg== X-Google-Smtp-Source: AGHT+IGp/jNJTmdaFQ6E6rKRxd5mOl5DWkdNmDAnwmLFHgFS6wCHCx0RvANhN0Zro7KAfaQqmMGFCA== X-Received: by 2002:a05:6000:1a86:b0:385:ef8e:a652 with SMTP id ffacd0b85a97d-385fd43c331mr9424928f8f.56.1733379739965; Wed, 04 Dec 2024 22:22:19 -0800 (PST) Received: from draszik.lan ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434d52732casm49399175e9.13.2024.12.04.22.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2024 22:22:19 -0800 (PST) Message-ID: <2a20b243ade39fa240f75baf22a13f02239e3411.camel@linaro.org> Subject: Re: [PATCH 2/4] dt-bindings: power: supply: add max77759-fg flavor and don't require nvme address From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Thomas Antoine , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dimitri Fedrau , Catalin Marinas , Will Deacon , Peter Griffin , Alim Akhtar Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Date: Thu, 05 Dec 2024 06:22:18 +0000 In-Reply-To: <5281f86d-6917-4f4e-b85d-70502a24c5bd@uclouvain.be> References: <20241202-b4-gs101_max77759_fg-v1-0-98d2fa7bfe30@uclouvain.be> <20241202-b4-gs101_max77759_fg-v1-2-98d2fa7bfe30@uclouvain.be> <575b3275-b2fa-4e5c-bb6b-759394b02e18@uclouvain.be> <30b0995903fb7db3f866d1304783d878f563fe2f.camel@linaro.org> <5281f86d-6917-4f4e-b85d-70502a24c5bd@uclouvain.be> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.1-4 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2024-12-04 at 14:13 +0100, Thomas Antoine wrote: > On 12/3/24 11:40, Andr=C3=A9 Draszik wrote: > > On Tue, 2024-12-03 at 11:23 +0100, Thomas Antoine wrote: > > > On 12/3/24 08:12, Andr=C3=A9 Draszik wrote: > > > > On Mon, 2024-12-02 at 14:07 +0100, Thomas Antoine via B4 Relay wrot= e: > > > > > From: Thomas Antoine > > > > >=20 > > > > > As the Maxim max77759 fuel gauge has no non-volatile memory slave= address, > > > > > make it non-obligatory. Except for this, the max77759 seems to be= have the > > > > > same as the max1720x. > > > >=20 > > > > What about the battery characterization tables? Aren't they needed = for > > > > correct reporting? [...] > >=20 > I looked into it. The probe function launches a delay work > max1720x_model_work which will try multiple times to run > max1720x_model_load which leads to > max_m5_load_gauge_model -> max_m5_update_custom_model >=20 > This last function writes 0x0059 to 0x62 and 0x00c4 to 0x63 which unlocks > the addresses from 0x80 to 0xaf. OK. The regmap I had proposed was excluding those based on the datasheet I have, but you probably noticed. [...] > If it is indeed the case and that all of those are equivalent to their > max1720x counterpart, I think the management of those values should be > added in another patch which implements it for both the max1720x (and pos= sibly the > max77759) as the mainline driver does not do anything with those values > currently. Thanks for the analysis! And yes, I agree. Adding new required properties to a DT binding is an ABI break, therefore I was trying to ensure the binding is complete from the start. Cheers, Andre'