* [PATCH v1 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support
[not found] <20230717062547.2086869-1-quic_fenglinw@quicinc.com>
@ 2023-07-17 6:25 ` Fenglin Wu
2023-07-17 19:59 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Fenglin Wu @ 2023-07-17 6:25 UTC (permalink / raw)
To: linux-arm-msm, linux-kernel, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski,
linux-input, devicetree
Cc: quic_collinsd, quic_subbaram, quic_fenglinw, quic_kamalw, jestar
Add support for vibrator module inside Qualcomm PMI632, PM7250B, PM7325B
and PM7550BA PMICs.
Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
---
Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
index c8832cd0d7da..642408e2b35f 100644
--- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
+++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
@@ -15,6 +15,10 @@ properties:
- qcom,pm8058-vib
- qcom,pm8916-vib
- qcom,pm8921-vib
+ - qcom,pmi632-vib
+ - qcom,pm7250b-vib
+ - qcom,pm7325b-vib
+ - qcom,pm7550ba-vib
reg:
maxItems: 1
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support
2023-07-17 6:25 ` [PATCH v1 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support Fenglin Wu
@ 2023-07-17 19:59 ` Krzysztof Kozlowski
2023-07-18 2:37 ` Fenglin Wu
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-17 19:59 UTC (permalink / raw)
To: Fenglin Wu, linux-arm-msm, linux-kernel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Dmitry Torokhov, Rob Herring,
Krzysztof Kozlowski, linux-input, devicetree
Cc: quic_collinsd, quic_subbaram, quic_kamalw, jestar
On 17/07/2023 08:25, Fenglin Wu wrote:
> Add support for vibrator module inside Qualcomm PMI632, PM7250B, PM7325B
> and PM7550BA PMICs.
>
> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
> ---
> Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
> index c8832cd0d7da..642408e2b35f 100644
> --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
> +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
> @@ -15,6 +15,10 @@ properties:
> - qcom,pm8058-vib
> - qcom,pm8916-vib
> - qcom,pm8921-vib
> + - qcom,pmi632-vib
> + - qcom,pm7250b-vib
> + - qcom,pm7325b-vib
> + - qcom,pm7550ba-vib
Aren't the last two compatible?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support
2023-07-17 19:59 ` Krzysztof Kozlowski
@ 2023-07-18 2:37 ` Fenglin Wu
2023-07-18 6:11 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Fenglin Wu @ 2023-07-18 2:37 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-arm-msm, linux-kernel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Dmitry Torokhov, Rob Herring,
Krzysztof Kozlowski, linux-input, devicetree
Cc: quic_collinsd, quic_subbaram, quic_kamalw, jestar
On 7/18/2023 3:59 AM, Krzysztof Kozlowski wrote:
> On 17/07/2023 08:25, Fenglin Wu wrote:
>> Add support for vibrator module inside Qualcomm PMI632, PM7250B, PM7325B
>> and PM7550BA PMICs.
>>
>> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
>> index c8832cd0d7da..642408e2b35f 100644
>> --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
>> +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
>> @@ -15,6 +15,10 @@ properties:
>> - qcom,pm8058-vib
>> - qcom,pm8916-vib
>> - qcom,pm8921-vib
>> + - qcom,pmi632-vib
>> + - qcom,pm7250b-vib
>> + - qcom,pm7325b-vib
>> + - qcom,pm7550ba-vib
>
> Aren't the last two compatible?
There are still every different PMICs even though the vibrator module in
PM7325B and PM7550BA are the same and they share the same register base
address as well.
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support
2023-07-18 2:37 ` Fenglin Wu
@ 2023-07-18 6:11 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-18 6:11 UTC (permalink / raw)
To: Fenglin Wu, linux-arm-msm, linux-kernel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Dmitry Torokhov, Rob Herring,
Krzysztof Kozlowski, linux-input, devicetree
Cc: quic_collinsd, quic_subbaram, quic_kamalw, jestar
On 18/07/2023 04:37, Fenglin Wu wrote:
>
>
> On 7/18/2023 3:59 AM, Krzysztof Kozlowski wrote:
>> On 17/07/2023 08:25, Fenglin Wu wrote:
>>> Add support for vibrator module inside Qualcomm PMI632, PM7250B, PM7325B
>>> and PM7550BA PMICs.
>>>
>>> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
>>> ---
>>> Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
>>> index c8832cd0d7da..642408e2b35f 100644
>>> --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
>>> +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
>>> @@ -15,6 +15,10 @@ properties:
>>> - qcom,pm8058-vib
>>> - qcom,pm8916-vib
>>> - qcom,pm8921-vib
>>> + - qcom,pmi632-vib
>>> + - qcom,pm7250b-vib
>>> + - qcom,pm7325b-vib
>>> + - qcom,pm7550ba-vib
>>
>> Aren't the last two compatible?
>
> There are still every different PMICs even though the vibrator module in
> PM7325B and PM7550BA are the same and they share the same register base
> address as well.
So the vibrator modules are compatible? Then I propose to make them
compatible.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-18 6:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230717062547.2086869-1-quic_fenglinw@quicinc.com>
2023-07-17 6:25 ` [PATCH v1 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support Fenglin Wu
2023-07-17 19:59 ` Krzysztof Kozlowski
2023-07-18 2:37 ` Fenglin Wu
2023-07-18 6:11 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).