From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
johan.hedberg@gmail.com, luiz.dentz@gmail.com,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
alok.a.tiwari@oracle.com, hdanton@sina.com,
ilpo.jarvinen@linux.intel.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
rohit.fule@nxp.com, sherry.sun@nxp.com
Subject: Re: [PATCH v2 2/3] dt-bindings: net: bluetooth: Add NXP bluetooth support
Date: Tue, 31 Jan 2023 20:04:55 +0100 [thread overview]
Message-ID: <2a237ca0-15cd-b86c-7d9b-32014370d9dd@linaro.org> (raw)
In-Reply-To: <20230130180504.2029440-3-neeraj.sanjaykale@nxp.com>
On 30/01/2023 19:05, Neeraj Sanjay Kale wrote:
> Add binding document for generic and legacy NXP bluetooth
> chipsets.
>
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> ---
> v2: Resolved dt_binding_check errors. (Rob Herring)
> v2: Modified description, added specific compatibility devices,
> corrected indentations. (Krzysztof Kozlowski)
> ---
> .../bindings/net/bluetooth/nxp-bluetooth.yaml | 40 +++++++++++++++++++
> MAINTAINERS | 6 +++
> 2 files changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml
> new file mode 100644
> index 000000000000..9c8a25396b49
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml
Filename based on family of devices or compatible (assuming it is
correct): nxp,w8987-bt.yaml
Hyphen is not a correct separator between vendor prefix and device name.
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/bluetooth/nxp-bluetooth.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP Bluetooth chips
> +
> +description:
> + This binding describes UART-attached NXP bluetooth chips.
This is description of binding. So in description of binding for NXP
bluetooth chips you say that it describes NXP bluetooth chips. I don't
think it's useful. Describe the hardware instead.
> +
> +maintainers:
> + - Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> +
> +properties:
> + compatible:
> + enum:
> + - nxp,w8987-bt
> + - nxp,w8997-bt
> + - nxp,w9098-bt
> + - nxp,iw416-bt
> + - nxp,iw612-bt
Why "bt" suffix? Are these chips coming with other functions?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-31 19:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 18:05 [PATCH v2 0/3] Add support for NXP bluetooth chipsets Neeraj Sanjay Kale
2023-01-30 18:05 ` [PATCH v2 1/3] serdev: Add method to assert break Neeraj Sanjay Kale
2023-01-31 8:57 ` Leon Romanovsky
2023-01-31 9:50 ` Greg KH
2023-01-30 18:05 ` [PATCH v2 2/3] dt-bindings: net: bluetooth: Add NXP bluetooth support Neeraj Sanjay Kale
2023-01-31 1:52 ` Rob Herring
2023-01-31 19:04 ` Krzysztof Kozlowski [this message]
2023-01-30 18:05 ` [PATCH v2 3/3] Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets Neeraj Sanjay Kale
2023-01-30 21:10 ` Luiz Augusto von Dentz
2023-01-31 2:20 ` Rob Herring
2023-02-01 12:33 ` Neeraj sanjay kale
2023-01-31 9:01 ` Leon Romanovsky
2023-01-31 10:00 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a237ca0-15cd-b86c-7d9b-32014370d9dd@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alok.a.tiwari@oracle.com \
--cc=amitkumar.karwar@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=neeraj.sanjaykale@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rohit.fule@nxp.com \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).