From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A41C41513 for ; Mon, 14 Aug 2023 08:52:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232035AbjHNIwD (ORCPT ); Mon, 14 Aug 2023 04:52:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231950AbjHNIvc (ORCPT ); Mon, 14 Aug 2023 04:51:32 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54F2410B for ; Mon, 14 Aug 2023 01:51:31 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-991c786369cso544759766b.1 for ; Mon, 14 Aug 2023 01:51:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692003090; x=1692607890; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4gM6rcXv3qh9ZZg6fLTgga1lm0ti4rVMB4jfXIK5a0o=; b=O8NThQtXSHshTGb9RevvjrXxImoLpRFRZuWqmRD4DnBhEIdq9jbnJa483QrL7v3VZR 0uPAIYZJ+4At8VCcvjJlPZnoMYB5PauOJhlkocbdNmXhXCi8AlkS9dI0b2dE5D9puya3 01eIsFEk8zwHAGToXMqd/epwA6Byge7Sd0068EVlXh6VIf+7aCA4Mome2qx9Da7Zju/q 3ioUdEzvkxSDdhSDQiQIlwTTf/ckJJYCSbWHEnYREPcmmFDqam5KnlnbTBigKwOBfdwh 9NVEBDSLH2ff+15g4+86LSH/7ZU5vA3K9kFYplEdyFGU5IEE0a6t837g86xZ9igcGytH fKnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692003090; x=1692607890; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4gM6rcXv3qh9ZZg6fLTgga1lm0ti4rVMB4jfXIK5a0o=; b=gHR2DQPDqDpWndHu5eIijSsZ+Z2dabZKXdnNDLGVN0RHiW2DN2j30pjXkrCxmJ43tZ bgtV59pvuEsCRAEHXrA4wmocU2LcWBWutK/hKwI8jMsm2mjia7iSbQG9d7VThJmBKm+h k+OPWMhJVXEOkUN+r4lhfSax2ZuOKI4MEFUFkgdEDDIQ6u50Rzq7enuJvI874QgcR7dX IstfytXfeR2tVyWngNC7tZ+VK1d9SmTN7F6LyBMZRWArE1/IC5TKTVSl32eYP7y8YYPd vF+Kuh4KG2uESNJKMqyxocJuMPNeSgKeON3zCVtsmhqKkFGV9m86brqbLThVopzuymBJ 3S6Q== X-Gm-Message-State: AOJu0YwUdflkUIVFQjVYaq4eoCnutAmywEUXmE4b0gXYceT07FiCto4x 6U4ZREBxaF94YUcOAqoFnoutrT4lJ2QsStZXu5K6Ew== X-Google-Smtp-Source: AGHT+IG1MMAJeaupxrQM9SWatk4LMg3tfHwszdj17vADSwjQuyoDKKejrXrJ3BdLwwEG0VPLLlyh4w== X-Received: by 2002:a17:906:53:b0:98c:e72c:6b83 with SMTP id 19-20020a170906005300b0098ce72c6b83mr6828070ejg.45.1692003089777; Mon, 14 Aug 2023 01:51:29 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id l7-20020a1709060e0700b0099ccee57ac2sm5457845eji.194.2023.08.14.01.51.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Aug 2023 01:51:29 -0700 (PDT) Message-ID: <2a4751d4-2955-b4d7-f16b-7a3a90fbab3a@linaro.org> Date: Mon, 14 Aug 2023 10:51:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/2] dt-bindings: dma: hisi: Add bindings for Hisi Ascend sdma Content-Language: en-US To: Guo Mengqi , vkoul@kernel.org, dmaengine@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org Cc: xuqiang36@huawei.com References: <20230811034822.107229-1-guomengqi3@huawei.com> <20230811034822.107229-3-guomengqi3@huawei.com> From: Krzysztof Kozlowski In-Reply-To: <20230811034822.107229-3-guomengqi3@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/08/2023 05:48, Guo Mengqi wrote: > Add device-tree binding documentation for the Hisi Ascend sdma > controller. > > Signed-off-by: Guo Mengqi > --- > .../bindings/dma/hisi,ascend-sdma.yaml | 82 +++++++++++++++++++ > 1 file changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/hisi,ascend-sdma.yaml > > diff --git a/Documentation/devicetree/bindings/dma/hisi,ascend-sdma.yaml b/Documentation/devicetree/bindings/dma/hisi,ascend-sdma.yaml > new file mode 100644 > index 000000000000..beb2b3597f4d > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/hisi,ascend-sdma.yaml > @@ -0,0 +1,82 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/hisi,ascend-sdma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HISI Ascend System DMA (SDMA) controller > + > +description: | > + The Ascend SDMA controller is used for transferring data What is Ascend? SoC? Family? Model? > + in system memory. It utilizes IOMMU SVA feature and accepts > + virtual address from user process. > + > +maintainers: > + - Guo Mengqi > + > +allOf: > + - $ref: dma-controller.yaml# > + > +properties: > + compatible: > + const: hisilicon,sdma Way too generic compatible. It must be *model specific*. > + > + reg: > + maxItems: 1 > + > + '#dma-cells': > + const: 1 > + description: > + Clients specify a single cell with channel number. > + > + ascend_sdma_channel_map: Missing vendor prefix, no underscores in property names, missing type/$ref. I doubt this was ever tested. > + description: | > + bitmap, each bit stands for a channel that is allowed to > + use by this system. Maximum 32 bits. > + maximum: 0xffffffff > + > + ascend_sdma_channel_iomem_size: > + description: | > + depends on different platforms to be released. There are Ah, so compatible is not specific enough? No, please make compatibles specific and drop this property. > + currently two possible values. A default value is used if > + the property is not set. > + - enum: > + - 0x400 > + - 0x1000 > + > + iommus: > + maxItems: 1 > + > + pasid-num-bits: > + description: | > + sdma utilizes iommu sva feature to transfer user space data. > + It act as a basic dma controller if not bound to user space. > + const: 0x10 > + > + dma-coherent: true > + > + dma-can-stall: true > + > +required: > + - compatible > + - reg > + - ascend_sdma_channel_map > + - '#dma-cells' > + - iommus > + > +additionalProperties: false > + > +examples: > + - | > + sdma: dma-controller@880E0000 { Use lowercase hex and drop unused label. > + compatible = "hisilicon,sdma"; > + reg = <0x880e0000 0x10000>; Broken indentation. Best regards, Krzysztof