From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="qJEun988"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="kzomfXtM" Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF4141AB; Tue, 5 Dec 2023 05:37:15 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3B5CC5C0073; Tue, 5 Dec 2023 08:37:15 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 05 Dec 2023 08:37:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1701783435; x=1701869835; bh=MS o40/DzILPmk4fVztq26tP1UcAt4IZ5edthROYfIeQ=; b=qJEun988LPpJTneK4B iOm8MG4rNWEJ2M9ylmnOyL8l6IwefIw3g+/fCxBQAzyJ7hYdhL0/vWbPNpuzsUFh 3rJnLmNXViDWxshFEt8CsL6vb4PkVF+BORWHrbr3H58yGuLoV7d7VhDamFjpQhcT U/u+M5I1drvoNI3dxxKiGfFRUhtB2Ve3C1g31EZOupjooD8zk4+Mo+IjzVNeit2A xrIqpr9SYwC2iP4Gd4vV3r7M8WNNp6iK/T8nTedZd/kkRg34bxzcsBoYntKliqtf rWt81QWBmEKAovmrUW9mB6GfVJnBfIPPZu0EVRiRyoy+3Hv5hrUNpSjlpotMCzoZ Tfwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701783435; x=1701869835; bh=MSo40/DzILPmk 4fVztq26tP1UcAt4IZ5edthROYfIeQ=; b=kzomfXtMU0QNVW1G9ASuu30rLAGos brOM5jegxaM9w5e0E+Mx0NaBvK7yKRLW7QEFi70l9E13SQcdbmlVehN4FL8GG+v3 7RsF2zI2Nyv6dHAMGGHfT47Lx9dGZC/A9N679EkNRrcIR+iFfssYQHIRL1Npjkbk eBYMVft4X3MdNIlB9Zj8bhY3LknHONoh7BVL83Nvp2HHAnfut73c+YWszU2OV3K/ 6zMPitTGR7BZjpWbzVUNxULgkm1Gk00Wy3GqEXLYAsGzKmGbotT7+uN4YvG5UW9z iuXVOurc69aA6dcmz84gY6uMYS+XnL6znE2Xy2uInouwlGoH3ug5OPSsw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudejkedgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 2D405B60089; Tue, 5 Dec 2023 08:37:13 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <2a5ce0d0-ad0a-49d7-84a6-055c4b729eec@app.fastmail.com> In-Reply-To: References: Date: Tue, 05 Dec 2023 14:36:53 +0100 From: "Arnd Bergmann" To: "Yoshinori Sato" , linux-sh@vger.kernel.org Cc: "Damien Le Moal" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Geert Uytterhoeven" , "Michael Turquette" , "Stephen Boyd" , "Dave Airlie" , "Daniel Vetter" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Thomas Gleixner" , "Lorenzo Pieralisi" , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , "Bjorn Helgaas" , "Greg Kroah-Hartman" , "Jiri Slaby" , "Magnus Damm" , "Daniel Lezcano" , "Rich Felker" , "John Paul Adrian Glaubitz" , "Lee Jones" , "Helge Deller" , =?UTF-8?Q?Heiko_St=C3=BCbner?= , "Jernej Skrabec" , "Chris Morgan" , "Linus Walleij" , "Randy Dunlap" , "Hyeonggon Yoo" <42.hyeyoo@gmail.com>, "David Rientjes" , "Vlastimil Babka" , "Baoquan He" , "Andrew Morton" , "Guenter Roeck" , "Stephen Rothwell" , guoren , "Javier Martinez Canillas" , "Azeem Shaikh" , "Palmer Dabbelt" , "Bin Meng" , "Max Filippov" , "Tom Rix" , "Herve Codina" , "Jacky Huang" , "Lukas Bulwahn" , "Jonathan Corbet" , "Biju Das" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , "Sam Ravnborg" , "Michael Karcher" , "Sergey Shtylyov" , "Laurent Pinchart" , linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-Renesas , linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [DO NOT MERGE v5 22/37] dt-bindings: display: smi,sm501: SMI SM501 binding json-schema Content-Type: text/plain On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote: > Define SM501 functions and modes. > > Signed-off-by: Yoshinori Sato > --- > .../bindings/display/smi,sm501.yaml | 134 ++++++++++++++++++ > include/dt-bindings/display/sm501.h | 25 ++++ It looks like we already have a binding at Documentation/devicetree/bindings/display/sm501fb.txt > + little-endian: > + $ref: /schemas/types.yaml#/definitions/flag > + description: available on big endian systems, to set different > foreign endian. > + big-endian: > + $ref: /schemas/types.yaml#/definitions/flag > + description: available on little endian systems, to set different > foreign endian. > + > + swap-fb-endian: > + $ref: /schemas/types.yaml#/definitions/flag > + description: swap framebuffer byteorder. Why do you need both the "swap" and the specific little/big properties? > + crt: > + description: CRT output control > + > + panel: > + description: Panel output control What type are these? > + smi,misc-timing: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Miscellaneous Timing reg value. > + > + smi,misc-control: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Miscellaneous Control reg value. > + > + smi,gpio-low: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: GPIO0 to 31 Control reg value. > + > + smi,gpio-high: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: GPIO32 to 63 Control reg value. Register values should generally not go into DT > + > + smi,gpio-i2c: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 5 > + description: | > + GPIO I2C bus number > + 1st field - I2C bus number > + 2nd Field - GPIO SDA > + 3rd Field - GPIO SCL > + 4th Field - Timeout > + 5th Field - udelay Instead of a bus number and other fields, I think this should reference an i2c device. Arnd