From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 938A2C77B7D for ; Thu, 11 May 2023 02:06:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbjEKCGa (ORCPT ); Wed, 10 May 2023 22:06:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230004AbjEKCG3 (ORCPT ); Wed, 10 May 2023 22:06:29 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66723173B; Wed, 10 May 2023 19:06:28 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id DDE0E24E0FC; Thu, 11 May 2023 10:06:25 +0800 (CST) Received: from EXMBX062.cuchost.com (172.16.6.62) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 11 May 2023 10:06:25 +0800 Received: from [192.168.125.107] (113.72.146.187) by EXMBX062.cuchost.com (172.16.6.62) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 11 May 2023 10:06:25 +0800 Message-ID: <2a6add59-981a-f5c1-e744-1cef2b81f29a@starfivetech.com> Date: Thu, 11 May 2023 10:06:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 1/5] dt-bindings: power: Add JH7110 AON PMU support Content-Language: en-US To: Conor Dooley CC: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , , , References: <20230510015311.27505-1-changhuang.liang@starfivetech.com> <20230510015311.27505-2-changhuang.liang@starfivetech.com> <20230510-cloning-clapping-e262f00a94e8@wendy> <20230510-city-scarf-023705d3c96a@spud> From: Changhuang Liang In-Reply-To: <20230510-city-scarf-023705d3c96a@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.146.187] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX062.cuchost.com (172.16.6.62) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/5/11 3:51, Conor Dooley wrote: > On Wed, May 10, 2023 at 03:20:14PM +0800, Changhuang Liang wrote: >> On 2023/5/10 15:06, Conor Dooley wrote: >>> On Tue, May 09, 2023 at 06:53:07PM -0700, Changhuang Liang wrote: >>>> + - starfive,jh7110-pmu >>>> + - items: >>>> + - enum: >>>> + - starfive,jh7110-aon-syscon >>>> + - const: syscon >>> >>> Unfortunately, this is not what was wanted. >>> This syscon, of which power domain control is just one of the things that >>> it can do, should be documented in >>> Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml >>> alongside it's brethern "starfive,jh7110-sys-syscon" & >>> "starfive,jh7110-stg-syscon". >>> >> >> That means that I don't need to modify this original yaml file? > > Does "this original" mean starfive,jh7100-pmu.yaml? > If so then... > Yes. >> I just need to move current changes in this patch into >> "Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml"? > > Correct. > It makes most sense for that binding, as it depends on the pll binding > (because it has a ref: to it), to go through the clock tree in Xingyu's > series. > I'll apply the driver changes once the binding has been applied. > I think that I have to send v4 after Xingyu's series resend new version. If drivers have no other comments. I will make the following changes: patch 1/5: Only keep the content in starfive,jh7110-pmu.h, move other content into Xingyu's PLL series. patch 5/5: Drop this patch, move the content into Xingyu's PLL series. other patch: no change. Thanks, Changhuang