From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF1CFC43332 for ; Mon, 21 Dec 2020 09:50:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B965022BF3 for ; Mon, 21 Dec 2020 09:50:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727522AbgLUJtb (ORCPT ); Mon, 21 Dec 2020 04:49:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:39322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbgLUJt2 (ORCPT ); Mon, 21 Dec 2020 04:49:28 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A28722CB2; Mon, 21 Dec 2020 09:30:48 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1krHWf-002pqk-T4; Mon, 21 Dec 2020 09:30:45 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 21 Dec 2020 09:30:45 +0000 From: Marc Zyngier To: Saravana Kannan Cc: Greg Kroah-Hartman , Rob Herring , Frank Rowand , Kevin Hilman , kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] of: property: Add device link support for interrupts In-Reply-To: <20201218210750.3455872-1-saravanak@google.com> References: <20201218210750.3455872-1-saravanak@google.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <2a6dbcc83d5aca7a3340e0cf4d751cdc@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: saravanak@google.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, frowand.list@gmail.com, khilman@baylibre.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020-12-18 21:07, Saravana Kannan wrote: > Add support for creating device links out of interrupts property. > > Cc: Marc Zyngier > Cc: Kevin Hilman > Signed-off-by: Saravana Kannan > --- > Rob/Greg, > > This might need to go into driver-core to avoid conflict > due to fw_devlink refactor series that merged there. > > Thanks, > Saravana > > > drivers/of/property.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/of/property.c b/drivers/of/property.c > index 5f9eed79a8aa..e56a5eae0a0b 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -1271,6 +1271,22 @@ static struct device_node > *parse_iommu_maps(struct device_node *np, > return of_parse_phandle(np, prop_name, (index * 4) + 1); > } > > +static struct device_node *parse_interrupts(struct device_node *np, > + const char *prop_name, int index) > +{ > + struct device_node *sup; > + > + if (strcmp(prop_name, "interrupts") || index) > + return NULL; > + > + of_node_get(np); > + while (np && !(sup = of_parse_phandle(np, "interrupt-parent", 0))) > + np = of_get_next_parent(np); > + of_node_put(np); > + > + return sup; > +} > + > static const struct supplier_bindings of_supplier_bindings[] = { > { .parse_prop = parse_clocks, }, > { .parse_prop = parse_interconnects, }, > @@ -1296,6 +1312,7 @@ static const struct supplier_bindings > of_supplier_bindings[] = { > { .parse_prop = parse_pinctrl6, }, > { .parse_prop = parse_pinctrl7, }, > { .parse_prop = parse_pinctrl8, }, > + { .parse_prop = parse_interrupts, }, > { .parse_prop = parse_regulators, }, > { .parse_prop = parse_gpio, }, > { .parse_prop = parse_gpios, }, You don't really describe what this is for so I'm only guessing from the context. If you want to follow the interrupt hierarchy, "interrupt-parent" isn't enough. You also need to track things like interrupt-map, or anything that carries a phandle to an interrupt controller. Thanks, M. -- Jazz is not dead. It just smells funny...