devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>,
	agross@kernel.org, bjorn.andersson@linaro.org,
	gregkh@linuxfoundation.org, robh+dt@kernel.org,
	krzk+dt@kernel.org
Cc: manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: dts: qcom: sdx65: Add interconnect nodes
Date: Tue, 12 Apr 2022 13:19:34 +0200	[thread overview]
Message-ID: <2a97d1d4-ece4-1725-6cf7-f50f6664f15e@linaro.org> (raw)
In-Reply-To: <1649761414-19217-2-git-send-email-quic_rohiagar@quicinc.com>

On 12/04/2022 13:03, Rohit Agarwal wrote:
> Add interconnect devicetree nodes in SDX65 platform.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---

>  			};
> +
> +			apps_bcm_voter: bcm_voter {

No underscores in node names. This will break upcoming schema.

> +				compatible = "qcom,bcm-voter";
> +			};
> +
>  		};
>  	};
>  


Best regards,
Krzysztof

  reply	other threads:[~2022-04-12 12:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 11:03 [PATCH 0/4] Devicetree updates for Interconnect, USB3 and PHY support Rohit Agarwal
2022-04-12 11:03 ` [PATCH 1/4] ARM: dts: qcom: sdx65: Add interconnect nodes Rohit Agarwal
2022-04-12 11:19   ` Krzysztof Kozlowski [this message]
2022-04-12 11:03 ` [PATCH 2/4] dt-bindings: usb: qcom,dwc3: Add binding for SDX65 Rohit Agarwal
2022-04-12 11:20   ` Krzysztof Kozlowski
2022-04-12 11:03 ` [PATCH 3/4] ARM: dts: qcom: sdx65: Add USB3 and PHY support Rohit Agarwal
2022-04-12 11:21   ` Krzysztof Kozlowski
2022-04-12 11:03 ` [PATCH 4/4] ARM: dts: qcom: sdx65-mtp: Enable " Rohit Agarwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a97d1d4-ece4-1725-6cf7-f50f6664f15e@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=quic_rohiagar@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).