From: "Faraz Ata" <faraz.ata@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>,
<alim.akhtar@samsung.com>, <dev.tailor@samsung.com>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <rosa.pila@samsung.com>,
<suyash.bitti@samsung.com>, <abhijeet.s23@samsung.com>
Subject: RE: [PATCH 2/2] arm64: dts: exynos: Add DT node for all UART ports
Date: Wed, 12 Mar 2025 13:37:57 +0530 [thread overview]
Message-ID: <2aa201db9325$e8ef6e00$bace4a00$@samsung.com> (raw)
In-Reply-To: <5b68a9c2-9145-4131-9fa3-10810c51691f@kernel.org>
Hello Krzysztof
> -----Original Message-----
> On 12/03/2025 07:19, Faraz Ata wrote:
> > Universal Serial Interface (USI) supports three serial protocol like
> > uart, i2c and spi. ExynosAutov920 has 18 instances of USI.
> > Add all the USI DT node and subsequent uart nodes for all the instances.
> >
> > Signed-off-by: Faraz Ata <faraz.ata@samsung.com>
> > ---
> > .../arm64/boot/dts/exynos/exynosautov920.dtsi | 494
> > ++++++++++++++++++
> > 1 file changed, 494 insertions(+)
>
>
> Please do not combine DTS changes with serial patches, ever. DTS has to go
> via separate tree.
>
Sure, while sending v2, I will send DT separately and serial driver change separately.
Thanks for your review.
> ...
>
.
.
.
> > +
> > +
>
> Just one blank line.
Sure will correct in v2.
>
> > pwm: pwm@109b0000 {
> > compatible = "samsung,exynosautov920-pwm",
> > "samsung,exynos4210-pwm";
>
>
> Best regards,
> Krzysztof
prev parent reply other threads:[~2025-03-12 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250312061053epcas5p3b33ffac4d9af89de5ef01d42f6157c47@epcas5p3.samsung.com>
2025-03-12 6:19 ` [PATCH 1/2] tty: serial: samsung_tty: update UART_NR for ExynosAutov920 Faraz Ata
[not found] ` <CGME20250312061058epcas5p3ccf293213fe883129358833572b17d92@epcas5p3.samsung.com>
2025-03-12 6:19 ` [PATCH 2/2] arm64: dts: exynos: Add DT node for all UART ports Faraz Ata
2025-03-12 7:42 ` Krzysztof Kozlowski
2025-03-12 8:07 ` Faraz Ata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='2aa201db9325$e8ef6e00$bace4a00$@samsung.com' \
--to=faraz.ata@samsung.com \
--cc=abhijeet.s23@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=dev.tailor@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosa.pila@samsung.com \
--cc=suyash.bitti@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).