From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rajendra Nayak <quic_rjendra@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Georgi Djakov <djakov@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Abel Vesa <abel.vesa@linaro.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] interconnect: qcom: x1e80100: Remove bogus per-RSC BCMs and nodes
Date: Thu, 4 Jan 2024 11:06:05 +0100 [thread overview]
Message-ID: <2aa360c6-3e8a-4454-8a1e-31ed285d7a68@linaro.org> (raw)
In-Reply-To: <4d4d5d3b-cdb2-484a-8297-4b8bb0817986@quicinc.com>
On 4.01.2024 10:59, Rajendra Nayak wrote:
>
>
> On 1/2/2024 11:59 PM, Konrad Dybcio wrote:
>> The downstream kernel has infrastructure for passing votes from different
>> interconnect nodes onto different RPMh RSCs. This neither implemented, not
>> is going to be implemented upstream (in favor of a different solution
>> using ICC tags through the same node).
>>
>> Unfortunately, as it happens, meaningless (in the upstream context) parts
>> of the vendor driver were copied, ending up causing havoc - since all
>> "per-RSC" (in quotes because they all point to the main APPS one) BCMs
>> defined within the driver overwrite the value in RPMh on every
>> aggregation.
>>
>> To both avoid keeping bogus code around and possibly introducing
>> impossible-to-track-down bugs (busses shutting down for no reason), get
>> rid of the duplicated BCMs and their associated ICC nodes.
>
> Thanks Konrad for catching this, I do see these nodes in other Qualcomm SoCs upstream (atleast sm8350/sm8450 and sm8550), perhaps they need to be cleaned up as well?
Yes, I cleaned up 8550 last week, I'll look into the rest.
Konrad
next prev parent reply other threads:[~2024-01-04 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 18:29 [PATCH 0/4] X Elite fixups Konrad Dybcio
2024-01-02 18:29 ` [PATCH 1/4] interconnect: qcom: x1e80100: Remove bogus per-RSC BCMs and nodes Konrad Dybcio
2024-01-04 9:59 ` Rajendra Nayak
2024-01-04 10:06 ` Konrad Dybcio [this message]
2024-01-02 18:29 ` [PATCH 2/4] dt-bindings: interconnect: Remove bogus interconnect nodes Konrad Dybcio
2024-01-02 21:00 ` Krzysztof Kozlowski
2024-01-02 18:29 ` [PATCH 3/4] arm64: dts: qcom: x1e80100: Add missing system-wide PSCI power domain Konrad Dybcio
2024-01-02 23:33 ` Abel Vesa
2024-01-02 18:29 ` [PATCH 4/4] arm64: dts: qcom: x1e80100: Flush RSC sleep & wake votes Konrad Dybcio
2024-01-02 23:34 ` Abel Vesa
2024-01-28 2:17 ` [PATCH 0/4] X Elite fixups Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2aa360c6-3e8a-4454-8a1e-31ed285d7a68@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).