Re: [PATCH 3/3] arch: arm64: dts: sm8650-hdk: add support for the Display Card overlay

[Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>]

Hi Neil,

On 2/23/24 10:52, Neil Armstrong wrote:
> With the SM8650-HDK, a Display Card kit can be connected to provide
> a VTDR6130 display with Goodix Berlin Touch controller.
> 
> In order to route the DSI lanes to the connector for the Display
> Card kit, a switch must be changed on the board.
> 
> The HDMI nodes are disabled since the DSI lanes are shared with
> the DSI to HDMI transceiver.
> 
> Add support for this card as an overlay and apply it it at
> build-time to the sm8650-hdk dtb.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---

<snip>

> +	mdp_vsync_active: mdp-vsync-active-state {
> +		pins = "gpio86";
> +		function = "mdp_vsync";
> +		drive-strength = <2>;
> +		bias-pull-down;
> +	};
> +
> +	mdp_vsync_suspend: mdp-vsync-suspend-state {
> +		pins = "gpio86";
> +		function = "mdp_vsync";
> +		drive-strength = <2>;
> +		bias-pull-down;
> +	};

If you have a single pin configuration for active and suspend states,
then likely you may have only one device tree node here.

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

I don't add my Tested-by tag, since I don't get a panel working on 6.8.0-rc6,
while in runtime MSM and DSI are enabled, the panel driver is not initialized:

   panel-visionox-vtdr6130 ae94000.dsi.0: Failed to initialize panel: -22

--
Best wishes,
Vladimir