From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6604FA3744 for ; Mon, 31 Oct 2022 21:14:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230226AbiJaVO0 (ORCPT ); Mon, 31 Oct 2022 17:14:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230262AbiJaVOZ (ORCPT ); Mon, 31 Oct 2022 17:14:25 -0400 Received: from m-r2.th.seeweb.it (m-r2.th.seeweb.it [IPv6:2001:4b7a:2000:18::171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D330F7A for ; Mon, 31 Oct 2022 14:14:23 -0700 (PDT) Received: from [192.168.1.101] (95.49.29.156.neoplus.adsl.tpnet.pl [95.49.29.156]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 504773EAF0; Mon, 31 Oct 2022 22:14:21 +0100 (CET) Message-ID: <2aa7be3f-0b92-f280-d2c0-9283d8900b92@somainline.org> Date: Mon, 31 Oct 2022 22:14:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 07/10] arm64: dts: qcom: sm6350-lena: Provide power to SDHCI 2 (SDCard slot) Content-Language: en-US To: Marijn Suijten , phone-devel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Luca Weiss , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221030073232.22726-1-marijn.suijten@somainline.org> <20221030073232.22726-8-marijn.suijten@somainline.org> From: Konrad Dybcio In-Reply-To: <20221030073232.22726-8-marijn.suijten@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30.10.2022 08:32, Marijn Suijten wrote: > Without power the SDCard slot / hardware remains dormant. > > Like many other platforms these regulators are used exclusively by > SDHCI, and have their maximum voltage decreased to what downstream sets > on the consumer side. Additionally the SDHCI driver supports setting a > load, for which the regulator definition is extended much the same. > > Signed-off-by: Marijn Suijten > --- Reviewed-by: Konrad Dybcio Konrad > .../dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > index 1aaa9612b061..5cb76026ef67 100644 > --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > @@ -219,8 +219,13 @@ pm6150l_l5: ldo5 { > > pm6150l_l6: ldo6 { > regulator-min-microvolt = <1700000>; > - regulator-max-microvolt = <3544000>; > + regulator-max-microvolt = <2950000>; > regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > + > }; > > pm6150l_l7: ldo7 { > @@ -237,8 +242,13 @@ pm6150l_l8: ldo8 { > > pm6150l_l9: ldo9 { > regulator-min-microvolt = <2700000>; > - regulator-max-microvolt = <3544000>; > + regulator-max-microvolt = <2960000>; > regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > + > }; > > pm6150l_l10: ldo10 { > @@ -300,6 +310,9 @@ sd-cd-pins { > &sdhc_2 { > status = "okay"; > > + vmmc-supply = <&pm6150l_l9>; > + vqmmc-supply = <&pm6150l_l6>; > + > cd-gpios = <&tlmm 94 GPIO_ACTIVE_HIGH>; > }; >