* [PATCH] dt-bindings: pwm: renesas: tpu: fix "compatible" prop description
@ 2018-09-21 20:45 Sergei Shtylyov
2018-09-22 18:59 ` Sergei Shtylyov
2018-09-24 15:32 ` Simon Horman
0 siblings, 2 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2018-09-21 20:45 UTC (permalink / raw)
To: Thierry Reding, Rob Herring, linux-pwm, devicetree
Cc: Mark Rutland, linux-renesas-soc
The "compatible" property description contradicts even the example given:
it only says that there must be a single value while the example has the
fallback value too -- which makes much more sense. Moreover, the generic
property value is misdocumented as being R-Car (and RZ/G1) specific...
Fixes: 382457e562bb ("pwm: renesas-tpu: Add DT support")
Fixes: 3ba111a01822 ("dt-bindings: pwm: renesas-tpu: Document r8a774[35] support")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
This patch is against Linus' repo -- the 'fixes' branch in Thierry Reding's
repo is very outdated...
Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: linux/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
===================================================================
--- linux.orig/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
+++ linux/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
@@ -2,13 +2,14 @@
Required Properties:
- - compatible: should be one of the following.
+ - compatible: must contain one or more of the following:
- "renesas,tpu-r8a73a4": for R8A73A4 (R-Mobile APE6) compatible PWM controller.
- "renesas,tpu-r8a7740": for R8A7740 (R-Mobile A1) compatible PWM controller.
- "renesas,tpu-r8a7743": for R8A7743 (RZ/G1M) compatible PWM controller.
- "renesas,tpu-r8a7745": for R8A7745 (RZ/G1E) compatible PWM controller.
- "renesas,tpu-r8a7790": for R8A7790 (R-Car H2) compatible PWM controller.
- - "renesas,tpu": for generic R-Car and RZ/G1 TPU PWM controller.
+ - "renesas,tpu": for the generic TPU PWM controller; this is a fallback for
+ the above .
- reg: Base address and length of each memory resource used by the PWM
controller hardware module.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: pwm: renesas: tpu: fix "compatible" prop description
2018-09-21 20:45 [PATCH] dt-bindings: pwm: renesas: tpu: fix "compatible" prop description Sergei Shtylyov
@ 2018-09-22 18:59 ` Sergei Shtylyov
2018-09-24 15:32 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2018-09-22 18:59 UTC (permalink / raw)
To: Thierry Reding, Rob Herring, linux-pwm, devicetree
Cc: Mark Rutland, linux-renesas-soc
Hello!
On 09/21/2018 11:45 PM, Sergei Shtylyov wrote:
> The "compatible" property description contradicts even the example given:
> it only says that there must be a single value while the example has the
> fallback value too -- which makes much more sense. Moreover, the generic
> property value is misdocumented as being R-Car (and RZ/G1) specific...
>
> Fixes: 382457e562bb ("pwm: renesas-tpu: Add DT support")
> Fixes: 3ba111a01822 ("dt-bindings: pwm: renesas-tpu: Document r8a774[35] support")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against Linus' repo -- the 'fixes' branch in Thierry Reding's
> repo is very outdated...
>
> Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Index: linux/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> ===================================================================
> --- linux.orig/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> +++ linux/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> @@ -2,13 +2,14 @@
>
> Required Properties:
>
> - - compatible: should be one of the following.
> + - compatible: must contain one or more of the following:
> - "renesas,tpu-r8a73a4": for R8A73A4 (R-Mobile APE6) compatible PWM controller.
> - "renesas,tpu-r8a7740": for R8A7740 (R-Mobile A1) compatible PWM controller.
> - "renesas,tpu-r8a7743": for R8A7743 (RZ/G1M) compatible PWM controller.
> - "renesas,tpu-r8a7745": for R8A7745 (RZ/G1E) compatible PWM controller.
> - "renesas,tpu-r8a7790": for R8A7790 (R-Car H2) compatible PWM controller.
> - - "renesas,tpu": for generic R-Car and RZ/G1 TPU PWM controller.
> + - "renesas,tpu": for the generic TPU PWM controller; this is a fallback for
> + the above .
Oops, forgot to refresh the patch. :-(
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: pwm: renesas: tpu: fix "compatible" prop description
2018-09-21 20:45 [PATCH] dt-bindings: pwm: renesas: tpu: fix "compatible" prop description Sergei Shtylyov
2018-09-22 18:59 ` Sergei Shtylyov
@ 2018-09-24 15:32 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2018-09-24 15:32 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Thierry Reding, Rob Herring, linux-pwm, devicetree, Mark Rutland,
linux-renesas-soc
On Fri, Sep 21, 2018 at 11:45:24PM +0300, Sergei Shtylyov wrote:
> The "compatible" property description contradicts even the example given:
> it only says that there must be a single value while the example has the
> fallback value too -- which makes much more sense. Moreover, the generic
> property value is misdocumented as being R-Car (and RZ/G1) specific...
>
> Fixes: 382457e562bb ("pwm: renesas-tpu: Add DT support")
> Fixes: 3ba111a01822 ("dt-bindings: pwm: renesas-tpu: Document r8a774[35] support")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against Linus' repo -- the 'fixes' branch in Thierry Reding's
> repo is very outdated...
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-24 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-21 20:45 [PATCH] dt-bindings: pwm: renesas: tpu: fix "compatible" prop description Sergei Shtylyov
2018-09-22 18:59 ` Sergei Shtylyov
2018-09-24 15:32 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).