From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frieder Schrempf <frieder@fris.de>,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>
Cc: Frieder Schrempf <frieder.schrempf@kontron.de>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Denys Drozdov <denys.drozdov@toradex.com>,
Fabio Estevam <festevam@denx.de>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Marek Vasut <marex@denx.de>,
Matthias Schiffer <matthias.schiffer@tq-group.com>,
Max Krummenacher <max.krummenacher@toradex.com>,
Rob Herring <robh@kernel.org>, Tim Harvey <tharvey@gateworks.com>
Subject: Re: [PATCH 1/4] dt-bindings: arm: fsl: imx6ul-kontron: Update bindings
Date: Tue, 9 Aug 2022 18:55:31 +0300 [thread overview]
Message-ID: <2ac37c3e-fcb1-2e48-bc7b-549d745be1d9@linaro.org> (raw)
In-Reply-To: <20220809152534.292034-2-frieder@fris.de>
On 09/08/2022 18:25, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> This updates the bindings in order to simplify the devicetree
> structure and to add names for the boards that follow the latest
> convention used by Kontron marketing.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
> .../devicetree/bindings/arm/fsl.yaml | 31 +++++++------------
> 1 file changed, 12 insertions(+), 19 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index ef524378d449..7c4c27d553ec 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -553,8 +553,7 @@ properties:
> - engicam,imx6ul-isiot # Engicam Is.IoT MX6UL eMMC/NAND Starter kit
> - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board
> - karo,imx6ul-tx6ul # Ka-Ro electronics TXUL-0010 Module
> - - kontron,imx6ul-n6310-som # Kontron N6310 SOM
> - - kontron,imx6ul-n6311-som # Kontron N6311 SOM
> + - kontron,imx6ul-n631x-som # Kontron SL i.MX6UL (N631X SOM)
Although board-level compatibles are not that important, yet still they
follow the same rules as other DT bindings: no wildcards for compatibles.
Therefore the change is not correct, in my opinion.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-09 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 15:25 [PATCH 0/4] ARM: dts: imx6ul-kontron: Improve devicetrees Frieder Schrempf
2022-08-09 15:25 ` [PATCH 1/4] dt-bindings: arm: fsl: imx6ul-kontron: Update bindings Frieder Schrempf
2022-08-09 15:55 ` Krzysztof Kozlowski [this message]
2022-08-09 16:34 ` Frieder Schrempf
2022-08-09 15:25 ` [PATCH 2/4] ARM: dts: imx6ul-kontron: Simplify devicetree structure Frieder Schrempf
2022-08-09 15:25 ` [PATCH 3/4] ARM: dts: imx6ul-kontron: Add imx6ull-kontron-n641x-s to Makefile Frieder Schrempf
2022-08-09 15:28 ` Frieder Schrempf
2022-08-09 15:25 ` [PATCH 4/4] ARM: dts: imx6ul-kontron: Adjust board and SoM model strings Frieder Schrempf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ac37c3e-fcb1-2e48-bc7b-549d745be1d9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=denys.drozdov@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=frieder.schrempf@kontron.de \
--cc=frieder@fris.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=matthias.schiffer@tq-group.com \
--cc=max.krummenacher@toradex.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).