From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABE051A7ADD for ; Fri, 20 Dec 2024 09:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734685984; cv=none; b=uCB/fl8GyG5F4fAbP8XgBJ2dlzfuu5U1xQxfPDGwFH2mwI/dn95HE48QmYaX33XrnpCTxNwfZV9UsIpK/fFoCig919XZH471MHKdDBAfbi3wwAgpfmMkF2HZMa5mQbum3GKTR0ESbfyLyMigT5Z4hECr2871xD2KTHO4a3yuC5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734685984; c=relaxed/simple; bh=P9Z1Xc2pr5eYKuUuGHIlR5bXUAv56e8luAeU9HCZNWM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UzXxqIvYRp62RIZU2JoP7HScO1W3H4Z+5lrm7cSCpUSgfCM1r4GzzGN9VnaktGR5ox6b0EOsCgwcEuRmE3f42Gkv1FCN4bLBxrkZeOORgTB3+c2oFsp2xU9EFFqmPXtkOghMeNRQGVAt/DzSISDFz6WAQ+z2hx7qbmxJBvxJ1XU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tOZ41-00023l-Cx; Fri, 20 Dec 2024 10:12:53 +0100 Message-ID: <2ae085fa-6f13-4eb7-88c1-e625309fc35e@pengutronix.de> Date: Fri, 20 Dec 2024 10:12:49 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/10] arm64: dts: imx8mp-skov: increase I2C clock frequency for RTC To: Frank Li Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Oleksij Rempel , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241219-skov-dt-updates-v1-0-38bf80dc22df@pengutronix.de> <20241219-skov-dt-updates-v1-10-38bf80dc22df@pengutronix.de> <30dbe486-7e36-426d-8fa4-3ecd83193a10@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Hello Frank, On 19.12.24 20:16, Frank Li wrote: > On Thu, Dec 19, 2024 at 06:51:35PM +0100, Ahmad Fatoum wrote: >> On 19.12.24 18:47, Frank Li wrote: >>> On Thu, Dec 19, 2024 at 08:25:34AM +0100, Ahmad Fatoum wrote: >>>> From: Oleksij Rempel >>>> >>>> The NXP PCF85063TP RTC we use is capable of up to 400 kHz of SCL clock >>>> frequency, so let's make use of this instead of the 100 kHz bus frequency >>>> we are currently using. >>> >>> Increase I2C frequency to 400khz from 100kHz because NXP PCF85063TP RTC >>> support it. >> >> Unlike your other suggestions, these is no information lost by rewriting >> the commit message as you suggest. I don't mind, but must admit it feels >> like bikeshedding. What is your concrete objection to my commit message? > > According to > https://docs.kernel.org/process/submitting-patches.html > > Describe your changes in imperative mood, e.g. “make xyzzy do frotz” > instead of “[This patch] makes xyzzy do frotz” or > “[I] changed xyzzy to do frotz”, as if you are giving orders to the > codebase to change its behaviour. I have to disagree with your interpretation. The imperative mood is primarily expected for commit message titles, but if you take a look at normal commit message _bodies_ that make it into the kernel, you'll find that a whole lot of them start off like I do: Describe the situation and then what's done about it. I personally find that this is often easier to follow than just having two imperatives back-to-back. I have just Cc'd you on an RFC patch to amend the documentation you linked to reflect this. I am happy to continue the discussion over there: https://lore.kernel.org/workflows/20241220-submitting-patches-imperative-v1-0-ee874c1859b3@pengutronix.de/T/#t Thanks, Ahmad > > Generally, avoid use > > "this patch ..." > "let's ...." > "we do ... for ... " > > Just simple said > > Do ... to ... > Do ... because ... > > Frank > >> >> Thanks, >> Ahmad >> >> >>> >>> Frank >>> >>>> >>>> Signed-off-by: Oleksij Rempel >>>> Signed-off-by: Ahmad Fatoum >>>> --- >>>> arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi >>>> index a683f46fcbab..ec7857db7bf0 100644 >>>> --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi >>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi >>>> @@ -333,7 +333,7 @@ reg_nvcc_sd2: LDO5 { >>>> }; >>>> >>>> &i2c3 { >>>> - clock-frequency = <100000>; >>>> + clock-frequency = <400000>; >>>> pinctrl-names = "default"; >>>> pinctrl-0 = <&pinctrl_i2c3>; >>>> status = "okay"; >>>> >>>> -- >>>> 2.39.5 >>>> >>> >> >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |