From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0612DC74A5B for ; Tue, 21 Mar 2023 10:33:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229694AbjCUKc6 (ORCPT ); Tue, 21 Mar 2023 06:32:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjCUKc5 (ORCPT ); Tue, 21 Mar 2023 06:32:57 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 647B626866 for ; Tue, 21 Mar 2023 03:32:26 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id w9so57729034edc.3 for ; Tue, 21 Mar 2023 03:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679394743; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aM4pMbd9h+3fIjUzyTPRMWqM3P8Ga6/igv7ENNsFFog=; b=EYxGPFIIMxiCXWI/mEd7m/ehNebVcC2dyioRpdXbL/OmnKz90GKfT1Unb3HDim+QHG FaMYLF6JjzSZtRqyYBBPZyG7BA3pSF4EKLnPwZf0tKRNrIoEE4UI0qng9tz71RYxezAM 4yUaLfDgzLi9aavAXPyLDeSIWfqUSNYhC3sGtt74weOp5gKdiDLnlSrKVA1b2x57ybtW I/Xl+IFpw5Ijihrj9Liyzd/ieeOuF4x9Pz12KA9JNxbmy7MeEkyqR7IEMW+q3ewAYNDQ oJpOb2BtanT970Ke56ROtHePygR1/0KkesMhUAyoIxZaRuZV3hfTSAQ66hNY0pGTolxE Axqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679394743; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aM4pMbd9h+3fIjUzyTPRMWqM3P8Ga6/igv7ENNsFFog=; b=t09j6qIn/D6i1DW1+eCRK+Ts9jyz3uncC6d6y0/8XHd6G6cxN3hqTgfU7c1fYAXs8H 21Id1Hbg+1LC82WuYcvKzVRbBNHiEbWkTEVwCoWHNQZAY0js8fZIH4REp1UOIwHjpD2L KOzao9pMvLY6MnnKEqIqWEXoL8RQPktl2zbUs1idGNK9R56iqg0eL8qMTWxZX8zOikwj F+ZFbHm7y6FRzN6zYJ9hCal3FpHuzf24ftS2rt+wcK7m1FdniBu7ogvWFUSD0FZLIANI 5hEU7acyWaUJBmc/yxP/U+KvtnXQMobemMkFFZ2eUJ9kI/EryGWycEMFLhVUzm7/Oksb oubg== X-Gm-Message-State: AO0yUKUTWmxqONJGtdwEYpfhGODEgvLEIXyz6XIROXjXxzq2Ue4mpwDC nn59+HVtas93dLhkR3oOwp37mQ== X-Google-Smtp-Source: AK7set/hfAAEy8OKfBMea9CyBR/XCE2LmXd/fOMAlwfdbQAwHsc+rxmMel4Tjo+wXxAliWG8CWwHvg== X-Received: by 2002:a17:906:7ccf:b0:8f4:809e:faee with SMTP id h15-20020a1709067ccf00b008f4809efaeemr11116908ejp.19.1679394742958; Tue, 21 Mar 2023 03:32:22 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:2142:d8da:5ae4:d817? ([2a02:810d:15c0:828:2142:d8da:5ae4:d817]) by smtp.gmail.com with ESMTPSA id lz24-20020a170906fb1800b009334309eda5sm3774000ejb.196.2023.03.21.03.32.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Mar 2023 03:32:22 -0700 (PDT) Message-ID: <2aeb47d6-0577-f8e4-6070-331af15b1f83@linaro.org> Date: Tue, 21 Mar 2023 11:32:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: Add TI TPS6594 PMIC Content-Language: en-US To: Julien Panis , Rob Herring Cc: lee@kernel.org, krzysztof.kozlowski+dt@linaro.org, corbet@lwn.net, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com, eric.auger@redhat.com, jgg@ziepe.ca, razor@blackwall.org, stephen@networkplumber.org, davem@davemloft.net, christian.koenig@amd.com, contact@emersion.fr, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, sterzik@ti.com, u-kumar1@ti.com, eblanc@baylibre.com, jneanne@baylibre.com References: <20230315110736.35506-1-jpanis@baylibre.com> <20230315110736.35506-2-jpanis@baylibre.com> <20230320155354.GB1733616-robh@kernel.org> <04914464-2bc2-9d86-e9e2-8a716b929f28@baylibre.com> <2dcfd9dc-6c43-20b7-e27b-8ec2883be237@linaro.org> <887d5e71-334c-b206-08e6-2cc822df9eda@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <887d5e71-334c-b206-08e6-2cc822df9eda@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/03/2023 10:03, Julien Panis wrote: > > > On 3/21/23 08:36, Krzysztof Kozlowski wrote: >> On 20/03/2023 17:35, Julien Panis wrote: >>> >>> On 3/20/23 16:53, Rob Herring wrote: >>>> On Wed, Mar 15, 2023 at 12:07:33PM +0100, Julien Panis wrote: >>>>> TPS6594 is a Power Management IC which provides regulators and others >>>>> features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and >>>>> PFSM (Pre-configurable Finite State Machine) managing the state of the >>>>> device. >>>>> TPS6594 is the super-set device while TPS6593 and LP8764X are derivatives. >>>> As mentioned, the binding needs to be complete. It's missing GPIO at >>>> least. RTC and watchdog may or may not need binding changes. >>> Thank you for your feedback. >>> >>> About GPIO, do you speak about 'gpio-controller' >>> and/or '#gpio-cells' properties ? >> Yes. >> >>> For RTC (and for watchdog, once the driver will be >>> implemented), our driver do not require any node >>> to work. What could make an explicit instantiation >>> necessary in DT ? >> Properties from RTC schema, e.g. start-year, wakeup etc. > > TPS6594 RTC driver is being reviewed (this is another patch > series, not merged yet). These properties are not used by our > driver, that's why we did not have to add some RTC node in > the DT (until now, using such properties in our driver was not > requested by RTC sub-system maintainers). Bindings should be complete, regardless whether you now need this in driver or not. Does your comment mean that you will never need these, because hardware does not support them, and never going to add? Otherwise I don't get why you refer to driver when we talk about bindings... Best regards, Krzysztof