From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Mark Jackson" <mpfj@newflow.co.uk>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] ARM: dts: nanobone: Enable I2C temperature sensor
Date: Wed, 9 Nov 2022 17:23:22 +0100 [thread overview]
Message-ID: <2af9a47e-acc4-d2f1-8fc9-281385d18d51@linaro.org> (raw)
In-Reply-To: <20221109160904.183147-4-mpfj@newflow.co.uk>
On 09/11/2022 17:09, Mark Jackson wrote:
> The NanoBone platform supports a temperature sensor on the I2C bus.
>
> Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
> ---
> arch/arm/boot/dts/am335x-nano.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
> index cecc2afaeff4..2be831927af6 100644
> --- a/arch/arm/boot/dts/am335x-nano.dts
> +++ b/arch/arm/boot/dts/am335x-nano.dts
> @@ -212,6 +212,11 @@ &uart5 {
> status = "okay";
> };
>
> +temperature-sensor@48 {
> + compatible = "lm75";
> + reg = <0x48>;
> +};
This should not work - you put the node in some random place.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-09 16:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 16:08 [PATCH 0/5] ARM: dts: nanobone: Fix missing/incorrect features Mark Jackson
2022-11-09 16:09 ` [PATCH 1/5] ARM: dts: nanobone: Fix GPIO settings for RTS/CTS pins on UART3 & 4 Mark Jackson
2022-11-09 16:22 ` Krzysztof Kozlowski
2022-11-09 16:57 ` Mark Jackson
2022-11-09 16:58 ` Krzysztof Kozlowski
2022-11-09 17:03 ` Mark Jackson
2022-11-09 16:09 ` [PATCH 2/5] ARM: dts: nanobone: Enable RS485 mode for " Mark Jackson
2022-11-09 16:09 ` [PATCH 3/5] ARM: dts: nanobone: Enable I2C temperature sensor Mark Jackson
2022-11-09 16:23 ` Krzysztof Kozlowski [this message]
2022-11-09 16:45 ` Mark Jackson
2022-11-11 18:23 ` kernel test robot
2022-11-09 16:09 ` [PATCH 4/5] ARM: dts: nanobone: Fix GPIO settings for MMC pins Mark Jackson
2022-11-09 16:09 ` [PATCH 5/5] ARM: dts: nanobone: Enable USB host Mark Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2af9a47e-acc4-d2f1-8fc9-281385d18d51@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mpfj@newflow.co.uk \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).