From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0630BC76196 for ; Tue, 28 Mar 2023 15:35:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230093AbjC1PfT (ORCPT ); Tue, 28 Mar 2023 11:35:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232868AbjC1PfQ (ORCPT ); Tue, 28 Mar 2023 11:35:16 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E3CFB3 for ; Tue, 28 Mar 2023 08:35:13 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id c9so5931314lfb.1 for ; Tue, 28 Mar 2023 08:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680017711; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3N8h1DChvaLnm2TUkq7RCFOUn72LEkPBuvQVgji2prc=; b=MWTvY67pF8MEgiGs0jD2F1Vba+LhJPWz/XGiFuofZNJLlEA3NardYys19LQAJ2Nutk m0Fo1FrI6Hi+fJuGrEHQ+pTH1mPbkH11n2Poeu7kSgO6C1LbRjccfRcMXT61KZUorXQe AmuQnfQHrzT2QoYg91RCtwoqwkCgFVd3st/0qc28pr8D04tbsuDjbWUFdABzBDZFoJ0p k4x21jaRhb7KwdYmVywi5vlO/jlQgqOGHQiJzsSwCkOYO10V3g1/BRKivvz0L52A7gM1 zJSYmHOo+yIicNDz6RQFY1UmNKvO71ygggA9+Aj8sGVBFeyY6guMH8GWq3Ba3KTpnHi2 E6RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680017711; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3N8h1DChvaLnm2TUkq7RCFOUn72LEkPBuvQVgji2prc=; b=KBzvZbgF/AU7CNOvgavj5Qp/ObZu0H2sSvF2inM7l6KmlwMWMDMLuK8yAV1MeR2uns Bagfa+9PbMKK73bWzxGIFjV3FNpvpzE23qwZPTItW+SzHcr6AUKIgSiMTwzsxzZqvsfB wd6/ccGb+0Nv4YIzOtw5BnvfATmus8sZ8l47bB0NNrcm7ZWNw6wGWVvp8KHHMlf9V1B8 d+JY3z/nNnLQOk9RZ0oofynKV28jM5C2zixl97n9nd2cwdHknItl5Pi3Gvu7OghPMn7k +NMEhT13C+C1Aa0PZFuXcHMsq0ihQqW7gh6nA04gOf6f2cM7pf6jRmQJfKlYsJ1UVsY7 C4Ow== X-Gm-Message-State: AAQBX9e9XMLj4w6U2AzqDNBmwTGmZOpgGRrDMBBEpJuVCyIWSKbKdVgu aLiUr4MmuGgbQozmJ8aQbfLkGg== X-Google-Smtp-Source: AKy350aVn3vQwYsmxvtq+7/O1t34Z5xIpUuSNYCnORBUR752Ec2avam/4Q48gjVlzD+IBjLDYgwZ7w== X-Received: by 2002:ac2:51a1:0:b0:4df:830d:4a3a with SMTP id f1-20020ac251a1000000b004df830d4a3amr5009867lfk.23.1680017711678; Tue, 28 Mar 2023 08:35:11 -0700 (PDT) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id m10-20020ac2428a000000b004b6f00832cesm5086017lfh.166.2023.03.28.08.35.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Mar 2023 08:35:11 -0700 (PDT) Message-ID: <2b0506b7-1a3a-b45a-8514-42066231d2ea@linaro.org> Date: Tue, 28 Mar 2023 18:35:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v4 06/14] drm/msm/a6xx: Remove both GBIF and RBBM GBIF halt on hw init Content-Language: en-GB To: Konrad Dybcio , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Clark , Marijn Suijten References: <20230223-topic-gmuwrapper-v4-0-e987eb79d03f@linaro.org> <20230223-topic-gmuwrapper-v4-6-e987eb79d03f@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20230223-topic-gmuwrapper-v4-6-e987eb79d03f@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/03/2023 17:28, Konrad Dybcio wrote: > Currently we're only deasserting REG_A6XX_RBBM_GBIF_HALT, but we also > need REG_A6XX_GBIF_HALT to be set to 0. For GMU-equipped GPUs this is > done in a6xx_bus_clear_pending_transactions(), but for the GMU-less > ones we have to do it *somewhere*. Unhalting both side by side sounds > like a good plan and it won't cause any issues if it's unnecessary. > > Also, add a memory barrier to ensure it's gone through. > > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry