From: Krzysztof Kozlowski <krzk@kernel.org>
To: Finley Xiao <finley.xiao@rock-chips.com>, heiko@sntech.de
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
ulf.hansson@linaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, zhangqing@rock-chips.com,
sugar.zhang@rock-chips.com, huangtao@rock-chips.com
Subject: Re: [PATCH v1 1/2] dt-bindings: power: rockchip: Add support for RV1126B
Date: Fri, 17 Oct 2025 11:01:25 +0200 [thread overview]
Message-ID: <2b0a60de-060f-47b5-9268-cb1e3f360e12@kernel.org> (raw)
In-Reply-To: <494b724d-31e3-45f1-9cc2-ac64851a6f70@rock-chips.com>
On 17/10/2025 10:51, Finley Xiao wrote:
>>>
>>> clocks:
>>> minItems: 1
>>> diff --git a/include/dt-bindings/power/rockchip,rv1126b-power.h b/include/dt-bindings/power/rockchip,rv1126b-power.h
>>> new file mode 100644
>>> index 000000000000..0a418f16e4ea
>>> --- /dev/null
>>> +++ b/include/dt-bindings/power/rockchip,rv1126b-power.h
>> Use rather filename matching compatible fully.
>
> Should the file be renamed to "rockchip,rv1126b-power-controller.h"?
Yes, usually naming follows compatible, unless there are reasons not to,
like file for multiple compatibles.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-17 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 13:41 [PATCH v1 0/2] Add power-controller support for RV1126B Finley Xiao
2025-10-16 13:41 ` [PATCH v1 1/2] dt-bindings: power: rockchip: Add " Finley Xiao
2025-10-16 16:06 ` Heiko Stübner
2025-10-16 17:27 ` Krzysztof Kozlowski
[not found] ` <494b724d-31e3-45f1-9cc2-ac64851a6f70@rock-chips.com>
2025-10-17 9:01 ` Krzysztof Kozlowski [this message]
2025-10-16 13:41 ` [PATCH v1 2/2] pmdomain: " Finley Xiao
2025-10-16 16:13 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b0a60de-060f-47b5-9268-cb1e3f360e12@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=finley.xiao@rock-chips.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=sugar.zhang@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).