* [PATCH v1 0/2] Add power-controller support for RV1126B @ 2025-10-16 13:41 Finley Xiao 2025-10-16 13:41 ` [PATCH v1 1/2] dt-bindings: power: rockchip: Add " Finley Xiao 2025-10-16 13:41 ` [PATCH v1 2/2] pmdomain: " Finley Xiao 0 siblings, 2 replies; 7+ messages in thread From: Finley Xiao @ 2025-10-16 13:41 UTC (permalink / raw) To: heiko Cc: robh, krzk+dt, conor+dt, ulf.hansson, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, linux-pm, finley.xiao, zhangqing, sugar.zhang, huangtao Add support for the power domain controller on the RV1126B SoC. Finley Xiao (2): dt-bindings: power: rockchip: Add support for RV1126B pmdomain: rockchip: Add support for RV1126B .../power/rockchip,power-controller.yaml | 2 + drivers/pmdomain/rockchip/pm-domains.c | 41 +++++++++++++++++++ .../power/rockchip,rv1126b-power.h | 17 ++++++++ 3 files changed, 60 insertions(+) create mode 100644 include/dt-bindings/power/rockchip,rv1126b-power.h -- 2.43.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 1/2] dt-bindings: power: rockchip: Add support for RV1126B 2025-10-16 13:41 [PATCH v1 0/2] Add power-controller support for RV1126B Finley Xiao @ 2025-10-16 13:41 ` Finley Xiao 2025-10-16 16:06 ` Heiko Stübner 2025-10-16 17:27 ` Krzysztof Kozlowski 2025-10-16 13:41 ` [PATCH v1 2/2] pmdomain: " Finley Xiao 1 sibling, 2 replies; 7+ messages in thread From: Finley Xiao @ 2025-10-16 13:41 UTC (permalink / raw) To: heiko Cc: robh, krzk+dt, conor+dt, ulf.hansson, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, linux-pm, finley.xiao, zhangqing, sugar.zhang, huangtao Add the compatible string and power domain IDs for RV1126B SoC. signed-off-by: Finley Xiao <finley.xiao@rock-chips.com> --- .../power/rockchip,power-controller.yaml | 2 ++ .../dt-bindings/power/rockchip,rv1126b-power.h | 17 +++++++++++++++++ 2 files changed, 19 insertions(+) create mode 100644 include/dt-bindings/power/rockchip,rv1126b-power.h diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml index a884e49c995f..f9db602de258 100644 --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml @@ -46,6 +46,7 @@ properties: - rockchip,rk3576-power-controller - rockchip,rk3588-power-controller - rockchip,rv1126-power-controller + - rockchip,rv1126b-power-controller "#power-domain-cells": const: 1 @@ -126,6 +127,7 @@ $defs: "include/dt-bindings/power/rk3568-power.h" "include/dt-bindings/power/rk3588-power.h" "include/dt-bindings/power/rockchip,rv1126-power.h" + "include/dt-bindings/power/rockchip,rv1126b-power.h" clocks: minItems: 1 diff --git a/include/dt-bindings/power/rockchip,rv1126b-power.h b/include/dt-bindings/power/rockchip,rv1126b-power.h new file mode 100644 index 000000000000..0a418f16e4ea --- /dev/null +++ b/include/dt-bindings/power/rockchip,rv1126b-power.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ +/* + * Copyright (c) 2024 Rockchip Electronics Co., Ltd. + * Author: Finley Xiao <finley.xiao@rock-chips.com> + */ + +#ifndef __DT_BINDINGS_POWER_RV1126B_POWER_H__ +#define __DT_BINDINGS_POWER_RV1126B_POWER_H__ + +/* VD_NPU */ +#define RV1126B_PD_NPU 0 + +/* VD_LOGIC */ +#define RV1126B_PD_VDO 1 +#define RV1126B_PD_AISP 2 + +#endif -- 2.43.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: power: rockchip: Add support for RV1126B 2025-10-16 13:41 ` [PATCH v1 1/2] dt-bindings: power: rockchip: Add " Finley Xiao @ 2025-10-16 16:06 ` Heiko Stübner 2025-10-16 17:27 ` Krzysztof Kozlowski 1 sibling, 0 replies; 7+ messages in thread From: Heiko Stübner @ 2025-10-16 16:06 UTC (permalink / raw) To: Finley Xiao Cc: robh, krzk+dt, conor+dt, ulf.hansson, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, linux-pm, finley.xiao, zhangqing, sugar.zhang, huangtao Hi Finley, Am Donnerstag, 16. Oktober 2025, 15:41:02 Mitteleuropäische Sommerzeit schrieb Finley Xiao: > Add the compatible string and power domain IDs for RV1126B SoC. > > signed-off-by: Finley Xiao <finley.xiao@rock-chips.com> > --- [...] > diff --git a/include/dt-bindings/power/rockchip,rv1126b-power.h b/include/dt-bindings/power/rockchip,rv1126b-power.h > new file mode 100644 > index 000000000000..0a418f16e4ea > --- /dev/null > +++ b/include/dt-bindings/power/rockchip,rv1126b-power.h > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > +/* > + * Copyright (c) 2024 Rockchip Electronics Co., Ltd. > + * Author: Finley Xiao <finley.xiao@rock-chips.com> > + */ > + > +#ifndef __DT_BINDINGS_POWER_RV1126B_POWER_H__ > +#define __DT_BINDINGS_POWER_RV1126B_POWER_H__ > + > +/* VD_NPU */ > +#define RV1126B_PD_NPU 0 > + > +/* VD_LOGIC */ > +#define RV1126B_PD_VDO 1 > +#define RV1126B_PD_AISP 2 is this missing a 2nd "i" ? ... The TRM calls this aiisp (for ai-isp maybe?) Heiko ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: power: rockchip: Add support for RV1126B 2025-10-16 13:41 ` [PATCH v1 1/2] dt-bindings: power: rockchip: Add " Finley Xiao 2025-10-16 16:06 ` Heiko Stübner @ 2025-10-16 17:27 ` Krzysztof Kozlowski [not found] ` <494b724d-31e3-45f1-9cc2-ac64851a6f70@rock-chips.com> 1 sibling, 1 reply; 7+ messages in thread From: Krzysztof Kozlowski @ 2025-10-16 17:27 UTC (permalink / raw) To: Finley Xiao, heiko Cc: robh, krzk+dt, conor+dt, ulf.hansson, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, linux-pm, zhangqing, sugar.zhang, huangtao On 16/10/2025 15:41, Finley Xiao wrote: > Add the compatible string and power domain IDs for RV1126B SoC. And it is not compatible with RV1126 because? > > signed-off-by: Finley Xiao <finley.xiao@rock-chips.com> > --- > .../power/rockchip,power-controller.yaml | 2 ++ > .../dt-bindings/power/rockchip,rv1126b-power.h | 17 +++++++++++++++++ > 2 files changed, 19 insertions(+) > create mode 100644 include/dt-bindings/power/rockchip,rv1126b-power.h > > diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml > index a884e49c995f..f9db602de258 100644 > --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml > +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml > @@ -46,6 +46,7 @@ properties: > - rockchip,rk3576-power-controller > - rockchip,rk3588-power-controller > - rockchip,rv1126-power-controller > + - rockchip,rv1126b-power-controller > > "#power-domain-cells": > const: 1 > @@ -126,6 +127,7 @@ $defs: > "include/dt-bindings/power/rk3568-power.h" > "include/dt-bindings/power/rk3588-power.h" > "include/dt-bindings/power/rockchip,rv1126-power.h" > + "include/dt-bindings/power/rockchip,rv1126b-power.h" > > clocks: > minItems: 1 > diff --git a/include/dt-bindings/power/rockchip,rv1126b-power.h b/include/dt-bindings/power/rockchip,rv1126b-power.h > new file mode 100644 > index 000000000000..0a418f16e4ea > --- /dev/null > +++ b/include/dt-bindings/power/rockchip,rv1126b-power.h Use rather filename matching compatible fully. > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ Odd license. Please use recommended licenses. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <494b724d-31e3-45f1-9cc2-ac64851a6f70@rock-chips.com>]
* Re: [PATCH v1 1/2] dt-bindings: power: rockchip: Add support for RV1126B [not found] ` <494b724d-31e3-45f1-9cc2-ac64851a6f70@rock-chips.com> @ 2025-10-17 9:01 ` Krzysztof Kozlowski 0 siblings, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2025-10-17 9:01 UTC (permalink / raw) To: Finley Xiao, heiko Cc: robh, krzk+dt, conor+dt, ulf.hansson, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, linux-pm, zhangqing, sugar.zhang, huangtao On 17/10/2025 10:51, Finley Xiao wrote: >>> >>> clocks: >>> minItems: 1 >>> diff --git a/include/dt-bindings/power/rockchip,rv1126b-power.h b/include/dt-bindings/power/rockchip,rv1126b-power.h >>> new file mode 100644 >>> index 000000000000..0a418f16e4ea >>> --- /dev/null >>> +++ b/include/dt-bindings/power/rockchip,rv1126b-power.h >> Use rather filename matching compatible fully. > > Should the file be renamed to "rockchip,rv1126b-power-controller.h"? Yes, usually naming follows compatible, unless there are reasons not to, like file for multiple compatibles. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 2/2] pmdomain: rockchip: Add support for RV1126B 2025-10-16 13:41 [PATCH v1 0/2] Add power-controller support for RV1126B Finley Xiao 2025-10-16 13:41 ` [PATCH v1 1/2] dt-bindings: power: rockchip: Add " Finley Xiao @ 2025-10-16 13:41 ` Finley Xiao 2025-10-16 16:13 ` Heiko Stübner 1 sibling, 1 reply; 7+ messages in thread From: Finley Xiao @ 2025-10-16 13:41 UTC (permalink / raw) To: heiko Cc: robh, krzk+dt, conor+dt, ulf.hansson, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, linux-pm, finley.xiao, zhangqing, sugar.zhang, huangtao Add configuration and power domains for RV1126 SoC. Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com> --- drivers/pmdomain/rockchip/pm-domains.c | 41 ++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c index 1955c6d453e4..49a01261d13d 100644 --- a/drivers/pmdomain/rockchip/pm-domains.c +++ b/drivers/pmdomain/rockchip/pm-domains.c @@ -25,6 +25,7 @@ #include <soc/rockchip/rockchip_sip.h> #include <dt-bindings/power/px30-power.h> #include <dt-bindings/power/rockchip,rv1126-power.h> +#include <dt-bindings/power/rockchip,rv1126b-power.h> #include <dt-bindings/power/rk3036-power.h> #include <dt-bindings/power/rk3066-power.h> #include <dt-bindings/power/rk3128-power.h> @@ -137,6 +138,20 @@ struct rockchip_pmu { .active_wakeup = wakeup, \ } +#define DOMAIN_M_G(_name, pwr, status, req, idle, ack, g_mask, wakeup, keepon) \ +{ \ + .name = _name, \ + .pwr_w_mask = (pwr) << 16, \ + .pwr_mask = (pwr), \ + .status_mask = (status), \ + .req_w_mask = (req) << 16, \ + .req_mask = (req), \ + .idle_mask = (idle), \ + .ack_mask = (ack), \ + .clk_ungate_mask = (g_mask), \ + .active_wakeup = wakeup, \ +} + #define DOMAIN_M_G_SD(_name, pwr, status, req, idle, ack, g_mask, mem, wakeup, keepon) \ { \ .name = _name, \ @@ -205,6 +220,9 @@ struct rockchip_pmu { #define DOMAIN_RV1126(name, pwr, req, idle, wakeup) \ DOMAIN_M(name, pwr, pwr, req, idle, idle, wakeup) +#define DOMAIN_RV1126B(name, pwr, req, wakeup) \ + DOMAIN_M_G(name, pwr, pwr, req, req, req, req, wakeup, true) + #define DOMAIN_RK3288(name, pwr, status, req, wakeup) \ DOMAIN(name, pwr, status, req, req, (req) << 16, wakeup) @@ -1104,6 +1122,13 @@ static const struct rockchip_domain_info rv1126_pm_domains[] = { [RV1126_PD_USB] = DOMAIN_RV1126("usb", BIT(9), BIT(15), BIT(15), false), }; +static const struct rockchip_domain_info rv1126b_pm_domains[] = { + /* name pwr req wakeup */ + [RV1126B_PD_NPU] = DOMAIN_RV1126B("npu", BIT(0), BIT(8), false), + [RV1126B_PD_VDO] = DOMAIN_RV1126B("vdo", BIT(1), BIT(9), false), + [RV1126B_PD_AISP] = DOMAIN_RV1126B("aisp", BIT(2), BIT(10), false), +}; + static const struct rockchip_domain_info rk3036_pm_domains[] = { [RK3036_PD_MSCH] = DOMAIN_RK3036("msch", BIT(14), BIT(23), BIT(30), true), [RK3036_PD_CORE] = DOMAIN_RK3036("core", BIT(13), BIT(17), BIT(24), false), @@ -1516,6 +1541,18 @@ static const struct rockchip_pmu_info rv1126_pmu = { .domain_info = rv1126_pm_domains, }; +static const struct rockchip_pmu_info rv1126b_pmu = { + .pwr_offset = 0x210, + .status_offset = 0x230, + .req_offset = 0x110, + .idle_offset = 0x128, + .ack_offset = 0x120, + .clk_ungate_offset = 0x140, + + .num_domains = ARRAY_SIZE(rv1126b_pm_domains), + .domain_info = rv1126b_pm_domains, +}; + static const struct of_device_id rockchip_pm_domain_dt_match[] = { { .compatible = "rockchip,px30-power-controller", @@ -1585,6 +1622,10 @@ static const struct of_device_id rockchip_pm_domain_dt_match[] = { .compatible = "rockchip,rv1126-power-controller", .data = (void *)&rv1126_pmu, }, + { + .compatible = "rockchip,rv1126b-power-controller", + .data = (void *)&rv1126b_pmu, + }, { /* sentinel */ }, }; -- 2.43.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1 2/2] pmdomain: rockchip: Add support for RV1126B 2025-10-16 13:41 ` [PATCH v1 2/2] pmdomain: " Finley Xiao @ 2025-10-16 16:13 ` Heiko Stübner 0 siblings, 0 replies; 7+ messages in thread From: Heiko Stübner @ 2025-10-16 16:13 UTC (permalink / raw) To: Finley Xiao Cc: robh, krzk+dt, conor+dt, ulf.hansson, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, linux-pm, finley.xiao, zhangqing, sugar.zhang, huangtao Am Donnerstag, 16. Oktober 2025, 15:41:03 Mitteleuropäische Sommerzeit schrieb Finley Xiao: > Add configuration and power domains for RV1126 SoC. > > Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com> > --- [...] > @@ -1104,6 +1122,13 @@ static const struct rockchip_domain_info rv1126_pm_domains[] = { > [RV1126_PD_USB] = DOMAIN_RV1126("usb", BIT(9), BIT(15), BIT(15), false), > }; > > +static const struct rockchip_domain_info rv1126b_pm_domains[] = { > + /* name pwr req wakeup */ > + [RV1126B_PD_NPU] = DOMAIN_RV1126B("npu", BIT(0), BIT(8), false), > + [RV1126B_PD_VDO] = DOMAIN_RV1126B("vdo", BIT(1), BIT(9), false), > + [RV1126B_PD_AISP] = DOMAIN_RV1126B("aisp", BIT(2), BIT(10), false), > +}; > + same clarification needed as for patch 1 ... is it aiisp (with 2 "i")? As described everywhere in the TRM. Other than that I checked the bits and registers against the TRM, so Reviewed-by: Heiko Stuebner <heiko@sntech.de> Heiko ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-10-17 9:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-16 13:41 [PATCH v1 0/2] Add power-controller support for RV1126B Finley Xiao
2025-10-16 13:41 ` [PATCH v1 1/2] dt-bindings: power: rockchip: Add " Finley Xiao
2025-10-16 16:06 ` Heiko Stübner
2025-10-16 17:27 ` Krzysztof Kozlowski
[not found] ` <494b724d-31e3-45f1-9cc2-ac64851a6f70@rock-chips.com>
2025-10-17 9:01 ` Krzysztof Kozlowski
2025-10-16 13:41 ` [PATCH v1 2/2] pmdomain: " Finley Xiao
2025-10-16 16:13 ` Heiko Stübner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).