From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C9EEEB64DC for ; Mon, 26 Jun 2023 20:19:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229481AbjFZUS7 (ORCPT ); Mon, 26 Jun 2023 16:18:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230115AbjFZUSe (ORCPT ); Mon, 26 Jun 2023 16:18:34 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4141E54 for ; Mon, 26 Jun 2023 13:18:20 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4f866a3d8e4so5136399e87.0 for ; Mon, 26 Jun 2023 13:18:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687810699; x=1690402699; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GXjEfqWjSNnoy5GhK5+E3PAFQcJVxWndxMD1oYQAjkw=; b=fUUyuH/Gp2T5jQI/T7Y/Ui9PoTwGsjiJJnQ/BKfNFKW0/9Sn+W23FJd2TChdwyzNWk xRMnwIrVhChZyfliEpJB9J0YuU8EJkHeKrW3yv5IYSty7pXb75UmOtqXI/tmMgPBODmB TMlQetlqLcVjUeJ5Xi4ed3cNYXE5UXmFkt3fqc1KO/DPjvxTB56xARwwH3dNyKhG2aSn Rpfj2sbpyr0WXX76jC96rB7VkoNZkuC94UrNbSVkoWM0cAgSHAeOoly3jhtcCTtSK5a8 +VoZxIkzMZFA5X0Be2liBuyNO+iSd3HtSsa5T4FaxQVfVJ/phZbOZwrwGMRwTXW5y61/ ZbTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687810699; x=1690402699; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GXjEfqWjSNnoy5GhK5+E3PAFQcJVxWndxMD1oYQAjkw=; b=KLv2sihITFhbUx+Zqb1ZaqhIOMTxhWTq2B5PWjTMP/80gdlBLnQtO3/CJ2sdPLRcEZ OzaBM3PuvO6wCFqfe1KxpmonDSrzj3oAcRU4JkZMVlB1zS/YqfDBzQG3i8YzGOB9S4pZ iIMS4e+m8KyAsFhATLCwJNu0KVPx4CLrSzf3raI8l/YDn/wIXJIsv6RQWrJWuPFd6g7K XV/wXhZ8nx0je/wVN38qouWs+FBLVM0cAMuOPDCJXFGth24KxND9ap9DE2YybsJ4RWGA WWMn4D6bs1aKsJDGQKQHLkRr0QiDL7JHaJ7rG2RlI4xkIG+bwUxPlyY/BmpkcaW0i4d7 lZrw== X-Gm-Message-State: AC+VfDzHFOXYTI37HP3zzAVgcMh8IX/2kxIWbC31A3TC3D38zlsJWo7G iBhsZ0DPFJpoDnd9GkvF2jzVQg== X-Google-Smtp-Source: ACHHUZ4EEElP2/m42K4q0pHHIK4S8Q3rlG8J7bTTattHnlSY7jwFCYjgRYpZYEHrMvkooIooNzg6gw== X-Received: by 2002:a05:6512:3414:b0:4f9:cd02:4af1 with SMTP id i20-20020a056512341400b004f9cd024af1mr4297892lfr.34.1687810698953; Mon, 26 Jun 2023 13:18:18 -0700 (PDT) Received: from [192.168.1.101] (abyk179.neoplus.adsl.tpnet.pl. [83.9.30.179]) by smtp.gmail.com with ESMTPSA id k1-20020ac24561000000b004f86f98ede5sm1239369lfm.309.2023.06.26.13.18.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jun 2023 13:18:18 -0700 (PDT) Message-ID: <2b14f2a7-7f65-1b9d-06dc-92f0ea7fe096@linaro.org> Date: Mon, 26 Jun 2023 22:18:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt Content-Language: en-US To: Luca Weiss , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bhupesh Sharma , Dmitry Baryshkov , Mathieu Poirier , Sibi Sankar , Luca Weiss , AngeloGioacchino Del Regno , AngeloGioacchino Del Regno , Vinod Koul Cc: Marijn Suijten , Krzysztof Kozlowski , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Konrad Dybcio References: <20230626-topic-bindingsfixups-v1-0-254ae8642e69@linaro.org> <20230626-topic-bindingsfixups-v1-3-254ae8642e69@linaro.org> <2684880.mvXUDI8C0e@z3ntu.xyz> From: Konrad Dybcio In-Reply-To: <2684880.mvXUDI8C0e@z3ntu.xyz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26.06.2023 22:17, Luca Weiss wrote: > On Montag, 26. Juni 2023 22:00:25 CEST Konrad Dybcio wrote: >> Add the missing short interrupt. This fixes the schema warning: >> >> wled@d800: interrupt-names: ['ovp'] is too short >> >> Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node") >> Signed-off-by: Konrad Dybcio >> --- >> arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi >> b/arch/arm64/boot/dts/qcom/pm6150l.dtsi index 6a7fe1e59f15..d13a1ab7c20b >> 100644 >> --- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi >> +++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi >> @@ -121,8 +121,9 @@ pm6150l_flash: led-controller@d300 { >> pm6150l_wled: leds@d800 { >> compatible = "qcom,pm6150l-wled"; >> reg = <0xd800>, <0xd900>; >> - interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>; >> - interrupt-names = "ovp"; >> + interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>, >> + <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "ovp", "short"; > > Are you sure this interrupt really exists? It's not a thing used downstream at > least: > https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/pm6150l.dtsi#293 > Confirmed with a reliable source. Konrad > Regards > Luca > >> label = "backlight"; >> >> status = "disabled"; > > > >