From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0DE2370AFF; Sun, 12 Jul 2026 08:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783843884; cv=none; b=Cq4LWf5GLSZ4Jst+3Dc5wCdVniPSXki4W885+/aKZ600dGREw1ByOkrgzsXf+2QrLEZsIUhkPJTky7zz520l8KQm9TLS2Tz5MDRXBTwDuDTBevlE2TM7aA0P/qTUpuCeqNNWBVb8yXN0fxcnpwfMtGqY86uyLA/f3Pi2JgCBuvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783843884; c=relaxed/simple; bh=zY+AbxT5fzbK7LEJHunWHXa0lakDuUZSGGHQKQ3g+nE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HIRXWbIe49ZmuoO89aluxnOGo/hLRZ2GB03YzuoqOL2OifB+1C/8mAginTRgVfVWtmMFh7lkJ1Mq9Z4LT4xwu28nZeZZQU+cMrTDv9Hq7JtqAYpHV/N9WbgTh2A7+SMf9cjml/QzgF2Kv3XzoBzvX9Pm9lMKmt8+IrJ11WzDyL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HdZx1B4i; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HdZx1B4i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 977631F000E9; Sun, 12 Jul 2026 08:11:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783843882; bh=rrRI3lqFLmoI5ctmdrO17ZOE8gpJZQKJcT34DVAGaxQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=HdZx1B4i3EtU05GJJZsLGZ4V8f+tES1mtyhXIKblXLNqUt2k5gO4OZ4doNSuvyTlm bseaDQbwXRTTiWuyjhD9d5VkiHArDRfp/dd0oK1JV0NYgKfkyCLfKqPRz9APVfGpTl vFR9y2QDgNIBda9+gN7Z45LSs4+vf+/uFLG9ULY8C3M1wldxMq/r/s99yidWQYum4P 8FBqgLAj7dkHT0TGtPBgSYsEPVkndYaGjdVUJlURR9S6CxI2ktR2t/basgRcp9xSlH ZIiMcF06YOKOazRCIBy51P/JNk04JFayifDAXJCa4hOpfcqGWT24hkXORoBeil2L7e zIQLq8jJ1B+Sw== Message-ID: <2b4448d0-81f8-410f-b849-0d957a2d2a17@kernel.org> Date: Sun, 12 Jul 2026 10:11:13 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode To: Mohammad Rafi Shaik Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla , Krzysztof Kozlowski , Neil Armstrong References: <20260711125740.3083236-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260711125740.3083236-2-mohammad.rafi.shaik@oss.qualcomm.com> <20260711-mauve-skunk-of-contentment-f51be0@quoll> <6438237f-ccb4-4143-9ac7-43f5dcca955b@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <6438237f-ccb4-4143-9ac7-43f5dcca955b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/07/2026 08:44, Mohammad Rafi Shaik wrote: > > > On 7/11/2026 8:41 PM, Krzysztof Kozlowski wrote: >> On Sat, Jul 11, 2026 at 06:27:38PM +0530, Mohammad Rafi Shaik wrote: >>> Extend the qcom,q6apm-lpass-dais device tree binding to explicitly >>> describe Digital Audio Interface (DAI) child nodes. >>> >>> Add #address-cells and #size-cells to allow representation of multiple >>> DAI instances as child nodes, and define a dai@ pattern to document >>> per-DAI properties such as the interface ID and associated clocks. >>> >>> On platforms such as Monaco and Lemans, third-party codecs are hardware >>> wired to the SoC and do not always have an in-tree codec driver to manage >>> their clocks. For these designs, clock line enablement must be driven >>> from the platform side, and this series provides the necessary support >>> for that. >>> >>> On QAIF-based platforms such as Shikra and Hawi, responsibility for voting >>> I2S MCLK and BCLK has moved from the DSP to the kernel. This series >>> introduces the required device tree binding support to represent and >>> vote for these clocks from the kernel. >>> >>> Co-developed-by: Srinivas Kandagatla >>> Signed-off-by: Srinivas Kandagatla >>> Reviewed-by: Krzysztof Kozlowski >> >> Drop my tag, you made a important change to ABI. >> > > Ack > >>> Tested-by: Neil Armstrong >> >> Drop, you cannot test a binding (in the meaning of Tested-by tag). > > Ack, will drop Tested-by tag. > >> >>> Signed-off-by: Mohammad Rafi Shaik >>> --- >>> .../bindings/sound/qcom,q6apm-lpass-dais.yaml | 58 +++++++++++++++++++ >>> 1 file changed, 58 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >>> index 2fb95544db8b..f3a8b12d7fc8 100644 >>> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >>> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >>> @@ -21,6 +21,49 @@ properties: >>> '#sound-dai-cells': >>> const: 1 >>> >>> + '#address-cells': >>> + const: 1 >>> + >>> + '#size-cells': >>> + const: 0 >>> + >>> +# Digital Audio Interfaces >>> +patternProperties: >>> + '^dai@[0-9a-f]+$': >>> + type: object >>> + description: >>> + Q6DSP Digital Audio Interfaces. >>> + >>> + properties: >>> + reg: >>> + maxItems: 1 >>> + description: >>> + Digital Audio Interface ID >>> + >>> + clocks: >>> + minItems: 1 >>> + items: >>> + - description: MI2S master clock >>> + - description: MI2S bit clock >>> + - description: MI2S external bit clock >>> + >>> + clock-names: >>> + minItems: 1 >>> + maxItems: 3 >>> + items: >>> + enum: >> >> That wasn't here and that's also not correct, usually. Especially that >> it does not fit your clocks property. >> > > The reason for changing this to enum was that some hardware may expose > only a single clock, which can be bclk or eclk instead of mclk. With the > previous positional const definition, such configurations fail schema > validation because the first entry is always expected to be mclk. > master clock feels like something should be present there always, but if that is the case, then you need: minItems: 1 items: - enum: [ bclk, eclk ] - const: eclk - const: mclk Best regards, Krzysztof