From: Roger Quadros <rogerq@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
MD Danish Anwar <danishanwar@ti.com>,
"Andrew F. Davis" <afd@ti.com>, Tero Kristo <t-kristo@ti.com>,
Suman Anna <s-anna@ti.com>, YueHaibing <yuehaibing@huawei.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
andrew@lunn.ch
Cc: nm@ti.com, ssantosh@kernel.org, srk@ti.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver
Date: Mon, 2 Jan 2023 14:55:30 +0200 [thread overview]
Message-ID: <2b50caa7-68a7-ee99-594c-0293168666cb@kernel.org> (raw)
In-Reply-To: <e7960761-07c1-8cc7-60b3-1454ddb9317b@linaro.org>
Hi,
On 23/12/2022 13:32, Krzysztof Kozlowski wrote:
> On 23/12/2022 12:09, MD Danish Anwar wrote:
>> From: Roger Quadros <rogerq@ti.com>
>>
>> This is the Ethernet driver for TI AM654 Silicon rev. 2
>> with the ICSSG PRU Sub-system running dual-EMAC firmware.
>>
>
>
> (...)
>
>> +
>> +/* Memory Usage of : DMEM1
>> + *
>> + */
>
> ??? What's this?
>
>> +
>> +/* Memory Usage of : PA_STAT
>> + *
>> + */
>
> Same question.
>
>> +
>> +/*Start of 32 bits PA_STAT counters*/
>
> That's not a Linux coding style. Add spaces and make it readable.
The contents of this file were copied from f/w.
This file needs to be reduced to only the elements that
we really use in the Linux driver and coding style fixed.
cheers,
-roger
prev parent reply other threads:[~2023-01-02 12:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 11:09 [PATCH v3 0/2] Introduce ICSSG based ethernet Driver MD Danish Anwar
2022-12-23 11:09 ` [PATCH v3 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings MD Danish Anwar
2022-12-23 11:31 ` Krzysztof Kozlowski
2023-02-01 11:10 ` [EXTERNAL] " Md Danish Anwar
2022-12-23 14:28 ` Andrew Lunn
2023-01-02 13:04 ` Roger Quadros
2023-01-02 18:34 ` Andrew Lunn
2023-01-05 11:33 ` Roger Quadros
2023-01-05 17:13 ` Andrew Lunn
2023-01-06 11:15 ` Roger Quadros
2023-01-30 7:02 ` [EXTERNAL] " Md Danish Anwar
2022-12-23 11:09 ` [PATCH v3 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver MD Danish Anwar
2022-12-23 11:32 ` Krzysztof Kozlowski
2023-01-02 12:55 ` Roger Quadros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b50caa7-68a7-ee99-594c-0293168666cb@kernel.org \
--to=rogerq@kernel.org \
--cc=afd@ti.com \
--cc=andrew@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=srk@ti.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=vigneshr@ti.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).