Re: [PATCH v3 2/2] arm64: dts: qcom: x1e78100-t14s: Add thermal zones for keyboard skin and charging sensors

[Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>]

On 7/2/26 14:17, Konrad Dybcio wrote:
> On 7/1/26 12:37 PM, Daniel Lezcano wrote:
>> The Lenovo ThinkPad T14s embedded controller exposes several platform
>> temperature sensors that are already used by the firmware for thermal
>> management.
>>
>> Expose the EC as a thermal sensor provider and describe the keyboard
>> skin and charging circuitry sensors as thermal zones in the device
>> tree.
> 
> [...]
> 
>> +&thermal_zones {
>> +	ec-keyboard-thermal {
>> +		polling-delay = <5000>;
>> +		polling-delay-passive = <1000>;
>> +
>> +		thermal-sensors = <&ec 1>;
> 
> Do you think it'd be worth to add dt-bindings defines to avoid raw
> numbers here?

No it is not worth. Usually we put raw numbers and they are untouched.

> [...]
> 
>> +		cooling-maps {
>> +			map0 {
>> +				trip = <&ec_charging_psv0>;
>> +				cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +						 <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +						 <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +						 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +						 <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +						 <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +						 <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +						 <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +						 <&cpu8 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +						 <&cpu9 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +						 <&cpu10 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +						 <&cpu11 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>> +			};
>> +		};
>> +
>> +	};
> 
> Stray \n above
> 
> Otherwise:
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Thanks for your review