From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8AF61A3160 for ; Fri, 26 Jun 2026 07:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782460174; cv=none; b=i73DTydL3KAELQDhGEnAnsZiFdDdZv1zyGSWSWgfGxyc3J2v8MW/PpmSpPzCQ9RnLvhScG5/87mXWyve9MkA6O9jM9CMfdXnMcEGI+TajseImDxFmbalRTFG1Ki3fP3VuDS95Mhc4TvXmyol5JSJwWkbj4cOeY/GN/Z28hpc4Lg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782460174; c=relaxed/simple; bh=dvFcYGe6L1idfk9wGMYrduqPaQs0l4aNwLSYhUvK3AQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MQA+jkEtuonXo1Sm4t1QBBwk/9AQeLhWoZRflYWg7gOouNZtaznxmRBpJg7oM/fgLZ99DCHdJc+pd8kdGyg1p5D+b0VvB1jcLToTLgo5MuSvKnXDz5AvTxRMFnJRuvzEm3GQ145Dr5Ov6gjmEhTdBAvtmy/cB9XLcQUmuFi+GEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=dkGxPK9Y; arc=none smtp.client-ip=91.218.175.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="dkGxPK9Y" Message-ID: <2b620c1d-af40-4813-9df0-b63adb1161b5@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782460170; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Di4YVjFIZfU5+zAiTbJY2s0en/y+uu5qey0tpETgvQ=; b=dkGxPK9YoXJRxPyNDIjKx9iLBIQYNTsCpeXMyGgXb0b9XB2wV78ochqztm7CbfsAK1GmkJ 3vVmKr5xXIod8LEJJZPBspf0sNzRwT3I2i+8wsh9og6gPxRhX6WK/jlG7BFC0bXhGhTuMz +GmR5Wr/t4EJVAGtrBxxUSsrO8Hcfbk= Date: Fri, 26 Jun 2026 10:49:25 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-To: mazziesaccount@gmail.com Subject: Re: [PATCH v2 9/9] hwmon: adm1275: Support ROHM BD12790 To: sashiko-reviews@lists.linux.dev Cc: linux-hwmon@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org References: <20260626073347.A06981F000E9@smtp.kernel.org> Content-Language: en-US, en-AU, en-GB, en-BW X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Matti Vaittinen In-Reply-To: <20260626073347.A06981F000E9@smtp.kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 26/06/2026 10:33, sashiko-bot@kernel.org wrote: > If we evaluate m = round(k / 10^(-3-R)) for a value of R=-2 and k=35119.94, > it yields 351199.4. However, the actual code below correctly implements the > value as 3512, which implies the formula should use multiplication rather > than division. Gah. I think Sashiko is right. The fixed comment should say: m = round(k * 10^(-3-R)) -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~