Re: [PATCH 9/9] ASoC: dt-bindings: sound: exynosauto: add PCM frontend nodes for ABOX generic

[Krzysztof Kozlowski <krzk@kernel.org>]

On 21/07/2025 04:30, ew kim wrote:
> This patch extends the Exynos Automotive ABOX generic device tree bindings
> to support PCM playback and capture frontend nodes.
> 
> Each PCM device node describes an audio stream interface handled by the
> ABOX DSP. These nodes include properties for stream ID, IRQ, ADSP core
> assignment, buffer limits, and stream category (deep_buffer or compress).
> 
> The bindings use patternProperties to match playback and capture nodes
> as children of the abox_generic controller.

This split of one device into three makes no sense. Adding new binding
is one commit.

> 
> Signed-off-by: ew kim <ew.kim@samsung.com>
> ---
>  .../bindings/sound/samsung,exynosauto.yaml    | 126 +++++++++++++++++-
>  1 file changed, 123 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml b/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml
> index 3a7b5be627ee..e477550afc7c 100644
> --- a/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml
> +++ b/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml
> @@ -28,6 +28,14 @@ properties:
>    compatible:
>      const: samsung,abox_generic
>  
> +  status:
> +    enum: [ okay, disabled ]
> +    description: DTS node enablement state


Sorry, but why are you writing something entirely different than every
other binding?


Best regards,
Krzysztof