From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 847993EDACC for ; Tue, 31 Mar 2026 09:40:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774950041; cv=none; b=VVaXk1G68yJJyVrYfnVIl9bdq1140ZKXk8DGCSlu+DGencsT2OEy1+w8pvnNPlwyPejQCUi9pv4PrMauxEQMW5a6wZsrminOAiDcNFFmDpC3u9RDHmW7KCqxFrIocODqRAiHIxHZqm1OZnNHxlh5phVJS+4bmCB8P8GZXzJ/sgw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774950041; c=relaxed/simple; bh=6TtXtGHuwbeOGc43RV1ox/wCKy7dGy+cBU/v5F7GGuY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XwoaQPE8O0wTnOhuxXzRcW4/oyDc2JcbPJsX4nYcPtsuB7Eo37W/CyD9xjAoc+C8uwBj6wk6cWNrtVBhQ63pOVtlCXl4Ab9862CRs4uvE22GxbR13W9vfYi2MC66FA74MGMwBdEK4+kwWe8PGxdNnelZhzUibE5IntKNmide7YU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=labxpXx4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OdzHmQgO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="labxpXx4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OdzHmQgO" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V6A6JM1090724 for ; Tue, 31 Mar 2026 09:40:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oO9fj8VnemesVNw4Kd4kvPTyxIt0YprBH9NBYs6VYwU=; b=labxpXx4emFwd9Yw YA7lhLzAwsnly1/7QCm/HoKB4VvxJk5Kd+9ioBAV7C+Q1bSWsvFm8NGPdb7IPM1F s7gYkJu+AJTSPV6gPZlURLmaRK5BoJJDFI7oXaAfVBQqNTYiuppLjohFJwODGIcQ JM3rfwvQRshKKTeUV06sbxM89gBJLxVaJL9KIM1GqT6DvH+/iNUNsgCV8PS5Hud8 nugOPtJl3acxB4J+FYMqejbVL235iFwAi561ZOq2YfL6GWECeWw+YunfjAMccSUr ktG+r/tV2m7yVXFNV92+i7eHQooqF8TLpLOhMBQsHDRrhMjEtlp/uHfvSPwfJV3/ vcri9g== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7trd42tf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 09:40:34 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b0c30b51bfso146920915ad.0 for ; Tue, 31 Mar 2026 02:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774950033; x=1775554833; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oO9fj8VnemesVNw4Kd4kvPTyxIt0YprBH9NBYs6VYwU=; b=OdzHmQgOyB4myKofD7Sd+W3RDBvUMbFZX2FQWPlSNdapC6RPoXxzBswgb75zxyMlpi cmKlJVCd81eO7hrciagYFaIACfE92SZYoB8O+C0TSfbFZych+b3nISFtERp3ZteiXbF/ NPJWLfZKNTcNo+1qhmm2ee67NOxLRbjRlgVCtRLTqFwJrNLSnkNZ+KyFcbCCDBG/NDqZ yAYMCXBLSoroO6e0UwP2vSeyyi2+tgU5omRXzIRFIdA8W+GqcM6qfLq+nuqOtVX8nsOn 2ZPj2MYXyOZsxKKEqoh2CXaHE/Tm1dIL7rWMk0atSOGJXYoupolVXKVuWGzUZIyTZZRN Aauw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774950033; x=1775554833; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oO9fj8VnemesVNw4Kd4kvPTyxIt0YprBH9NBYs6VYwU=; b=cJ4GnKq6w01Iwv7ajRZhKku616KmwO92Hl+e40v5h/pNMUdoPyh/x6jsD+XEa4eri4 +QNd+V5cgaFypkY7nG3/fAl21cpxUSyZ4fPnlq1tnS0cAHHDwZzvZSh7GcBiE/K61Ftj YSRYs4b8vz94gZ2qexRr46UJLTM16JwSVLiNpQ+DjkinIUK3Vl7tBBijZp2FUNxuXLZ/ 73VvT5R2MrQm6J/AO0B89zhBlmS0Xy+/gksWnT7xHEOIpse/V0gASnfXRBhJX9vkhz37 9glUsOxGQOcPhKLM9GzePUQk/hoQPjERt2n3QlWxxdA+R9JB5qulmPcCR5Sppu30C3YP uc1Q== X-Forwarded-Encrypted: i=1; AJvYcCW5j8VLk5LOFjaJh6wNoNbczvdqkfqImktloAvGCs8q4PswH6XFVvgJhnYJCNP+dXKlAnAHPkxK4DDZ@vger.kernel.org X-Gm-Message-State: AOJu0YwL7WyncummoWn9N7AIlhdGhZxa0lnDDLpPFi98hyAGCWNMqBid XPyc68/BRHgKAv2pYKe0u94wCMstZceJqGOnmSY/RTeyXHQpBiVbxr60Wh1SbH6P9VUhrkfCyKS /js9l47ScUvykZwSOXKS+woTfx2gH7JmuvmAyenn7EDn5qkRj0vW+5jjSu+0MxNQv X-Gm-Gg: ATEYQzxH99QiN33Ct8ZnHt8DAkwkrOdwXgtwByQRTtQQJZz+Wjg78QJeYpFWnWKjeWs artN7K+ZDgHRiS88FbXMmimUzJZQn+dX00ZnhAvynRnv2/hJcKQFwawQ3JdPhFPmNAmQjqSHMV+ 4vVwmQwViOJJzDHKXV7QywlREw/Pj9DJhJteZidmTASDedmuD7btr08vUJLsz8/VSRJwGaEwlmz s3Kgr9kGcK8AUJ9eKteEiALGurhpMnc8ZHFI1UQQ4UKiibJGO9h1R81rRuDyhh+/ADJZZGjv6pO 6fdbKgmQRHpLl5v68M91eyDeBQSYTggEVLWvAwL+3JOQlWCHJL0MhmWUAT+2AkrpBUgGFEXT+2n DiOWAJ30kCyEeplxy+whgIjQ429BnEU0oVS7tuIh6gz6ZJidhjt4= X-Received: by 2002:a17:902:ef4f:b0:2b0:b1e7:8841 with SMTP id d9443c01a7336-2b0cdcb0990mr168484655ad.32.1774950033392; Tue, 31 Mar 2026 02:40:33 -0700 (PDT) X-Received: by 2002:a17:902:ef4f:b0:2b0:b1e7:8841 with SMTP id d9443c01a7336-2b0cdcb0990mr168484325ad.32.1774950032814; Tue, 31 Mar 2026 02:40:32 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2427660c7sm106046705ad.44.2026.03.31.02.40.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 02:40:32 -0700 (PDT) Message-ID: <2b71dd68-ff35-411e-905d-3ffa2ea3efe4@oss.qualcomm.com> Date: Tue, 31 Mar 2026 15:10:22 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/11] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk To: Kuldeep Singh , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Krzysztof Kozlowski References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> <20260323-qcom_ice_power_and_clk_vote-v4-1-e36044bbdfe9@oss.qualcomm.com> <873e8ad2-50cd-4c09-9a51-20ad745fe8dc@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: <873e8ad2-50cd-4c09-9a51-20ad745fe8dc@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 6QQjCmbdVcypRKZdXdI72ZImPACStuv_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDA5MiBTYWx0ZWRfX3aRdcKWzG8zb 4hM9z2RdvV8UoX4hhQmNIpx8fSCBsdBXL1uq88SkmddOgzt2BUq6BZ9fvwCd3ff7GJhyl9JMonx mtcuxaSi7smpGcZt9mb+0qIoANcAKKTRyLjmwTp66TEjf7b8IFVFDsMH5lNDVGFReRQPZbeW+LR l0H964u4c3ochLMg9GoALM1iJdO21qyyXt936c+qaRdN+uDC8ZVwDDO46gT6gZ58sgwSE+IaRNs bYcvShyJLxY2xjR0xOgBjw9qcEp8dx9eu10FlgasKlLkfB6DL2Wf2Q47leZmy1p2kxI+sUTeUlV wLPMJE4t+6x+gZ3Ph1qYfyOYdpV22frAixzJ4EZAhyCpafMx3Vzr9s/aNFSteaznZ6fYlY6Ei/4 64PnRc4QIO2a1U74QW28m/gsdrsUY/aN6Cy0y3zJHobMdXxdCFZyp/UsR317ebiH4YZuSGLUm7w E1qnhm0NlwnY/oyZ8Ug== X-Proofpoint-ORIG-GUID: 6QQjCmbdVcypRKZdXdI72ZImPACStuv_ X-Authority-Analysis: v=2.4 cv=H8/WAuYi c=1 sm=1 tr=0 ts=69cb9692 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=11eJxmzFO3uqpiRjfBAA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 bulkscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310092 Hi Kuldeep, On 3/24/2026 4:16 PM, Kuldeep Singh wrote: > > On 3/23/2026 2:47 PM, Harshal Dev wrote: >> The DT bindings for inline-crypto engine do not specify the UFS_PHY_GDSC >> power-domain and iface clock. Without enabling the iface clock and the >> associated power-domain the ICE hardware cannot function correctly and >> leads to unclocked hardware accesses being observed during probe. >> >> Fix the DT bindings for inline-crypto engine to require the UFS_PHY_GDSC >> power-domain and iface clock for new devices (Eliza and Milos) introduced >> in the current release (7.0) with yet-to-stabilize ABI, while preserving >> backward compatibility for older devices. >> >> Fixes: 618195a7ac3df ("dt-bindings: crypto: qcom,inline-crypto-engine: Document the Eliza ICE") >> Fixes: 85faec1e85555 ("dt-bindings: crypto: qcom,inline-crypto-engine: document the Milos ICE") >> Signed-off-by: Harshal Dev >> --- >> .../bindings/crypto/qcom,inline-crypto-engine.yaml | 35 +++++++++++++++++++++- >> 1 file changed, 34 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> index 876bf90ed96e..ccb6b8dd8e11 100644 >> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> @@ -30,6 +30,16 @@ properties: >> maxItems: 1 >> >> clocks: >> + minItems: 1 >> + maxItems: 2 >> + >> + clock-names: >> + minItems: 1 >> + items: >> + - const: core >> + - const: iface >> + >> + power-domains: >> maxItems: 1 >> >> operating-points-v2: true >> @@ -44,6 +54,25 @@ required: >> >> additionalProperties: false >> >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,eliza-inline-crypto-engine >> + - qcom,milos-inline-crypto-engine >> + >> + then: >> + required: >> + - power-domains >> + - clock-names >> + properties: >> + clocks: >> + minItems: 2 >> + clock-names: >> + minItems: 2 >> + > > Hi Krzysztof, > > As motive here is to enforce 2 clocks for upcoming targets and keep > minItems as 1 for already merged ones for ensuring backward > compatibility. Can we do like below? > > allOf: > - if: > not: > properties: > compatible: > contains: > enum: > - qcom,kaanapali-inline-crypto-engine > - qcom,qcs8300-inline-crypto-engine > - qcom,sa8775p-inline-crypto-engine > - qcom,sc7180-inline-crypto-engine > - qcom,sc7280-inline-crypto-engine > - qcom,sm8450-inline-crypto-engine > - qcom,sm8550-inline-crypto-engine > - qcom,sm8650-inline-crypto-engine > - qcom,sm8750-inline-crypto-engine > > then: > required: > - power-domains > - clock-names > properties: > clocks: > minItems: 2 > clock-names: > minItems: 2 > > This will ensure for every new target addition, default clock count is > enforced as 2 default. > Please share your thoughts as well. > I don't really have any particular objections to this proposal, but I can see that other bindings where the need for an additional clock was realized later on use a similar pattern as this patchset does: https://elixir.bootlin.com/linux/v7.0-rc2/source/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml I'll wait for Krzysztof to take a final call on this. Regards, Harshal