From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BD1F22089 for ; Tue, 28 May 2024 23:51:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716940271; cv=none; b=UoHplC9urAnC31SM2kHzZSnZCoh39Q9T8emiWWDkmcHrdY/pMxWnpRKznBehu6gK0h1shIZCjjgTIsyPgzEVYXhGVkpCSAMpikGd9MN0vf8OEn3GUdMihsv1naqCsTRSVcXMO0aJbhGwvx2yvm/peJaKNLDmF2pX3QY4DX1rXPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716940271; c=relaxed/simple; bh=U6rd2u/yCnU0MQ4VXeRi1hcrtx+O94VJz7DpKLJXgOg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OOeURW2I5Q1RJrB/fT2f08v3DZwrpZDaP/vu7EmO7DLQwkI9Y/EbUsYoU284ayuJP554F+j7Ynof59vlgJewrCTA3UX1K12fOVOmJLrHkmiV9Mfv9DXoaUrt3mejnad9R0NTRsp2Xe2VDbI982IE2h9wu0829nuUUhiFw/iVy+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V+jw15C8; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V+jw15C8" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4202c1d19d5so12958135e9.2 for ; Tue, 28 May 2024 16:51:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716940267; x=1717545067; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dnSBP1y73hXcLVKI9OFBOJOQjY/3gyc0Iux1Jkwjjpo=; b=V+jw15C8+aar+vke7hh19d3HSdFtotGesTwDabLAiIWPpsYkyOmbqFNVoK1LTc6ski 8ONRe5Qv5OnVBg6Ci/T2Esy6t3OiQLX/ugXiHJDzLeiIE2ebVDSElwjQ3EfpYwnUZ1re dpkYlTrWCaO34j8keqaXwCZKx7iqMRsIUt5QhvGXFbAfJLejjXlY0baSaHpNUn34Jc5m ctAeevP8knFXDO4ZDVgwnKdzdqmmJl+W0+qrNXXhBr50UAqIOmQfrPLksTvM5M6a3zyE VzakXif8U9hpDuX2lsPRoXHKGdQOwOHScUWQxr9Rc9RCrnwaymXVh2VF3LD3yiVQENix /z2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716940267; x=1717545067; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dnSBP1y73hXcLVKI9OFBOJOQjY/3gyc0Iux1Jkwjjpo=; b=qeX+F8E/W7ap/Gn2vkLdUxzkfP179zSOirEnbPgyezrNASm/XoUdOXtRjsjRsuSFKq dBthXoPlGaFjYV58pL12CQN0pFdhh745vjI8xttWvThUGXZHwImSBcSiLSiThfSqHIzc 9cfxJZGQH+aRso1w7aMsT7JZxZz0tcHiGz1ds754XfW+HlbEB2CBslbDEEb9bbCBr2ov eIyY8h2jbEerPS+M+3ykyZiHLyw5BCpxj8xfhxotyMOhqLvsLwBBErmqDa8z0wMxdCzj 1O7wYhbYgyVbwKOXRb3vfFEGjOBVvZOr9OubMKxOG0UGk4Gnchwsy4ZpYp0MPwNJenxU ZiHw== X-Forwarded-Encrypted: i=1; AJvYcCXavKarX2MTn/0rNYK2S+Vt4oQFyG2CXfL5zSamzb3h9i+pJh2xOG8xocgyImUDP6oqTrZrfBzGZdGmA14zJCi9zRo9+zoAFx1F1A== X-Gm-Message-State: AOJu0YwG3s+t29XNvPIORgPQplXQBlgMEI7UEAtNqY2rjphOJ43PySzy nJUf9JhXbtUGzfs44rmC789G00eGaXbd98a8PZJGp5H0IbwbKrGYlb0JTx3PzEw= X-Google-Smtp-Source: AGHT+IGW+PMxhqpCnMYFAJtAcLClSa/LPe6M4D7yxH9tVsegfjt88HkF3gmo6+nhSpDmBiJRq2Ux+g== X-Received: by 2002:a05:600c:3595:b0:41a:c170:701f with SMTP id 5b1f17b1804b1-421089f9828mr115015805e9.38.1716940266996; Tue, 28 May 2024 16:51:06 -0700 (PDT) Received: from [192.168.0.23] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42100eeb962sm193040335e9.1.2024.05.28.16.51.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 May 2024 16:51:06 -0700 (PDT) Message-ID: <2b76f27e-f223-4ff9-880e-9e232ce9ddc6@linaro.org> Date: Wed, 29 May 2024 00:51:04 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/6] platform: arm64: add Lenovo Yoga C630 WOS EC driver To: Dmitry Baryshkov , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Heikki Krogerus , Greg Kroah-Hartman , Konrad Dybcio Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, Nikita Travkin References: <20240528-yoga-ec-driver-v4-0-4fa8dfaae7b6@linaro.org> <20240528-yoga-ec-driver-v4-2-4fa8dfaae7b6@linaro.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240528-yoga-ec-driver-v4-2-4fa8dfaae7b6@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/05/2024 21:44, Dmitry Baryshkov wrote: > Lenovo Yoga C630 WOS is a laptop using Snapdragon 850 SoC. Like many > laptops it uses embedded controller (EC) to perform various platform an embedded controller > operations, including, but not limited, to Type-C port control or power > supply handlng. > > Add the driver for the EC, that creates devices for UCSI and power > supply devices. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/platform/arm64/Kconfig | 14 ++ > drivers/platform/arm64/Makefile | 1 + > drivers/platform/arm64/lenovo-yoga-c630.c | 279 +++++++++++++++++++++++++ > include/linux/platform_data/lenovo-yoga-c630.h | 42 ++++ > 4 files changed, 336 insertions(+) > > diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig > index 8fdca0f8e909..8c103b3150d1 100644 > --- a/drivers/platform/arm64/Kconfig > +++ b/drivers/platform/arm64/Kconfig > @@ -32,4 +32,18 @@ config EC_ACER_ASPIRE1 > laptop where this information is not properly exposed via the > standard ACPI devices. > > +config EC_LENOVO_YOGA_C630 > + tristate "Lenovo Yoga C630 Embedded Controller driver" > + depends on I2C > + help > + Driver for the Embedded Controller in the Qualcomm Snapdragon-based > + Lenovo Yoga C630, which provides battery and power adapter > + information. > + > + This driver provides battery and AC status support for the mentioned > + laptop where this information is not properly exposed via the > + standard ACPI devices. > + > + Say M or Y here to include this support. > + > endif # ARM64_PLATFORM_DEVICES > diff --git a/drivers/platform/arm64/Makefile b/drivers/platform/arm64/Makefile > index 4fcc9855579b..b2ae9114fdd8 100644 > --- a/drivers/platform/arm64/Makefile > +++ b/drivers/platform/arm64/Makefile > @@ -6,3 +6,4 @@ > # > > obj-$(CONFIG_EC_ACER_ASPIRE1) += acer-aspire1-ec.o > +obj-$(CONFIG_EC_LENOVO_YOGA_C630) += lenovo-yoga-c630.o > diff --git a/drivers/platform/arm64/lenovo-yoga-c630.c b/drivers/platform/arm64/lenovo-yoga-c630.c > new file mode 100644 > index 000000000000..3d1d5acde807 > --- /dev/null > +++ b/drivers/platform/arm64/lenovo-yoga-c630.c > @@ -0,0 +1,279 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2022-2024, Linaro Ltd > + * Authors: > + * Bjorn Andersson > + * Dmitry Baryshkov > + */ > +#include > +#include > +#include > +#include > +#include > + > +#define LENOVO_EC_RESPONSE_REG 0x01 > +#define LENOVO_EC_REQUEST_REG 0x02 > + > +#define LENOVO_EC_UCSI_WRITE 0x20 > +#define LENOVO_EC_UCSI_READ 0x21 > + > +#define LENOVO_EC_READ_REG 0xb0 > +#define LENOVO_EC_REQUEST_NEXT_EVENT 0x84 > + > +struct yoga_c630_ec { > + struct i2c_client *client; > + struct mutex lock; > + struct blocking_notifier_head notifier_list; > +}; > + > +static int yoga_c630_ec_request(struct yoga_c630_ec *ec, u8 *req, size_t req_len, > + u8 *resp, size_t resp_len) > +{ > + int ret; > + > + WARN_ON(!mutex_is_locked(&ec->lock)); > + > + ret = i2c_smbus_write_i2c_block_data(ec->client, LENOVO_EC_REQUEST_REG, > + req_len, req); > + if (ret < 0) > + return ret; > + > + return i2c_smbus_read_i2c_block_data(ec->client, LENOVO_EC_RESPONSE_REG, > + resp_len, resp); > +} > + > +int yoga_c630_ec_read8(struct yoga_c630_ec *ec, u8 addr) > +{ > + u8 req[2] = { LENOVO_EC_READ_REG, }; > + int ret; > + u8 val; > + > + mutex_lock(&ec->lock); > + req[1] = addr; > + ret = yoga_c630_ec_request(ec, req, sizeof(req), &val, 1); > + mutex_unlock(&ec->lock); > + > + return ret < 0 ? ret : val; > +} > +EXPORT_SYMBOL_GPL(yoga_c630_ec_read8); > + > +int yoga_c630_ec_read16(struct yoga_c630_ec *ec, u8 addr) > +{ > + u8 req[2] = { LENOVO_EC_READ_REG, }; > + int ret; > + u8 msb; > + u8 lsb; > + > + mutex_lock(&ec->lock); > + > + req[1] = addr; > + ret = yoga_c630_ec_request(ec, req, sizeof(req), &lsb, 1); > + if (ret < 0) > + goto out; > + > + req[1] = addr + 1; > + ret = yoga_c630_ec_request(ec, req, sizeof(req), &msb, 1); > + > +out: > + mutex_unlock(&ec->lock); > + > + return ret < 0 ? ret : msb << 8 | lsb; > +} > +EXPORT_SYMBOL_GPL(yoga_c630_ec_read16); > + > +u16 yoga_c630_ec_ucsi_get_version(struct yoga_c630_ec *ec) > +{ > + u8 req[3] = { 0xb3, 0xf2, 0x20}; You have a define above for the read_reg and write_reg commands, could you not define 0xb3 as LENOVO_EC_GET_VERSION ? All of the other commands here seem to have a named define. > + int ret; > + u8 msb; > + u8 lsb; > + > + mutex_lock(&ec->lock); > + ret = yoga_c630_ec_request(ec, req, sizeof(req), &lsb, 1); > + if (ret < 0) > + goto out; > + > + req[2]++; why not set reg[2] = 0x21; also is req[2] some kind of address ? > + ret = yoga_c630_ec_request(ec, req, sizeof(req), &msb, 1); > + > +out: > + mutex_unlock(&ec->lock); > + > + return ret < 0 ? ret : msb << 8 | lsb; > +} > +EXPORT_SYMBOL_GPL(yoga_c630_ec_ucsi_get_version); > + > +int yoga_c630_ec_ucsi_write(struct yoga_c630_ec *ec, > + const u8 req[YOGA_C630_UCSI_WRITE_SIZE]) > +{ > + int ret; > + > + mutex_lock(&ec->lock); > + ret = i2c_smbus_write_i2c_block_data(ec->client, LENOVO_EC_UCSI_WRITE, > + YOGA_C630_UCSI_WRITE_SIZE, req); > + mutex_unlock(&ec->lock); > + > + return ret < 0 ? ret : 0; > +} > +EXPORT_SYMBOL_GPL(yoga_c630_ec_ucsi_write); > + > +int yoga_c630_ec_ucsi_read(struct yoga_c630_ec *ec, > + u8 resp[YOGA_C630_UCSI_READ_SIZE]) > +{ > + int ret; > + > + mutex_lock(&ec->lock); > + ret = i2c_smbus_read_i2c_block_data(ec->client, LENOVO_EC_UCSI_READ, > + YOGA_C630_UCSI_READ_SIZE, resp); > + mutex_unlock(&ec->lock); > + > + return ret < 0 ? ret : 0; > +} > +EXPORT_SYMBOL_GPL(yoga_c630_ec_ucsi_read); > + > +static irqreturn_t yoga_c630_ec_intr(int irq, void *data) > +{ > + u8 req[] = { LENOVO_EC_REQUEST_NEXT_EVENT }; > + struct yoga_c630_ec *ec = data; > + u8 event; > + int ret; > + > + mutex_lock(&ec->lock); > + ret = yoga_c630_ec_request(ec, req, sizeof(req), &event, 1); > + mutex_unlock(&ec->lock); > + if (ret < 0) > + return IRQ_HANDLED; > + > + pr_info("NOTIFY %x\n", event); why not dev_info() ? --- bod