From: Neil Armstrong <neil.armstrong@linaro.org>
To: Conor Dooley <conor@kernel.org>, Hironori KIKUCHI <kikuchan98@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Jagan Teki <jagan@amarulasolutions.com>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/5] dt-bindings: display: st7701: Add Anbernic RG28XX panel
Date: Wed, 24 Jul 2024 09:54:32 +0200 [thread overview]
Message-ID: <2b970471-114e-4955-811d-592c12b1782f@linaro.org> (raw)
In-Reply-To: <20240710-showdown-antirust-a3eb8b65c57f@spud>
Hi,
On 10/07/2024 16:01, Conor Dooley wrote:
> On Sat, Jul 06, 2024 at 07:23:34PM +0900, Hironori KIKUCHI wrote:
>> The RG28XX panel is a display panel of the Anbernic RG28XX, a handheld
>> gaming device from Anbernic. It is 2.8 inches in size (diagonally) with
>> a resolution of 480x640.
>>
>> This panel is driven by a variant of the ST7701 driver IC internally,
>> confirmed by dumping and analyzing its BSP initialization sequence
>> by using a logic analyzer. It is very similar to the existing
>> densitron,dmt028vghmcmi-1a panel, but differs in some unknown
>> register values, so add a new entry for the panel to distinguish them.
>>
>> Additionally, the panel only has an SPI instead of MIPI DSI.
>> So add and modify for SPI as well.
>>
>> Signed-off-by: Hironori KIKUCHI <kikuchan98@gmail.com>
>
> With a mention in the commit message about why we are adding a property
> and then immediately forbidding its use:
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Can you resend a v4 with this suggestion ?
Thanks,
Neil
>
> Thanks,
> Conor.
next prev parent reply other threads:[~2024-07-24 7:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-06 10:23 [PATCH v3 0/5] drm/panel: st7701: Add Anbernic RG28XX panel support Hironori KIKUCHI
2024-07-06 10:23 ` [PATCH v3 1/5] drm/panel: st7701: Rename macros Hironori KIKUCHI
2024-07-08 7:43 ` Neil Armstrong
2024-07-12 21:37 ` Jessica Zhang
2024-07-06 10:23 ` [PATCH v3 2/5] drm/panel: st7701: Decouple DSI and DRM parts Hironori KIKUCHI
2024-07-08 7:44 ` Neil Armstrong
2024-07-06 10:23 ` [PATCH v3 3/5] dt-bindings: display: st7701: Add Anbernic RG28XX panel Hironori KIKUCHI
2024-07-10 14:01 ` Conor Dooley
2024-07-24 7:54 ` Neil Armstrong [this message]
2024-07-06 10:23 ` [PATCH v3 4/5] drm/panel: st7701: Add support for SPI for configuration Hironori KIKUCHI
2024-07-24 7:53 ` Neil Armstrong
2024-07-06 10:23 ` [PATCH v3 5/5] drm/panel: st7701: Add Anbernic RG28XX panel support Hironori KIKUCHI
2024-07-24 7:54 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b970471-114e-4955-811d-592c12b1782f@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=kikuchan98@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).