From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 648D2C433F5 for ; Fri, 19 Nov 2021 17:18:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 468AB61353 for ; Fri, 19 Nov 2021 17:18:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236129AbhKSRV0 (ORCPT ); Fri, 19 Nov 2021 12:21:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbhKSRVZ (ORCPT ); Fri, 19 Nov 2021 12:21:25 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 492FBC06173E for ; Fri, 19 Nov 2021 09:18:23 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id t30so19271031wra.10 for ; Fri, 19 Nov 2021 09:18:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FP9hwialv6yAEl5OHXjo4xWuTQn68GpOH2rXlR/66qQ=; b=MuVMdJD3i6iM7EYol8YYUwOgrVkgeoYnCxECTuxTp1DkJEPyBXogLbS+0BLm/BesNc 5C1njJ+iZK4CmF+o4JS1nsHTp1HZauczmWlX9uTKS47QN/tRrq1CCb6BcUFNaDB6TUJd Oplxn2eTRvF08OVt0TVxP0wg9173tQ3QZyrhcYsqM/7idBy/8QtQbAjZ9gGdnBY3DnU6 S+2syCl7sL16NDP2EWzts51NPHYI78qdJHomqglMxIrN2yEJt/KWxyCunP/tR8j8zlJ+ YmYEBCu9deEMXB4AojU7nrPhLxPZQS2M1JPc09XLNrpu1l2Vw0IbtJzZQyCoA1ZYaAcm YvFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FP9hwialv6yAEl5OHXjo4xWuTQn68GpOH2rXlR/66qQ=; b=m1wzAzXPeB/AIClN7vY08mrfm7tCngFVAlxKkrUXlKTXhKWacazvWZhU7+ezoS6v8t 0z23DngVKukqyPXWKwl9IqB/JNgr+4TxpUOlsVjWRcpcScR0PR9w+7JEtWq2YqkWyXG1 lWggMZM6NV+rTg3MxNC8BKtupI0RyzBG1dVmxkMQN/1aucpgJ/imqSh2zUk5BpYeruGr JwPjvm4C/8RL1Rx+Ji8TYfgMBFHXExXvAHMPR3xDvXDFumn9XLPP2jRpXxrewCDl0W6k +5OdfbQW+uet04j3A2FwMLsATPeJp4NR9cei8r8Wdzg3hu7fKDoiuX/bulrVkWAvlGY/ CpVA== X-Gm-Message-State: AOAM532YHtwy9MPby2b7dxv4ZCN+S700z5vt8mhFn4jRp0U3BQIHH+kN 5Jg72knX23Ts94WR3M9lX5oSbA== X-Google-Smtp-Source: ABdhPJz7rGeQ3uY7+i432blgA51XM/NysPQuKduVTwISoTtJKsk/0HgDfWQCa+KDLzxoI19YoqhHKg== X-Received: by 2002:a5d:648f:: with SMTP id o15mr9083862wri.381.1637342301747; Fri, 19 Nov 2021 09:18:21 -0800 (PST) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id t1sm400914wre.32.2021.11.19.09.18.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Nov 2021 09:18:21 -0800 (PST) Subject: Re: [PATCH 3/6] nvmem: mtk-efuse: support minimum one byte access stride and granularity To: Chunfeng Yun , Rob Herring , Vinod Koul Cc: Matthias Brugger , Kishon Vijay Abraham I , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Eddie Hung , Andrew-CT Chen , Yz Wu References: <20211107075646.4366-1-chunfeng.yun@mediatek.com> <20211107075646.4366-3-chunfeng.yun@mediatek.com> From: Srinivas Kandagatla Message-ID: <2ba27f8a-6d10-3a7a-45b2-dbe503c79d47@linaro.org> Date: Fri, 19 Nov 2021 17:18:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211107075646.4366-3-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/11/2021 07:56, Chunfeng Yun wrote: > In order to support nvmem bits property, should support minimum 1 byte > read stride and minimum 1 byte read granularity at the same time. > > Signed-off-by: Chunfeng Yun Applied thanks, --srini > --- > drivers/nvmem/mtk-efuse.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c > index 6a537d959f14..e9a375dd84af 100644 > --- a/drivers/nvmem/mtk-efuse.c > +++ b/drivers/nvmem/mtk-efuse.c > @@ -19,11 +19,12 @@ static int mtk_reg_read(void *context, > unsigned int reg, void *_val, size_t bytes) > { > struct mtk_efuse_priv *priv = context; > - u32 *val = _val; > - int i = 0, words = bytes / 4; > + void __iomem *addr = priv->base + reg; > + u8 *val = _val; > + int i; > > - while (words--) > - *val++ = readl(priv->base + reg + (i++ * 4)); > + for (i = 0; i < bytes; i++, val++) > + *val = readb(addr + i); > > return 0; > } > @@ -45,8 +46,8 @@ static int mtk_efuse_probe(struct platform_device *pdev) > if (IS_ERR(priv->base)) > return PTR_ERR(priv->base); > > - econfig.stride = 4; > - econfig.word_size = 4; > + econfig.stride = 1; > + econfig.word_size = 1; > econfig.reg_read = mtk_reg_read; > econfig.size = resource_size(res); > econfig.priv = priv; >