From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Vasut <marex@denx.de>, Rob Herring <robh@kernel.org>
Cc: netdev@vger.kernel.org, kernel@dh-electronics.com,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Conor Dooley <conor+dt@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
devicetree@vger.kernel.org
Subject: Re: [net-next,PATCH] dt-bindings: net: realtek,rtl82xx: Document RTL8211F LED support
Date: Tue, 9 Jul 2024 11:01:22 +0200 [thread overview]
Message-ID: <2ba9b185-e9dc-4594-9b2d-983c74b0c55a@kernel.org> (raw)
In-Reply-To: <40249f5c-f034-41a5-8088-8b4c298ab6c6@denx.de>
On 08/07/2024 23:01, Marek Vasut wrote:
>>>
>>> +allOf:
>>> + - $ref: ethernet-phy.yaml#
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: ethernet-phy-id001c.c916
>>> + then:
>>> + properties:
>>> + leds: true
>>
>> This has no effect. 'leds' node is already allowed with the ref to
>> ethernet-phy.yaml. I suppose you could negate the if and then, but I'm
>> not really that worried if someone defines LEDs for a device with no
>> LEDs.
>
> So shall I simply do:
>
> leds: true
>
> and by done with it, as the easier way out ?
No, you should not have to do anything. Do you see any dtbs_check error
without this patch?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-09 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 21:51 [net-next,PATCH] dt-bindings: net: realtek,rtl82xx: Document RTL8211F LED support Marek Vasut
2024-07-08 20:58 ` Rob Herring
2024-07-08 21:01 ` Marek Vasut
2024-07-09 9:01 ` Krzysztof Kozlowski [this message]
2024-07-09 11:37 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ba9b185-e9dc-4594-9b2d-983c74b0c55a@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@dh-electronics.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).