From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Georgi Djakov <djakov@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: [PATCH 2/2] interconnect: qcom: Add SM6115 interconnect provider driver
Date: Sat, 25 Nov 2023 23:16:39 +0100 [thread overview]
Message-ID: <2bb681c7-8a93-4010-b473-887d68c6a5d2@linaro.org> (raw)
In-Reply-To: <20231125-topic-6115icc-v1-2-fa51c0b556c9@linaro.org>
On 25.11.2023 16:59, Konrad Dybcio wrote:
> Add a driver for managing NoC providers on SM6115.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
The following diff is missing:
----o<----
diff --git a/drivers/interconnect/qcom/sm6115.c b/drivers/interconnect/qcom/sm6115.c
index d7600dfe56c0..5b21566d64a5 100644
--- a/drivers/interconnect/qcom/sm6115.c
+++ b/drivers/interconnect/qcom/sm6115.c
@@ -609,8 +609,8 @@ static struct qcom_icc_node xm_usb3_0 = {
static struct qcom_icc_node ebi = {
.name = "ebi",
.id = SM6115_SLAVE_EBI_CH0,
- .channels = 1,
- .buswidth = 8,
+ .channels = 2,
+ .buswidth = 4,
.mas_rpm_id = -1,
.slv_rpm_id = 0,
};
----o<----
Georgi, if everything else is fine, could you please squash it while
applying? Otherwise I'll just amend it in v2.
Konrad
prev parent reply other threads:[~2023-11-25 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 15:59 [PATCH 0/2] SM6115 interconnect Konrad Dybcio
2023-11-25 15:59 ` [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SM6115 NoC Konrad Dybcio
2023-11-27 8:17 ` Krzysztof Kozlowski
2023-11-25 15:59 ` [PATCH 2/2] interconnect: qcom: Add SM6115 interconnect provider driver Konrad Dybcio
2023-11-25 22:16 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bb681c7-8a93-4010-b473-887d68c6a5d2@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).