* Re: [PATCH 1/3] dt-bindings: mediatek: Add gamma compatible for mt8195 [not found] ` <20220822091945.21343-2-zheng-yan.chen@mediatek.com> @ 2022-08-23 8:38 ` Krzysztof Kozlowski 0 siblings, 0 replies; 2+ messages in thread From: Krzysztof Kozlowski @ 2022-08-23 8:38 UTC (permalink / raw) To: zheng-yan.chen, Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski, Matthias Brugger Cc: dri-devel, linux-mediatek, devicetree, linux-kernel, linux-arm-kernel, Jason-JH . Lin, Singo Chang, Project_Global_Chrome_Upstream_Group On 22/08/2022 12:19, zheng-yan.chen wrote: > mt8195 uses 10bit-to-12bit gamma-LUT, which is different from > current 9bit-to-10bit gamma-LUT, so this patch add its own compatible > for mt8195. I am not sure if this explains the need for change. Is mt8195 still compatible with mt8183 or not? Your driver change suggests that it is and points that this commit is wrong. > > Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> > > --- > .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml > index a89ea0ea7542..fbd7b9664a78 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml > @@ -25,11 +25,12 @@ properties: > - const: mediatek,mt8173-disp-gamma > - items: > - const: mediatek,mt8183-disp-gamma > + - items: > + - const: mediatek,mt8195-disp-gamma > - items: > - enum: > - mediatek,mt8186-disp-gamma > - mediatek,mt8192-disp-gamma > - - mediatek,mt8195-disp-gamma Best regards, Krzysztof ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <20220822091945.21343-4-zheng-yan.chen@mediatek.com>]
* Re: [PATCH 3/3] arm64: dts: Modify gamma compatible for mt8195 [not found] ` <20220822091945.21343-4-zheng-yan.chen@mediatek.com> @ 2022-08-23 8:40 ` Krzysztof Kozlowski 0 siblings, 0 replies; 2+ messages in thread From: Krzysztof Kozlowski @ 2022-08-23 8:40 UTC (permalink / raw) To: zheng-yan.chen, Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski, Matthias Brugger Cc: dri-devel, linux-mediatek, devicetree, linux-kernel, linux-arm-kernel, Jason-JH . Lin, Singo Chang, Project_Global_Chrome_Upstream_Group On 22/08/2022 12:19, zheng-yan.chen wrote: > Modify gamma compatible for mt8195. > > Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com> > > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index a50ebb5d145f..8504d01b103a 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -2021,8 +2021,8 @@ > mediatek,gce-client-reg = <&gce0 SUBSYS_1c00XXXX 0x5000 0x1000>; > }; > > - gamma0: gamma@1c006000 { > - compatible = "mediatek,mt8195-disp-gamma", "mediatek,mt8183-disp-gamma"; > + gamma0: disp_gamma@1c006000 { No, really, no. Not explained in commit msg, violates naming convention, violates coding style, not related to the patch at all. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-23 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220822091945.21343-1-zheng-yan.chen@mediatek.com>
[not found] ` <20220822091945.21343-2-zheng-yan.chen@mediatek.com>
2022-08-23 8:38 ` [PATCH 1/3] dt-bindings: mediatek: Add gamma compatible for mt8195 Krzysztof Kozlowski
[not found] ` <20220822091945.21343-4-zheng-yan.chen@mediatek.com>
2022-08-23 8:40 ` [PATCH 3/3] arm64: dts: Modify " Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).