From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE3EE1EC00B for ; Thu, 20 Feb 2025 22:20:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740090057; cv=none; b=n2WQ2mpphgcPfRkPcE47sk2gkKUDxtjWCoif5cwQf0tordGOwyLi17NXIB1SSaNe6ZHmwJSKnKq9J9orY9wJMK+8xuHgWxn7jqcIH2lPlBMomw4e5eMFFFQr1c7u9Hd7DUSTUPi5LaFRZuyQPm9mHHl1C7MRiDmQICI5F07CVQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740090057; c=relaxed/simple; bh=PvZPfATyzGF1tVyo/MZSWBFBHWCB9OQhB2o1jTc8GJw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VayLQEWO4kg/hfknIqqIvMLa7DdhWZvVQ1tugIrYdLs+lOWDFwaWQIcjHtBv6YFuXipjGmSYZoMA2vzxGAUQE5PPYmSsnwol5Axjoal6hiS3BWCOo+nd8Bl5A7lm6iuSQERvHQKjJWNtNrdqmhqVak9LSq1QE040wk/7Im9fk6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=sBJ5I6Ei; arc=none smtp.client-ip=209.85.160.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="sBJ5I6Ei" Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-2b8e2606a58so663779fac.0 for ; Thu, 20 Feb 2025 14:20:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1740090053; x=1740694853; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9l3YRo0sHIKd5+q1opgKK8wbmOtDjari2OwXIj19kio=; b=sBJ5I6EiEI44JiPU+7tMCE9ArxxGTocX/Q58iy1C4q9mXpbJLHxIF1An1CQVTUbm1L v521tCYcN7j2W6adNqfNShMUN3YdLnYKSAe1pEHaN145DzkV4KZ7+vCZ5ljF221eUhYA JOrqDcuGdqe6FGGx/zsw+2U3CG4jaJeJCIhXWz/t7Gvk+LBG4Wt9sqpXaDmSELV9SKd5 qgfV0i5JJFvjKeTeaV2pU0oG+HCLKL9rpSEfcB3g+veZ5Ozj5sZ6IdFtIoKalqIP8tyE xloADgsfkcSLAMYS5hU0yit0vKEIoOl2o0pAskAbjdDLST9NXa6gqIlFtQy4eN0dYBu6 BPyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740090053; x=1740694853; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9l3YRo0sHIKd5+q1opgKK8wbmOtDjari2OwXIj19kio=; b=ad7p3DCKcqKKHS9TFobRy9H5CB7eKblZ8FNDhm7MIZYLdbh/id/G80XtSdtmZ3cSX/ FBSiw26NMUbsijqHdZIi29MmMU9E266WXAm2ndWbzqrOlQ7ou3HrTVA8ZbLyI+jcU35F a/KZkxStwZn5awrPi0y1RxClJBuPF4T4TS7pNXgqseWAVMOSPOjqufEJrptNoKKeh3bE opji9hTeyyXAkI4c+99pToa72q2K59VMk+LAcA+cjOrt6ENIXCUz/lc13bdBhiMgo0N+ Kqwyi6TVpKVBONrLs0SMeU92EYsO8Qrq2XlvWCQGIVeQYw3yU0VfAw94suKrz7AjqHxx 1IXw== X-Forwarded-Encrypted: i=1; AJvYcCUTFn85/0/5T2ASVC6qV0H2UOlESQVNwnHlWFgm9l99t1UDmDHkvVBPlRe+7HBl3Cc1scOlYR6g0P5Q@vger.kernel.org X-Gm-Message-State: AOJu0YzW1T2a7vLi2n3ud12ztYoppZGCVy/PAqmdcmxNqhdZDDYoEASC ptxunZAq8xjlEL+KbF7ndQSWCuLRpPIh8sryIF37+Wwz9+oxHqE1AnvBF2jBufE= X-Gm-Gg: ASbGncvwZZfWVUYlXs4PO/qHK5hEjwKsKgJUQHVQ8p0nc131sVkjPDkAUiZ9mrupE6I VAxzX3kcEUrkKv26evgXrtjb2zPUQ0tTK8vfVL+eS0jRU3azF6HGN3qRM+GDXYncYCWVrxyx7yV gl0lWiBqjVjXcx/RxZjhoDLrPrLIbVUEHMBnsWxjzBoxnl5ZTzxlJUwjJXda1ZeyGfAFuvaM8j6 ZKmcQcFqqxud1fsRQ3i8hb/acENnl0Kl2z7Lkt8aJ4ZtO2zrsblpY2Jx/FtheQ+X/HOzDvdeQ3l yGyEKHcnxRkHcjloaggNI92HUNkEl5NUmKC8QYyl5eP64VRrEndR X-Google-Smtp-Source: AGHT+IFLprTqXD6AwHy0OPaYFNoGmTsAOzA9ewOyAfm2dF8T++sTHcgNv9F8unuvzoRTHlN4VzoNnA== X-Received: by 2002:a05:6870:46a5:b0:29e:5ffa:b769 with SMTP id 586e51a60fabf-2bd50f3729emr799439fac.29.1740090052911; Thu, 20 Feb 2025 14:20:52 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7272737d70dsm2434883a34.42.2025.02.20.14.20.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 14:20:52 -0800 (PST) Message-ID: <2bc93cdf-e6d0-4879-a637-04db0bfe45aa@baylibre.com> Date: Thu, 20 Feb 2025 16:20:51 -0600 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v3 11/17] iio: adc: ad7768-1: add regulator to control VCM output To: Jonathan Santos , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lars@metafoo.de, Michael.Hennerich@analog.com, marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jonath4nns@gmail.com, marcelo.schmitt1@gmail.com References: <3552833157f252f3b6813f0042059e858c90d53a.1739368121.git.Jonathan.Santos@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <3552833157f252f3b6813f0042059e858c90d53a.1739368121.git.Jonathan.Santos@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/12/25 12:17 PM, Jonathan Santos wrote: > The VCM output voltage can be used as a common-mode voltage within the > amplifier preconditioning circuits external to the AD7768-1. > > This change allows the user to configure VCM output using the regulator > framework. > > Signed-off-by: Jonathan Santos > --- > v3 Changes: > * Register VCM output via the regulator framework for improved flexibility > and external integration. > > v2 Changes: > * VCM output support is now defined by a devicetree property, instead of > and IIO attribute. > --- > drivers/iio/adc/ad7768-1.c | 138 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 138 insertions(+) > > diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c > index 378245bce199..a359cd8fceca 100644 > --- a/drivers/iio/adc/ad7768-1.c > +++ b/drivers/iio/adc/ad7768-1.c > @@ -12,8 +12,10 @@ > #include > #include > #include > +#include > #include > #include > +#include > #include > #include > > @@ -80,9 +82,15 @@ > #define AD7768_CONV_MODE_MSK GENMASK(2, 0) > #define AD7768_CONV_MODE(x) FIELD_PREP(AD7768_CONV_MODE_MSK, x) > > +/* AD7768_REG_ANALOG2 */ > +#define AD7768_REG_ANALOG2_VCM_MSK GENMASK(2, 0) > +#define AD7768_REG_ANALOG2_VCM(x) FIELD_PREP(AD7768_REG_ANALOG2_VCM_MSK, x) > + > #define AD7768_RD_FLAG_MSK(x) (BIT(6) | ((x) & 0x3F)) > #define AD7768_WR_FLAG_MSK(x) ((x) & 0x3F) > > +#define AD7768_VCM_OFF 0x08 > + > enum ad7768_conv_mode { > AD7768_CONTINUOUS, > AD7768_ONE_SHOT, > @@ -160,6 +168,7 @@ struct ad7768_state { > struct regmap *regmap; > struct regmap *regmap24; > struct regulator *vref; > + struct regulator_dev *vcm_rdev; > struct clk *mclk; > unsigned int mclk_freq; > unsigned int samp_freq; > @@ -643,6 +652,130 @@ static int ad7768_triggered_buffer_alloc(struct iio_dev *indio_dev) > &ad7768_buffer_ops); > } > > +static int ad7768_vcm_enable(struct regulator_dev *rdev) > +{ > + struct ad7768_state *st = rdev_get_drvdata(rdev); > + int ret, val; > + > + if (!st) > + return -EINVAL; Do we need iio_device_claim_direct_mode() here to prevent accessing registers on the ADC during a buffered read? Same applies to other functions too. > + > + ret = regmap_read(st->regmap, AD7768_REG_ANALOG2, &val); > + if (ret) > + return ret; > + > + /* if regulator is off, turn it on */ > + if (FIELD_GET(AD7768_REG_ANALOG2_VCM_MSK, val) == AD7768_VCM_OFF) regmap_update_bits() already does this sort of check internally, so open-coding it here is redundant. > + return regmap_update_bits(st->regmap, AD7768_REG_ANALOG2, > + AD7768_REG_ANALOG2_VCM_MSK, 0x00); Can be simplified with regmap_clear_bits(). > + > + return 0; > +} > + > +static int ad7768_vcm_disable(struct regulator_dev *rdev) > +{ > + struct ad7768_state *st = rdev_get_drvdata(rdev); > + > + if (!st) > + return -EINVAL; > + > + return regmap_update_bits(st->regmap, AD7768_REG_ANALOG2, > + AD7768_REG_ANALOG2_VCM_MSK, AD7768_VCM_OFF); > +} > + > +static int ad7768_vcm_is_enabled(struct regulator_dev *rdev) > +{ > + struct ad7768_state *st = rdev_get_drvdata(rdev); > + int ret, val; > + > + if (!st) > + return -EINVAL; > + > + ret = regmap_read(st->regmap, AD7768_REG_ANALOG2, &val); > + if (ret) > + return ret; > + > + if (FIELD_GET(AD7768_REG_ANALOG2_VCM_MSK, val) == AD7768_VCM_OFF) > + return 0; Could skip the if and just return directly. > + > + return 1; > +} > + > +static int ad7768_set_voltage_sel(struct regulator_dev *rdev, > + unsigned int selector) > +{ > + unsigned int regval = AD7768_REG_ANALOG2_VCM(selector + 1); > + struct ad7768_state *st = rdev_get_drvdata(rdev); > + > + if (!st) > + return -EINVAL; > + > + return regmap_update_bits(st->regmap, AD7768_REG_ANALOG2, > + AD7768_REG_ANALOG2_VCM_MSK, regval); > +} > + > +static int ad7768_get_voltage_sel(struct regulator_dev *rdev) > +{ > + struct ad7768_state *st = rdev_get_drvdata(rdev); > + int ret, val; > + > + if (!st) > + return -EINVAL; > + > + ret = regmap_read(st->regmap, AD7768_REG_ANALOG2, &val); > + if (ret) > + return ret; > + > + val = FIELD_GET(AD7768_REG_ANALOG2_VCM_MSK, val) - 1; > + val = clamp(val, 0, 8); > + > + return val; > +} > + > +static const struct regulator_ops vcm_regulator_ops = { > + .enable = ad7768_vcm_enable, > + .disable = ad7768_vcm_disable, > + .is_enabled = ad7768_vcm_is_enabled, > + .list_voltage = regulator_list_voltage_table, > + .set_voltage_sel = ad7768_set_voltage_sel, > + .get_voltage_sel = ad7768_get_voltage_sel, > +}; > + > +static const unsigned int vcm_voltage_table[] = { > + 2500000, > + 2050000, > + 1650000, > + 1900000, > + 1100000, > + 900000, > +}; > + > +static const struct regulator_desc vcm_desc = { > + .name = "vcm_output", It looks like this is typically a datasheet name, like "AD7768-1 VCM" > + .of_match = of_match_ptr("vcm_output"), "vcm-output" as in DT bindings review. > + .regulators_node = of_match_ptr("regulators"), > + .n_voltages = ARRAY_SIZE(vcm_voltage_table), > + .volt_table = vcm_voltage_table, > + .ops = &vcm_regulator_ops, > + .type = REGULATOR_VOLTAGE, > + .owner = THIS_MODULE, > +}; > + > +static int ad7768_register_regulators(struct device *dev, struct ad7768_state *st) > +{ > + struct regulator_config config = { > + .dev = dev, > + .driver_data = st, > + }; > + > + st->vcm_rdev = devm_regulator_register(dev, &vcm_desc, &config); > + if (IS_ERR(st->vcm_rdev)) > + return dev_err_probe(dev, PTR_ERR(st->vcm_rdev), > + "failed to register VCM regulator\n"); > + > + return 0; > +} > + > static int ad7768_probe(struct spi_device *spi) > { > struct ad7768_state *st; > @@ -707,6 +840,11 @@ static int ad7768_probe(struct spi_device *spi) > indio_dev->info = &ad7768_info; > indio_dev->modes = INDIO_DIRECT_MODE; > > + /* Register VCM output regulator */ > + ret = ad7768_register_regulators(&spi->dev, st); > + if (ret) > + return ret; > + > ret = ad7768_setup(st); > if (ret < 0) { > dev_err(&spi->dev, "AD7768 setup failed\n");