From: Guenter Roeck <linux@roeck-us.net>
To: florin.leotescu@oss.nxp.com
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Shych <michaelsh@nvidia.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, daniel.baluta@nxp.com,
viorel.suman@nxp.com, linux-arm-kernel@lists.infradead.org,
imx@lists.linux.dev, festevam@gmail.com,
Florin Leotescu <florin.leotescu@nxp.com>
Subject: Re: [PATCH v7 1/3] hwmon: emc2305: Fix fan channel index handling
Date: Thu, 30 Apr 2026 16:13:15 -0700 [thread overview]
Message-ID: <2bce6b65-d09b-4237-be0f-3b53698d8031@roeck-us.net> (raw)
In-Reply-To: <20260429065955.2113012-2-florin.leotescu@oss.nxp.com>
On Wed, Apr 29, 2026 at 09:59:53AM +0300, florin.leotescu@oss.nxp.com wrote:
> From: Florin Leotescu <florin.leotescu@nxp.com>
>
> The fan channel index is used to access per-channel data structures.
> Validate the index against the number of available channels
> before use to prevent out-of-bounds access if an invalid
> value is provided.
>
> The thermal registration path currently uses a sequential child index,
> which may not match the validated channel from DT. Use the DT "reg"
> property when registering cooling devices to ensure consistent
> channel handling
>
> Signed-off-by: Florin Leotescu <florin.leotescu@nxp.com>
The problems found by Sashiko are real, but they are pre-existing.
The locking issues are pre-existing, and data->pwm_separate is for
all practical purposes always false (there is no upstream user of
the platform data, so it may well be removed), meaning there is no
separation of pwm channels if the thermal subsystem is enabled.
Given that, applied.
Thanks,
Guenter
next prev parent reply other threads:[~2026-04-30 23:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 6:59 [PATCH v7 0/3] Support configurable fan PWM at shutdown florin.leotescu
2026-04-29 6:59 ` [PATCH v7 1/3] hwmon: emc2305: Fix fan channel index handling florin.leotescu
2026-04-30 23:13 ` Guenter Roeck [this message]
2026-04-29 6:59 ` [PATCH v7 2/3] dt-bindings: hwmon: emc2305: Add fan-shutdown-percent property florin.leotescu
2026-04-29 18:18 ` Conor Dooley
2026-04-30 12:02 ` Florin Leotescu
2026-04-30 18:53 ` Conor Dooley
2026-04-30 23:14 ` Guenter Roeck
2026-04-29 6:59 ` [PATCH v7 3/3] hwmon: emc2305: Support configurable fan PWM at shutdown florin.leotescu
2026-04-30 23:17 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bce6b65-d09b-4237-be0f-3b53698d8031@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=florin.leotescu@nxp.com \
--cc=florin.leotescu@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelsh@nvidia.com \
--cc=robh@kernel.org \
--cc=viorel.suman@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox