From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A05C83F12 for ; Mon, 28 Aug 2023 19:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229738AbjH1Tbm (ORCPT ); Mon, 28 Aug 2023 15:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232031AbjH1TbL (ORCPT ); Mon, 28 Aug 2023 15:31:11 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5A11124 for ; Mon, 28 Aug 2023 12:30:48 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-9a5be3166a2so120527266b.1 for ; Mon, 28 Aug 2023 12:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693251047; x=1693855847; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7FF3uWcCF/fBgcKyKYxNsxhAz0t2E3t1fA13G/6hVqE=; b=WEEl2jADfaEkZMnwQHrnA1kfCneRgIh7ji/YjnBUeF0qSyiwTFRa19bkGzczgTWQPu YAI+ASpbvsAVvg9AF3d4lXje4x8ZTlqkqr8yGmz01jFYVdqYUvdCDAJBSphkK3F8sVsr 4oI1cy7A6KefK+HFJ92pGJroNIlakD2oKPyTDZQ86VGmJGQbv73EIiuMTrLP7tuqpjoR zyaHDvMAjfVLbA8m0Jf65GftzmQa/kvaOXGKmcIJ2AJSRXUN77U08wuBdauzgr6uENt/ 0os0OO4SHMceKiPHCaujMPJbZFGrN3vmp+8buPKqqQgOcXK7gDotT8KdN9esZbaumi3J 8F9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693251047; x=1693855847; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7FF3uWcCF/fBgcKyKYxNsxhAz0t2E3t1fA13G/6hVqE=; b=MTahYw2fh8Bo26QTQjldQHbMkZRHTDVpjMmgPCtc7bboayXRmIE/Dsh/VoNsdgKnls 1o+vU/noYxQy/aHt/HhqoDMCaOKQ5P1hVRuYGzWMOnkq0FKbWbzmhrCYdEgozxUd/DLB LBG6DCtp3rlmA51Bv3K5Alwckyj4cN0s7T+NGOgz+jusIrTXrmFRqFFZ6xfr/PuxWoEE 4lnYoniGS1t+92Db5W7PI4XywCJrjbjgOG1pBfKSZ4Psrpw+s2JIdSYSPgD/68Xatzi6 rEQ/cZf6VyCRJ6kEil9yJpejkakjuJr6U5sM447ytJnq1A1Lt1GGokMMTgSDF22woY7L F38w== X-Gm-Message-State: AOJu0YxVVPPD3GCwkbV1CN6HqTq40JZLzfRVpEQvLYDWAJEQ/R5O3sdU 33pW3jb6OXvz+CgzsdXLC43ZMw== X-Google-Smtp-Source: AGHT+IEKG5tzShBpR2V6RQtN9mM20TxelL4ewWN+rJjWEoIaBql1h7z0FvNmPsb79dAbg0aOhovkIQ== X-Received: by 2002:a17:907:778d:b0:9a1:d7cd:603a with SMTP id ky13-20020a170907778d00b009a1d7cd603amr12300358ejc.58.1693251047351; Mon, 28 Aug 2023 12:30:47 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.225]) by smtp.gmail.com with ESMTPSA id h7-20020a170906718700b0099bcf1c07c6sm5036313ejk.138.2023.08.28.12.30.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Aug 2023 12:30:46 -0700 (PDT) Message-ID: <2bd01950-20e0-51f1-91d2-88c9ee2e8dc0@linaro.org> Date: Mon, 28 Aug 2023 21:30:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [EXT] Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file Content-Language: en-US To: Shenwei Wang , Ulf Hansson Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , "imx@lists.linux.dev" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx References: <20230818153446.1076027-1-shenwei.wang@nxp.com> <4e2c18e3-b1ed-6361-3998-5de060d2bcf0@linaro.org> <51fe3126-16ba-ade6-b106-e3683f96ad26@linaro.org> <154b36de-652b-3931-96e6-04e99253a09f@linaro.org> <465e61a0-895d-54b9-d1b9-424265c82855@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/08/2023 21:23, Shenwei Wang wrote: >>>>> reg1: regulator-1 { >>>>> compatible = "regulator-fixed"; >>>>> regulator-name = "REG1"; >>>>> regulator-min-microvolt = <3000000>; >>>>> regulator-max-microvolt = <3000000>; >>>>> gpio = <&lsio_gpio4 19 GPIO_ACTIVE_HIGH>; >>>>> enable-active-high; >>>>> }; >>>> >>>> There is a chip. This is the chip. If you have there only GPIO pin, >>>> then your DTS is just wrong. Drop it. If you learn from wrong DTS, >>>> then sure, power-domain- regulator seems like great idea... >>>> >>> >>> When you talk about the chip, can you please be more specific? >> >> What to say more? The device node you quoted above is the regulator. You >> brought specific example and now claim this is not a regulator, but just GPIO. >> Please fix your DTS. >> > > The fixed-regulator is a virtual regulator driver that uses the GPIO pin. We do not talk about drivers but bindings and DTS. Why do you bring again drivers, all the time? > You claimed this > as a hardware chip. ??? Sorry, this is getting boring. The DTS-snippet is a hardware chip. If it is not, then drop it from your DTS. I insist. Srsly, third time I insist. > > The regulator-pd driver also uses the same GPIO pin. Again, what is with the drivers? Can you stop bringing it to the discussion? > You now claimed this as a software layer. ??? > > What's your standard? I don't think there is anything more to say. You clearly do not understand what is DTS, schematics and how the actual hardware looks like. I am not going to respond more to this patchset (which is a clear NAK just in case). Best regards, Krzysztof