From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795191379; b=z0D2J15zjCIMEvfuZBo8RF9YM7gGll9rPwE+m5avj0FAtzOxE48EtmEiS9aurevYXiCF fGJx2mcPc6EWSCx4tsXei/lkNKNuE7PpJdL/1npEYJK3qtfPQ+PnYu19B1d/gTl+LV7za NfZUM6fZj5+jRYCgJiayN9TBmVq72lcD0Xmbfti9AFXlHf50gt8wPtJTkIHFj8NYIWjl0 ujsO4E3CIUanfJyg851le83ctozO5NIVRLXbNij+6/5UK0ddcczHlgohgIz4vRO4l2139 Dt40UqUXmDV1qNP1VviayT1F8t3PvppNFDnEGW5qg4wPAyCJNrmp23kzyy05/sg+aDQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795191379; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=ufkrJtwpBnz6WPMTAKwab4l3d1SzDvPyFYqyMLcrdh0=; b=L3QmyqecA72tcRH1RHh1CA/lG2OBoQiowOymuDM/SqO4RqSjjGfE/QjxLe29XchkYVsY XejpuKLugtVyvwiKFlYKbiKF6znmXoGzVOHTCLrnl2ufL53Jj5lqISSFzA2uxrruHtis2 VOOO4VnIhdpRUSAPZRErBJfpfZFeAZVEOc9ACZ0qT5FRa319FwmEeakoa0T6Pbw3xD1hq YFP3tcDds7jQNcLuikp/TuT5X9ZHcviibJBYEMiKoxv3VlrfW7GZzfiYHltmicR7G64Tb H36VcLbChgzLVw4vHRwDdwITgPtA4ZRLP4XkbLS3CMT1c/or2qrdSDlHyxuV33QHl2g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dFvHyXyV; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65013606A32A; Fri, 20 Nov 2026 16:16:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dFvHyXyV Received: by smtp.kernel.org (Postfix) with ESMTPSA id 054D01F000CF; Fri, 20 Nov 2026 16:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795191378; bh=ufkrJtwpBnz6WPMTAKwab4l3d1SzDvPyFYqyMLcrdh0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=dFvHyXyVfCYjJ7NGMnBGAqmFCpcmUE94vICjEkzBBZoW/GMfsILWHwMTtiuJI1dZR isbdUdY2VdAjzDG9uOuj3HvrSFais+CocjccNOVwLZRv4W5ikc+GRT4v+Fx8NdqWKr ZyxCUZJwx62l8JwkMmsTJRdoDyRAYUklPkgCUjc0vcfaQmkZGX7zdu73B4j7pKlt9w g12fUi9O3FgrMF6IzDZZ0QywB+0HnVHqTSchls1fGpNhgm5tGk871tvM0ulpNBvy1x VvNSDoA5BvpXMpyONoBdWe1qJLOqoJGSzHqSYgnpGAyU4vXMxP3P+LXZxSsJ99YNir xqWdZ+uG5iH2A== Message-ID: <2bd84c5a-221e-4da0-bc08-93096b293395@kernel.org> Date: Fri, 20 Nov 2026 17:16:13 +0100 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 0/6] PSCI-via-EFI to support firmware and kernel sharing EL2 for Apple Silicon To: Ard Biesheuvel , Will Deacon Cc: Mark Rutland , Lorenzo Pieralisi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ilias Apalodimas , Catalin Marinas , Sudeep Holla , Janne Grunau , Neal Gompa , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, asahi@lists.linux.dev References: <20260708-efi-psci-v1-0-9efb3abf0e4c@kernel.org> <9c53cfd7-e193-4441-83ca-7710060225b7@app.fastmail.com> Content-Language: en-US From: Sven Peter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19.11.26 16:38, Ard Biesheuvel wrote: > > > On Tue, 17 Nov 2026, at 16:25, Sven Peter wrote: >> On 17.11.26 13:10, Will Deacon wrote: >>> On Sun, Nov 15, 2026 at 07:38:35PM +0100, Sven Peter wrote: >>>> >>>> >>>> On 03.09.26 15:25, Ard Biesheuvel wrote: >>>>> On Thu, 3 Sep 2026, at 14:15, Will Deacon wrote: >>>>>> On Thu, Sep 03, 2026 at 12:42:39PM +0100, Mark Rutland wrote: >>>>>>> On Thu, Sep 03, 2026 at 01:34:56PM +0200, Ard Biesheuvel wrote: >>>>>>>> On Wed, 8 Jul 2026, at 09:15, Sven Peter wrote: >>>>>>>>> This series adds a custom EFI table that points to a PSCI entry point >>>>>>>>> (plus some other stuff that has to be available before EFI runtime >>>>>>>>> services are set up) and adds support for this new conduit to the psci >>>>>>>>> code. We can't directly use the normal EFI runtime path because that one >>>>>>>>> takes a sleeping lock and we need to be able to call into PSCI from >>>>>>>>> atomic context during e.g. cpu bringup or during idle. >>>>>>>>> It also adds support for specifying the specific MAIR attributes for EFI >>>>>>>>> runtime mappings as defined in the latest UEFI spec since Apple Silicon >>>>>>>>> is rather allergic to using Device-nGnRnE vs. Device-nGnRE for its MMIO. >>>>>>> >>>>>>>>> dt-bindings: arm: psci: Add EFI conduit >>>>>>>>> arm64/efi: Add and parse custom PSCI EFI configuration table >>>>>>>>> efi: Add EFI_MEMORY_ISA_{MASK,VALID} >>>>>>>>> arm64/efi: Honor EFI_MEMORY_ISA_MASK for Device-nGnRnE vs -nGnRE >>>>>>>>> firmware/psci: Add EFI runtime conduit >>>>>>>>> arm64: dts: apple: t8103: Add PSCI and CPU idle states >>>>>>>>> >>>>>>>> >>>>>>>> I've picked up patches #3 and #4, which are useful in their own right. >>>>>>>> >>>>>>>> I'm not sure if the arm64 maintainers will want to consider this, but >>>>>>>> I think it's a reasonable compromise, as it puts the abstraction in >>>>>>>> the right place. >>>>>>> >>>>>>> Sorry for the late reply; I've been away almost all of August and I'm >>>>>>> slowly catching up on things. >>>>>>> >>>>>>> As with last time this was proposed (in abstract), I am not happy about >>>>>>> bodging an EFI conduit into PSCI, given that the manner in which state >>>>>>> is managed is completely different from SMCCC. >>>>>>> >>>>>>> If we need a mechanism for doing hotplug and/or idle without HVC/SMC, >>>>>>> that's one thing we can consider. I don't think we should pretend that >>>>>>> it is PSCI. >>>>>> >>>>>> What do you have in mind for an alternative mechanism? I understand your >>>>>> objection to this proposal, but at least it keeps the interface fairly >>>>>> high-level and avoids opening the flood gates for a bunch of SoC-specific >>>>>> idle routines. Are you thinking of extensions to the PSCI spec or >>>>>> something else? >>>>>> >>>>> >>>>> I can't speak for Mark, of course, but I could imagine EFI being used as a >>>>> conduit to provide a callable set of interfaces (with a rigorously defined >>>>> set of constraints such as the ones in this patch, i.e., reentrancy, no FP >>>>> or SIMD, not relying on ISA features that the OS needs to know about and >>>>> enable, etc). >>>>> >>>>> There is prior art here in ACPI PRM, which does something similar, and this >>>>> also relies on EFI runtime services. >>>>> >>>>> You'd still need to implement the CPU ops and a cpuidle driver afaict (no >>>>> expert here), but at least those would be coded against an interface that >>>>> the kernel itself specified, and can be made as generic as we choose to. >>>>> >>>>> Not saying this is all great, but it might be a worthwhile compromise to >>>>> consider. >>>> >>>> Finally getting back to this series... >>>> >>>> >>>> I'd definitely like to keep mapping the resident firmware using EFI runtime >>>> services because otherwise I'd have to duplicate a whole lot of tricky code >>>> to do the same thing via some other means (e.g. a device tree nodes that >>>> contains all mappings + callbacks) and I just don't see much value in that. >>>> >>>> I'm happy to just drop the PSCI part though and replace that with a simple >>>> and somewhat generic "efi-rt" (or similar) cpuidle driver and make that one >>>> have similar requirements like I added for this RFC series and expose bunch >>>> of generic callbacks (that will just happen to resemble PSCI functions very >>>> much ;)) via a custom EFI table. That would keep PSCI out of all of this but >>>> come at the cost of an additional cpuidle driver. >>>> >>>> I don't think that would open any flood gates for SoC-specific drivers since >>>> we could just point them to the generic one and tell them to use that one if >>>> they can't do PSCI for some reason. >>>> >>>> >>>> Now before I go off and prototype this: Would this approach be fine in >>>> general with you, Mark and Will? >>> >>> tbh, if the "efi-rt" thing is just PSCI with a different conduit and that >>> conduit is properly documented, then I really don't see the point in keeping >>> it separate. However. I suspect that we probably all have slightly different >>> opinions here which isn't going to help you very much :( >> >> Yeah, well, I agree but I really don't have a strong opinion or any good >> argument if either "efi-rt" vs "psci-via-efi" is better or worse. I only >> think both are better than SoC-specific cpuidle and cpu_ops drivers and >> I have no idea how else we could do this. (We could drop the kernel to >> EL1 and do "normal" PSCI in EL2 then but that would be much worse than >> either of those options imho) >> > > I agree with Mark that implementing a pseudo-PSCI that can never quite > comply with everything in the PSCI spec is probably not a great idea > unless we actually need it. > >> And especially with M4+ I'd like to have something that can go upstream >> because normal wfi loses most general purpose regs there and has to be >> disabled which is not great. >> >> I can also just prototype the efi-rt cpuidle+cpu_ops thing and then we >> can take a look at it as well and see if that's better than what I have >> in this series if that helps but I'd rather not spend that time if that >> has no chance of being accepted either. >> > > I think a consistent approach for both secondary bringup (+teardown?) and > cpuidle that is based on the same efi-runtime layer is perfectly acceptable, > and allows us to define it as narrowly as we can, rather than having to > consider what shared code might assume once it sees enable-method=psci on > a CPU, or a PSCI conduit (SMCCC detection, mitigations, etc etc) True, that's a very good point. At least for Apple SoCs I don't need anything nearly as complex as what PSCI provides. I think all that's required is cpu_on, maybe cpu_off, and cpu_enter_idle plus a bunch of static values (number of cpus, available idle states, etc.). Let me think this over and maybe come up with a simple proof of concept then. Sven