From: Conor Dooley <mail@conchuod.ie>
To: Justin Chen <justin.chen@broadcom.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org,
bcm-kernel-feedback-list@broadcom.com
Cc: justinpopo6@gmail.com, f.fainelli@gmail.com, davem@davemloft.net,
florian.fainelli@broadcom.com, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, opendmb@gmail.com,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
richardcochran@gmail.com, sumit.semwal@linaro.org,
christian.koenig@amd.com
Subject: Re: [PATCH net-next v3 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0
Date: Mon, 22 May 2023 19:17:54 +0100 [thread overview]
Message-ID: <2be2af5e-d117-fa2c-f960-e7f0c3ca3d0b@conchuod.ie> (raw)
In-Reply-To: <1684531184-14009-2-git-send-email-justin.chen@broadcom.com>
On Fri, May 19, 2023 at 02:19:39PM -0700, Justin Chen wrote:
> The ASP 2.0 Ethernet controller uses a brcm unimac.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
> ---
> Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
> index 0be426ee1e44..6684810fcbf0 100644
> --- a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
> @@ -22,6 +22,8 @@ properties:
> - brcm,genet-mdio-v3
> - brcm,genet-mdio-v4
> - brcm,genet-mdio-v5
> + - brcm,asp-v2.0-mdio
> + - brcm,asp-v2.1-mdio
> - brcm,unimac-mdio
From V(N-1), there was some discussion between Rob & Florian:
> > How many SoCs does each of these correspond to? SoC specific
compatibles
> > are preferred to version numbers (because few vendors are disciplined
> > at versioning and also not changing versions with every Soc).
>
> So far there is a 1:1 mapping between the number of versions and the
> number of SoCs, and the older SoC uses v2.0, while the newer one uses
v2.1.
Rob's not around right now, but I don't really get why if there is a 1:1
mapping you don't just name these things after the SoCs?
Also, my mailer **refused** to let me reply to you because of something
to do with a garbage S/MIME signature? Dunno wtf is happening there.
Cheers,
Conor.
next prev parent reply other threads:[~2023-05-22 18:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 21:19 [PATCH net-next v3 0/6] Brcm ASP 2.0 Ethernet Controller Justin Chen
2023-05-19 21:19 ` [PATCH net-next v3 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0 Justin Chen
2023-05-22 18:17 ` Conor Dooley [this message]
2023-05-22 18:25 ` Florian Fainelli
2023-05-22 18:38 ` Conor Dooley
2023-05-19 21:19 ` [PATCH net-next v3 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller Justin Chen
2023-05-22 18:27 ` Conor Dooley
2023-05-22 18:48 ` Justin Chen
2023-05-19 21:19 ` [PATCH net-next v3 3/6] net: bcmasp: Add support for ASP2.0 " Justin Chen
2023-05-20 4:43 ` Jakub Kicinski
2023-05-21 9:05 ` kernel test robot
2023-05-22 11:34 ` Simon Horman
2023-05-22 11:38 ` Simon Horman
2023-05-19 21:19 ` [PATCH net-next v3 4/6] net: phy: mdio-bcm-unimac: Add asp v2.0 support Justin Chen
2023-05-19 21:19 ` [PATCH net-next v3 5/6] net: phy: bcm7xxx: Add EPHY entry for 74165 Justin Chen
2023-05-19 21:19 ` [PATCH net-next v3 6/6] MAINTAINERS: ASP 2.0 Ethernet driver maintainers Justin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2be2af5e-d117-fa2c-f960-e7f0c3ca3d0b@conchuod.ie \
--to=mail@conchuod.ie \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christian.koenig@amd.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=justin.chen@broadcom.com \
--cc=justinpopo6@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).