devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.Li@nxp.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Shawn Guo <shawnguo@kernel.org>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/3] dt-bindings: usb: Add fsl,ls-dwc3.yaml for layerscape usb3 glue layer
Date: Fri, 12 Jul 2024 11:24:42 +0200	[thread overview]
Message-ID: <2bed7dbe-1f43-4560-b9df-f9df8bf6fc9d@kernel.org> (raw)
In-Reply-To: <20240710-ls-dwc-v1-1-62f8cbed31d7@nxp.com>

On 11/07/2024 01:02, Frank Li wrote:
> Add fsl,ls-dwc3.yaml for layerscape usb3 glue layer.
> 
> Layerscape supports DMA coherent bus fabric. It needs to pass down a
> software-managed property to the DWC3 core.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/usb/fsl,ls-dwc3.yaml       | 50 ++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/fsl,ls-dwc3.yaml b/Documentation/devicetree/bindings/usb/fsl,ls-dwc3.yaml
> new file mode 100644
> index 0000000000000..e79416122d12b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/fsl,ls-dwc3.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/fsl,ls-dwc3.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale layerscape DWC3 USB controller
> +
> +maintainers:
> +  - Frank Li <Frank.Li@nxp.com>
> +
> +properties:
> +  compatible:
> +    const: fsl,ls1028a-dwc3

Responding also here, so Greg won't pick it up: as Rob explained,
without reg this is an useless placeholder/wrapper, so instead go
without the wrapper node.

Best regards,
Krzysztof


  reply	other threads:[~2024-07-12  9:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10 23:02 [PATCH 0/3] usb: dwc3: add fsl,ls-dwc3 glue layer support Frank Li
2024-07-10 23:02 ` [PATCH 1/3] dt-bindings: usb: Add fsl,ls-dwc3.yaml for layerscape usb3 glue layer Frank Li
2024-07-12  9:24   ` Krzysztof Kozlowski [this message]
2024-07-10 23:02 ` [PATCH 2/3] usb: dwc3: of-simple: Add compatible string fsl,ls1028a-dwc3 Frank Li
2024-07-10 23:02 ` [PATCH 3/3] arm64: dts: layerscape: move dwc3 usb under glue layer node Frank Li
2024-07-11 21:38   ` Rob Herring
2024-07-30 15:48     ` Frank Li
2024-08-07  0:41       ` Thinh Nguyen
2024-08-07 14:30         ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bed7dbe-1f43-4560-b9df-f9df8bf6fc9d@kernel.org \
    --to=krzk@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).