From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB9EC43334 for ; Sun, 5 Jun 2022 16:10:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346003AbiFEQKA (ORCPT ); Sun, 5 Jun 2022 12:10:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234405AbiFEQJ5 (ORCPT ); Sun, 5 Jun 2022 12:09:57 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDB851C908 for ; Sun, 5 Jun 2022 09:09:56 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id kq6so11706927ejb.11 for ; Sun, 05 Jun 2022 09:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=WXuUPPn6pqEoecB1CMvgFgHHVc8dzCQtsrq8BhZMrgc=; b=WIaSpYQ+crFGMhUCl6zgXOd7jeXuMnX8cuXFbBSGJA6v0q3QcBHh3VjPHtutcU1lwa UEbE4C78fYnZe8V3v5Ebe5jy9D1XMA928T1qDDNICXmshwgKIXA/+UVJVcXVG7Snenvt bOHwL+38+Z+U6ZwXOJBvw1CnRPK3osqR/btRRZJE0LjGnEzFCHQamXZq1ux1Jf0z6Wz8 3vZWQvnwOXTIb92luWxhDDTLphN7djAEOzlu411u2z1/8iMcUGVVoJ9gTPfu/07XYuG3 HeNCAt5PvL8OMmTVO/73AsLCM6qCTw+7VkGx/ol5N2dFN+Z4myX7zmxAR2NeoklfAnjZ 2n7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=WXuUPPn6pqEoecB1CMvgFgHHVc8dzCQtsrq8BhZMrgc=; b=dipd4O9z3Eku6TdsyPXQFN7OgSSr4yHY9aGDl/GvZZcfCtu7XaNb2rGOcdmk9lqqC/ XOGy3rgY4vcnDybvHoMxx8hBh4nG6S3MHnp46+y+boov/V+c/xGv1ZOGpRz4RNU74bXW jvMkxgfXMkBC0Ld4dAdhOswDGNtbmUdftu85xjEK1BjaIVhJb60xKYYNCpBqIxfpZqwT vZ2lvE8Tl3b9Wczc1CIC5o5AaFDMCkRmxZSZJkj4K4mqicmpy31wJ/LNGBiryayRI/JV UbdY3E8Cn+ONfJ26L5SYEIb6yhvrxLqi+k5ELedGf1j9w75YFRYn4l6p3scPWH3jPz/L MU5w== X-Gm-Message-State: AOAM533oeNYI1PBuNt60PTIVxpDfO3LKFT2CR5ETJNmTRHJ7hXzu95N3 FY0690V1XK++Wb42QCffacWmXvlv3+r9sw== X-Google-Smtp-Source: ABdhPJyqxxmSVxagsYXopLmk5gZz5Rj53CwHm5DsGfP1qoncV9Qw1zrBEBKtMKfjglvk33U7h84CoA== X-Received: by 2002:a17:907:2cc4:b0:6fe:2100:de21 with SMTP id hg4-20020a1709072cc400b006fe2100de21mr17660853ejc.462.1654445395529; Sun, 05 Jun 2022 09:09:55 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id hz14-20020a1709072cee00b00708e906faecsm4856703ejc.124.2022.06.05.09.09.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jun 2022 09:09:55 -0700 (PDT) Message-ID: <2c0d4c55-ed79-0b6d-3429-a4cefb16d808@linaro.org> Date: Sun, 5 Jun 2022 18:09:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 3/5] phy: samsung: ufs: constify samsung_ufs_phy_cfg Content-Language: en-US To: Chanho Park , Kishon Vijay Abraham I , Vinod Koul , Alim Akhtar , Rob Herring , Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220603020410.2976-1-chanho61.park@samsung.com> <20220603020410.2976-4-chanho61.park@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220603020410.2976-4-chanho61.park@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/06/2022 04:04, Chanho Park wrote: > Put const qualifier of samsung_ufs_phy_cfg pointer because they will > not be changed from drvdata. > > Signed-off-by: Chanho Park > --- > drivers/phy/samsung/phy-samsung-ufs.c | 4 ++-- > drivers/phy/samsung/phy-samsung-ufs.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/phy/samsung/phy-samsung-ufs.c b/drivers/phy/samsung/phy-samsung-ufs.c > index ed272631e8aa..e1e26da27245 100644 > --- a/drivers/phy/samsung/phy-samsung-ufs.c > +++ b/drivers/phy/samsung/phy-samsung-ufs.c > @@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct phy *phy) > static int samsung_ufs_phy_calibrate(struct phy *phy) > { > struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy); > - struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfgs; > + const struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfgs; > const struct samsung_ufs_phy_cfg *cfg; > int err = 0; > int i; > @@ -327,7 +327,7 @@ static int samsung_ufs_phy_probe(struct platform_device *pdev) > drvdata = match->data; > phy->dev = dev; > phy->drvdata = drvdata; > - phy->cfgs = (struct samsung_ufs_phy_cfg **)drvdata->cfgs; > + phy->cfgs = drvdata->cfgs; > phy->isol = &drvdata->isol; > phy->lane_cnt = PHY_DEF_LANE_CNT; > > diff --git a/drivers/phy/samsung/phy-samsung-ufs.h b/drivers/phy/samsung/phy-samsung-ufs.h > index 1788b356cf56..101497698f23 100644 > --- a/drivers/phy/samsung/phy-samsung-ufs.h > +++ b/drivers/phy/samsung/phy-samsung-ufs.h > @@ -121,7 +121,7 @@ struct samsung_ufs_phy { > struct clk *rx0_symbol_clk; > struct clk *rx1_symbol_clk; > const struct samsung_ufs_phy_drvdata *drvdata; > - struct samsung_ufs_phy_cfg **cfgs; > + const struct samsung_ufs_phy_cfg **cfgs; I still think this should be array of const pointers to const data, so: const struct samsung_ufs_phy_cfg * const *cfgs; I proposed this in last email. Best regards, Krzysztof