From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A73FDC004D4 for ; Wed, 18 Jan 2023 09:00:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229722AbjARJAe (ORCPT ); Wed, 18 Jan 2023 04:00:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbjARI7m (ORCPT ); Wed, 18 Jan 2023 03:59:42 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B9F3611F1 for ; Wed, 18 Jan 2023 00:19:28 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id r30so8653095wrr.10 for ; Wed, 18 Jan 2023 00:19:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6JEKWwonctGpIYQyBgQI4ckxGQ2LgFs9BvZSmjtP02g=; b=fpeFIu5SCiWtEqzPdjMpQQnizSO5gHn6+T9L7i5dI4vq1TwgPoyO+Mxc+G27U2jGEl uV3+vDLrYYQ0pKO+ekeTkzFqUzbdFZUB6yGM718pxmjsW2V8dk8dv/0zM6lu4/vPfBdf sWO/UtTk2hA0lONjcHhDSUK8R0CmJGti2Qw2LVjztthaM+/IVeiKjAu6J+zktnrqAwml Tf7PPxd7YlGEuIYs0oGVAm+Uq1aZz0ZtsXTCd8mwh84w86bS3PzcDTn+A10dEbifl/+A CLMwomuVhrhQ1jX+CMv6TcIBO/JF6dlANR9gkSunl8P2A+FALJ2D2//M6NwoCC9ninaS +F6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6JEKWwonctGpIYQyBgQI4ckxGQ2LgFs9BvZSmjtP02g=; b=QJEMiMrg3llImVI73G4OkvGHT8N8tgaX+Yw8JC5/U6QX1OlQZ4IpOOnUjOoGaBETO/ yrtwa+N+3bOfvrWkad3JetNXX2CdZrAzc/05uDsQr7701O6vTDNXYYjQDniRpIh7Mg6h ruFV3Jorl7n5EKAnk2Z7Uxy0Hp0IjreKuhmYpxOVk67Ej1OfAcTNE9aKL1gjkH2HqUoX ZNDFlja5Rkxwh8Qkg8zOeTXfADzUZ4levFx7FV93KzzTCJardyxlHZxTVEB0QsoGhjnC /RrL3dUPDCBzgb1UMKpTAIs1LOKSqhjd6yw7Hv3pd9RsWvm5ubajdTj9tWCcPDZjohTa oNwQ== X-Gm-Message-State: AFqh2kru5EMmMiaN/ajOvh4Fi+ldRlxwYcdK9GJgfjMf8sLoL7qxH+0t 6WqNLlYz3opa+n+6pw8BvLpwLg== X-Google-Smtp-Source: AMrXdXtxvx6Qk2yzHCCoZTw0Gh6jNnIwwmM6YD/JTJFYkSjAFXi/y1n5cO2P1+elzl5fykTlk+PbJQ== X-Received: by 2002:a5d:50c9:0:b0:2b4:790e:32f3 with SMTP id f9-20020a5d50c9000000b002b4790e32f3mr4986316wrt.68.1674029967087; Wed, 18 Jan 2023 00:19:27 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id e7-20020a056000120700b00241dd5de644sm30685430wrx.97.2023.01.18.00.19.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 00:19:26 -0800 (PST) Message-ID: <2c17eaa5-ee93-58c5-a35a-8366eb4cfc36@linaro.org> Date: Wed, 18 Jan 2023 09:19:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/9] dt-bindings: usb: Add binding for Via lab VL817 hub controller Content-Language: en-US To: Anand Moon , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski Cc: linux-amlogic@lists.infradead.org, Matthias Kaehlcke , Alexander Stein , Johan Hovold , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230118044418.875-1-linux.amoon@gmail.com> <20230118044418.875-7-linux.amoon@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230118044418.875-7-linux.amoon@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/01/2023 05:44, Anand Moon wrote: > The VIA Lab VL817 is a USB 3.1 Gen 1 hub and USB 2.0 hub > controller that features 4 downstream ports and 1 otg, with > an internal 5V regulator and has external reset pin. Subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings. > > Add a device tree binding for its USB protocol part. > The internal LDO is not covered by this and can just be modelled > as a fixed regulator. > > Add combo of USB 2.0 and USB 3.0 root hub using peer-hub. > > Signed-off-by: Anand Moon > --- > v2 - fix the compatible string and fix the $id > - update the commit message. > - update the example for use peer-hub node because it > combo of USB 2.0 and USB 3.0 hub. > - rename the yaml file from vialab,vl817q7.yaml to vialab,vl817.yaml > as q7 suffix is ued for USB 3.1 and q5 suffix is used for USB 2.0. > --- > .../devicetree/bindings/usb/vialab,vl817.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/vialab,vl817.yaml > > diff --git a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml > new file mode 100644 > index 000000000000..5f9771e22058 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/vialab,vl817.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Via labs VL817 USB 3.1 hub controller > + > +maintainers: > + - Anand Moon > + > +allOf: > + - $ref: usb-device.yaml# > + > +properties: > + compatible: > + items: Drop items > + - enum: > + - usb2109,2817 > + - usb2109,817 > + > + reg: true > + > + reset-gpios: > + description: GPIO controlling the RESET# pin. maxItems > + > + vdd-supply: > + description: > + phandle to the regulator that provides power to the hub. > + > + peer-hub: > + $ref: '/schemas/types.yaml#/definitions/phandle' Drop quotes > + description: > + phandle to the peer hub on the controller. > + > +required: > + - peer-hub > + - compatible > + - reg Keep same order as in properties: part. > + Best regards, Krzysztof