From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8107BC0015E for ; Wed, 19 Jul 2023 09:46:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229704AbjGSJqC (ORCPT ); Wed, 19 Jul 2023 05:46:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230056AbjGSJp4 (ORCPT ); Wed, 19 Jul 2023 05:45:56 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20FA71BE4 for ; Wed, 19 Jul 2023 02:45:54 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-992af8b3b1bso913496766b.1 for ; Wed, 19 Jul 2023 02:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689759952; x=1692351952; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hgDMq8EIs6cspXF6h80EUdVrIdTF49gQA8Jmrcfwu8g=; b=G0NhZBDiVzdqDKmNidzXpVTTlrgUn853zGTxU3EvK5rxIR4e9IBv6tesf/GFDoH/RH 0zage/xH+HJrFRElelFJGFU93Uch6HW1DVDOpOY99SsDbowmR0qBVzISY1dLzOCOJjDi Hlli/Uup8eu0arXpzS/KKziNgMxDtODc4wUrRxDwxPL5KPCdQOOpJfwKrDq6crANldnQ k/75QdimFUxu5NvmgvgLfR76rcmT3JiFUz4sdjEWQ7cnJVlxkyAnjhHueJqpHl6AFnIp DddFx/7vLLIPECUXadL2ElFrv5iZ1sKvuWUh4JejAjLCR32hJjW6gvyh5FowP9RdIjaa w4Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689759952; x=1692351952; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hgDMq8EIs6cspXF6h80EUdVrIdTF49gQA8Jmrcfwu8g=; b=ZCzKWbw39Zqpy5n2kPDHor2E7HiLArkjRFT3Kjkg2lyvnf92lolYai2PHhqvCv7Fss lWbd0j7B2ULIur+D8y/aj78t/SGmw95cf1frQ9iwOcsoG3sYj8myc050o1TI3dWttKlw ausc1RbLvYuKTYkf8JM/eEht/AX4jEaTAbLfox6mmTu0svpqW6XS2AxrBXgtnGzl9qRE E3koItAt8OgeIFWsyA45CfHjsPRfKJFuCfjftq+x6b23MyuoZwO+UVK4UxBUB2HeZNl6 XR+blaepJOZdcKZfQq4BdWiesypmhwr5WT2x9YUCJdz/zQswtthKhSyaWBE73XXpRoC/ V8Yg== X-Gm-Message-State: ABy/qLZT9CbsXL94jEzBCUYOzJHKQrB1rSvXPeyvzMDG2FOlGfgj/t0v id6TyEE+a4Ibxl2mI537H4lv2w== X-Google-Smtp-Source: APBJJlHexnJstMsdtGTJCbSIgOlieYQJgNdMtFqtxAgvGnbbXeTx2dJ1MnyPK18EMK3MjtK+PnfcDw== X-Received: by 2002:a17:906:7a4a:b0:993:e883:491f with SMTP id i10-20020a1709067a4a00b00993e883491fmr2340646ejo.8.1689759952496; Wed, 19 Jul 2023 02:45:52 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id v10-20020a1709060b4a00b00999bb1e01dfsm774352ejg.52.2023.07.19.02.45.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 02:45:52 -0700 (PDT) Message-ID: <2c1c69bf-3cd5-4d68-43db-696ce0f15197@linaro.org> Date: Wed, 19 Jul 2023 11:45:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3] arm64: dts: qcom: sdm630: Add support for modem remoteproc Content-Language: en-US To: Alexey Minnekhanov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20230719093458.2668842-1-alexeymin@postmarketos.org> From: Krzysztof Kozlowski In-Reply-To: <20230719093458.2668842-1-alexeymin@postmarketos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/07/2023 11:34, Alexey Minnekhanov wrote: > Modem subsystem in SDM630/660 is similar to MSM8998 and > device tree node for it is based on the one from msm8998.dtsi. > > Signed-off-by: Alexey Minnekhanov > --- > > V3: Use memory-region property to specify memory regions, instead > of using "mba" and "mpss" subnodes. > > V2 link: https://lore.kernel.org/lkml/20230621175046.61521-3-alexeymin@postmarketos.org/ > > arch/arm64/boot/dts/qcom/sdm630.dtsi | 59 ++++++++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi > index 2136ded22f7e..797625cf78ac 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi > @@ -1032,6 +1032,65 @@ data-pins { > }; > }; > > + remoteproc_mss: remoteproc@4080000 { > + compatible = "qcom,sdm660-mss-pil"; Missing bindings so standard comment: It does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof