From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ruipeng Qi <ruipengqi7@gmail.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org
Cc: qiruipeng@lixiang.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 4/7] dt-bindings: reserved-memory: Support osdump module
Date: Thu, 21 Dec 2023 17:22:24 +0100 [thread overview]
Message-ID: <2c54c808-fa46-48fe-82d4-7628f5c799c5@linaro.org> (raw)
In-Reply-To: <20231221133158.729-1-ruipengqi7@gmail.com>
On 21/12/2023 14:31, Ruipeng Qi wrote:
> From: qiruipeng <qiruipeng@lixiang.com>
>
> Add bindings to allow osdump module to store dump in reserved-memory
> region named "osdump".
>
> Signed-off-by: qiruipeng <qiruipeng@lixiang.com>
I have some doubts whether you used your name or just email address as
name...
> ---
> .../bindings/reserved-memory/osdump.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reserved-memory/osdump.yaml
>
> diff --git a/Documentation/devicetree/bindings/reserved-memory/osdump.yaml b/Documentation/devicetree/bindings/reserved-memory/osdump.yaml
> new file mode 100644
> index 000000000000..149bf0204e68
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reserved-memory/osdump.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reserved-memory/osdump.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OS minidump module
> +
> +description: |
> + Specifies that the reserved memory region can be used for OS minidump
> + module.
I don't see any explanation why this is needed and what you are
describing here. Use simply reserved memory.
If you need any osdump, then work with minidump series. Some time ago we
were asking people to come with their needs. I did not get any other
series, so no clue what you are doing, but just in case:
NAK for second "minidump" clone.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-12-21 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 13:31 [RFC PATCH 4/7] dt-bindings: reserved-memory: Support osdump module Ruipeng Qi
2023-12-21 16:22 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c54c808-fa46-48fe-82d4-7628f5c799c5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiruipeng@lixiang.com \
--cc=robh+dt@kernel.org \
--cc=ruipengqi7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).