From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 800A3C433EF for ; Thu, 2 Jun 2022 12:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234973AbiFBM0U (ORCPT ); Thu, 2 Jun 2022 08:26:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235033AbiFBM0R (ORCPT ); Thu, 2 Jun 2022 08:26:17 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CB192985AA for ; Thu, 2 Jun 2022 05:26:09 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id q21so9683086ejm.1 for ; Thu, 02 Jun 2022 05:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=l0e+QqCCjFx8f2OLbKQ+40o0Vy08QxD2mn2l44RhFqk=; b=Nog3DQYN4J+cB/fbmluiaMsCH/GEsYKtdT45PVLBiw2jKYQkdhhVUysv0ef7qxi5IW aE8WpuDdI6v/NncvujJcJ4EYi8xwKg7+DxNzdA5fl9LrHbBpppRImfqFr8Jq8ZT48aTX PM/01Xa8gaQOW1DTj9IAkZWZNeJhBN3zuY9ralaG7fd3uNY4Q+0rRFiLcIlCZtvU9KOW b/q6MlU24eUHFojZjVgH24tBtY3Pm/BW7XnaFMNMoLOUSIYEvb46JFbJSFz+CLoqK77A OOnr4Kw9TL/sqpX2+7szIKKFHDvMHBcJyMeDrthV16bc99bfngWqbXiC522v8fdsJoYh jxaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=l0e+QqCCjFx8f2OLbKQ+40o0Vy08QxD2mn2l44RhFqk=; b=FYxLPvNAZEIewKG/iuFriBtMuhpqBpvtOlnFPLpazNmcrd92j9uixdM8lB9zCOKFGc 0o+ULnfehY16XjY5eJZflT2r+2XnA0NH0g8nRrqckDqTr1adYdEh/7QhRxpRumCQYKPT /itJ9pHDhxsivx9FEreiHwMtqZeSgnOpzpHFUSjrMCEGY561hRDOlzhMtlHNa2zB21Pl PPnbo9oqNLkgxnW60GiaFGNyt6eFFKOxLcTuBLjKOCRHfH6bWkH7j2VnOBkSGEIiVcH6 vw3qcfOt+dHVd9yjYebD29/GylLH4ehGHhgsFaJp3jlDgtV4ot4gAbS/9VEcmUs1hYZH COlA== X-Gm-Message-State: AOAM533O9plhxe92YywEEaZvl/WYG/vbMIDoCUZO6DViE6FakGv1aRx/ YnbgCT28QnQbbH2izLHbMT8YUw== X-Google-Smtp-Source: ABdhPJyJKtUxGXFMU3/LbZTcWeEqPqvfdbUMPT0Dy5tDfhr7+6snoslGd5TY/yGd2/qhA/NuG5+fVw== X-Received: by 2002:a17:907:97c7:b0:6fe:f7eb:be67 with SMTP id js7-20020a17090797c700b006fef7ebbe67mr4169542ejc.559.1654172767738; Thu, 02 Jun 2022 05:26:07 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id j10-20020a170906830a00b006f3ef214dc0sm1684967ejx.38.2022.06.02.05.26.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 05:26:07 -0700 (PDT) Message-ID: <2c610d82-65bf-60c8-05f3-434eaa1cfc8b@linaro.org> Date: Thu, 2 Jun 2022 14:26:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v1] dt-bindings: dsp: mediatek: add mt8186 dsp document Content-Language: en-US To: Tinghan Shen , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220422071534.15653-1-tinghan.shen@mediatek.com> <591767ee-e349-7a17-a9e9-b95d0500c7c1@linaro.org> <774c075ca4ad815c88be755cfb51889a171e835d.camel@mediatek.com> <9e3f5586-59fa-42cc-770c-b8694b4f2bf3@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/06/2022 13:53, Tinghan Shen wrote: > Hi Krzysztof, > > On Thu, 2022-06-02 at 12:45 +0200, Krzysztof Kozlowski wrote: >> On 02/06/2022 12:19, Tinghan Shen wrote: >>> Hi Krzysztof, >>> >>> On Thu, 2022-06-02 at 09:40 +0200, Krzysztof Kozlowski wrote: >>>> On 02/06/2022 08:44, Tinghan Shen wrote: >>>>>>> + mbox-names: >>>>>>> + items: >>>>>>> + - const: mbox0 >>>>>>> + - const: mbox1 >>>>>> >>>>>> These should be rather some meaningful names, e.g. "rx" and "tx". >>>>> >>>>> The mbox name has to align with the adsp ipc driver. >>>>> The adsp ipc driver is using 'mbox%d' for mailbox channels. >>>>> >>>>> >>>>> >>> >>> > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=9db69df4bdd37eb1f65b6931ee067fb15b9a4d5c__;!!CTRNKA9wMg0ARbw!1TmempNkQhC5QuLBhyfWo_AC97MoLuWipsGV-LPaW9RKNPheU7Bgc-eboNi1JA1nC5I$ >>>>> >>>>> >>>>> chan_name = kasprintf(GFP_KERNEL, "mbox%d", i); >>>>> >>>>> /* ...snip... */ >>>>> >>>>> adsp_chan->ch = mbox_request_channel_byname(cl, chan_name); >>>>> >>>>> Is it ok to continue using these names? >>>> >>>> It is a bit confusing... how did that driver got merged recently without >>>> bindings? Why bindings are separate? >>>> >>>> The bindings always come together in one patchset with the driver >>>> implementing them. Bindings are though a separate patch, yet still >>>> followed by the driver which uses them. >>>> >>>> I do not see any compatibles in that driver, which suggests there is no >>>> other binding using it. If that's correct, then you need to change the >>>> driver. >>>> >>> >>> The mtk-adsp-ipc driver's sole function is to encapsulate the operations >>> of mailbox framework from adsp ipc users. The mtk-adsp-ipc is not defined >>> in the dts file and we don't need it to be defined. The creation of mtk-adsp-ipc >>> device is requested by adsp ipc users via the use of 'platform_device_register_data'[1]. >>> >>> the driver implemented the mailbox framework is 'mtk-adsp-mailbox'[2]. it has >>> corresponding hardwares and a yaml file[3] to describe it. >> >> I don't understand how is this related. We talk here about the >> mbox-names for this bindings file. You replied, that these bindings are >> already used by something, but now you say that they are not? So why do >> you need to change anything in any driver? >> >> Simple question - do the bindings here "add mt8186 dsp document" are >> used by any specific Linux driver already? > > This bindings, 'add mt8186 dsp document', are used by the SOF sound driver of MT8186[1]. > > I'm sorry for miss leading you in previous reply. I was thought that you're > asking why the mtk-adsp-ipc driver got merged without bindings. So, I tried > to explain why mtk-adsp-ipc doesn't have bindings. Then my question is kind of still valid: How did "mt8186 SOF" driver got merged recently without bindings? Why bindings are separate? You cannot just sneak in usage of bindings in a driver, then submit bindings and say "we already have an user!". No, the bindings come with the driver. Always. Linked patch [1] brings undocumented compatible mediatek,mt8186-dsp, so you should see big fat warning when running checkpatch. So this points that you did not run checkpatch which is another not acceptable submission. :( [1] https://lore.kernel.org/all/20220422055659.8738-2-tinghan.shen@mediatek.com/ Best regards, Krzysztof